acpi: More trace points

[Qemu-devel] [PATCH 0/3] acpi: More trace points

Markus Armbruster posted 3 patches 5 years ago

Download series mbox

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test checkpatch passed

Test asan passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190402161900.7374-1-armbru@redhat.com

Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Igor Mammedov <imammedo@redhat.com>

hw/acpi/pcihp.c      | 32 +++++++++++++++-----------------
hw/acpi/piix4.c      | 14 +++-----------
hw/acpi/trace-events | 16 ++++++++++++++++
3 files changed, 34 insertions(+), 28 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/3] acpi: More trace points

Posted by Markus Armbruster 5 years ago

I wrote these patches to help me debug an unplug failure.  I expect
them to be helpful for others, too.

Markus Armbruster (3):
  acpi/piix4: Convert debug printf()s to trace events
  acpi/pcihp: Convert debug printf()s to trace events
  acpi/pcihp: Add a few more trace points related to unplug

 hw/acpi/pcihp.c      | 32 +++++++++++++++-----------------
 hw/acpi/piix4.c      | 14 +++-----------
 hw/acpi/trace-events | 16 ++++++++++++++++
 3 files changed, 34 insertions(+), 28 deletions(-)

-- 
2.17.2

Re: [Qemu-devel] [PATCH 0/3] acpi: More trace points

Posted by Markus Armbruster 4 years, 11 months ago

Ping?

Markus Armbruster <armbru@redhat.com> writes:

> I wrote these patches to help me debug an unplug failure.  I expect
> them to be helpful for others, too.
>
> Markus Armbruster (3):
>   acpi/piix4: Convert debug printf()s to trace events
>   acpi/pcihp: Convert debug printf()s to trace events
>   acpi/pcihp: Add a few more trace points related to unplug
>
>  hw/acpi/pcihp.c      | 32 +++++++++++++++-----------------
>  hw/acpi/piix4.c      | 14 +++-----------
>  hw/acpi/trace-events | 16 ++++++++++++++++
>  3 files changed, 34 insertions(+), 28 deletions(-)

Re: [Qemu-devel] [PATCH 0/3] acpi: More trace points

Posted by Michael S. Tsirkin 4 years, 11 months ago

tagged, thanks!

On Wed, May 08, 2019 at 01:19:47PM +0200, Markus Armbruster wrote:
> Ping?
> 
> Markus Armbruster <armbru@redhat.com> writes:
> 
> > I wrote these patches to help me debug an unplug failure.  I expect
> > them to be helpful for others, too.
> >
> > Markus Armbruster (3):
> >   acpi/piix4: Convert debug printf()s to trace events
> >   acpi/pcihp: Convert debug printf()s to trace events
> >   acpi/pcihp: Add a few more trace points related to unplug
> >
> >  hw/acpi/pcihp.c      | 32 +++++++++++++++-----------------
> >  hw/acpi/piix4.c      | 14 +++-----------
> >  hw/acpi/trace-events | 16 ++++++++++++++++
> >  3 files changed, 34 insertions(+), 28 deletions(-)

Re: [Qemu-devel] [PATCH 0/3] acpi: More trace points

Posted by Philippe Mathieu-Daudé 5 years ago

On 4/2/19 6:18 PM, Markus Armbruster wrote:
> I wrote these patches to help me debug an unplug failure.  I expect
> them to be helpful for others, too.

Appreciated.

FYI I have a WiP branch where I use existing tracepoints to check events
order and timing (using Avocado).

Series:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> 
> Markus Armbruster (3):
>   acpi/piix4: Convert debug printf()s to trace events
>   acpi/pcihp: Convert debug printf()s to trace events
>   acpi/pcihp: Add a few more trace points related to unplug
> 
>  hw/acpi/pcihp.c      | 32 +++++++++++++++-----------------
>  hw/acpi/piix4.c      | 14 +++-----------
>  hw/acpi/trace-events | 16 ++++++++++++++++
>  3 files changed, 34 insertions(+), 28 deletions(-)
>