qapi/migration.json: Clean up for COLOStatus

[Qemu-devel] [PATCH] qapi/migration.json: Clean up for COLOStatus

Zhang Chen posted 1 patch 5 years ago

Download mbox

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test checkpatch passed

Test asan passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190402085521.17973-1-chen.zhang@intel.com

Maintainers: Eric Blake <eblake@redhat.com>, Juan Quintela <quintela@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Markus Armbruster <armbru@redhat.com>

qapi/migration.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] qapi/migration.json: Clean up for COLOStatus

Posted by Zhang Chen 5 years ago

From: Zhang Chen <chen.zhang@intel.com>

Address Markus's comments change the 'last_mode' to 'last-mode'.

Signed-off-by: Zhang Chen <chen.zhang@intel.com>
---
 qapi/migration.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qapi/migration.json b/qapi/migration.json
index cfde29acf8..9217886c80 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -1380,7 +1380,7 @@
 # @mode: COLO running mode. If COLO is running, this field will return
 #        'primary' or 'secondary'.
 #
-# @last_mode: COLO last running mode. If COLO is running, this field
+# @last-mode: COLO last running mode. If COLO is running, this field
 #             will return same like mode field, after failover we can
 #             use this field to get last colo mode. (since 4.1)
 #
@@ -1389,7 +1389,7 @@
 # Since: 3.1
 ##
 { 'struct': 'COLOStatus',
-  'data': { 'mode': 'COLOMode', 'last_mode': 'COLOMode',
+  'data': { 'mode': 'COLOMode', 'last-mode': 'COLOMode',
             'reason': 'COLOExitReason' } }
 
 ##
-- 
2.17.GIT

Re: [Qemu-devel] [PATCH] qapi/migration.json: Clean up for COLOStatus

Posted by Markus Armbruster 5 years ago

Zhang Chen <chen.zhang@intel.com > writes:

> From: Zhang Chen <chen.zhang@intel.com>
>
> Address Markus's comments change the 'last_mode' to 'last-mode'.
>
> Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> ---
>  qapi/migration.json | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index cfde29acf8..9217886c80 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1380,7 +1380,7 @@
>  # @mode: COLO running mode. If COLO is running, this field will return
>  #        'primary' or 'secondary'.
>  #
> -# @last_mode: COLO last running mode. If COLO is running, this field
> +# @last-mode: COLO last running mode. If COLO is running, this field
>  #             will return same like mode field, after failover we can
>  #             use this field to get last colo mode. (since 4.1)
>  #
> @@ -1389,7 +1389,7 @@
>  # Since: 3.1
>  ##
>  { 'struct': 'COLOStatus',
> -  'data': { 'mode': 'COLOMode', 'last_mode': 'COLOMode',
> +  'data': { 'mode': 'COLOMode', 'last-mode': 'COLOMode',
>              'reason': 'COLOExitReason' } }
>  
>  ##

Reviewed-by: Markus Armbruster <armbru@redhat.com>

Queued for 4.0 with the commit message tweaked to just

    qapi/migration.json: Rename COLOStatus last_mode to last-mode

Hope that's okay.  Thank you!