[v4] misc usb-mtp fixes

[Qemu-devel] [PATCH v4 0/3] misc usb-mtp fixes

Bandan Das posted 3 patches 5 years ago

Diff against v1 v2 v3
Download series mbox

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test checkpatch passed

Test asan passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190401211712.19012-1-bsd@redhat.com

Maintainers: Gerd Hoffmann <kraxel@redhat.com>

hw/usb/dev-mtp.c | 133 +++++++++++++++++++++++------------------------
1 file changed, 66 insertions(+), 67 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v4 0/3] misc usb-mtp fixes

Posted by Bandan Das 5 years ago

v4:
  Added 1/3: <jpgva0nuddm.fsf@linux.bootlegged.copy>  
v3:
  2/2: Fix indentation
       Add back sending RES_OK for success
v2:
  1/2: Add Reviewed-by tag
  2/2: remove extra vars and directly call usb_mtp_queue_result
  
The first patch removes a unnecessary function
and the second is just a code reorg of usb_mtp_write_data
to make it less confusing. Applies on top of
[PATCH v3] usb-mtp: fix return status of delete
Message-ID: 

Bandan Das (3):
  usb-mtp: fix return status of delete
  usb-mtp: remove usb_mtp_object_free_one
  usb-mtp: refactor the flow of usb_mtp_write_data

 hw/usb/dev-mtp.c | 133 +++++++++++++++++++++++------------------------
 1 file changed, 66 insertions(+), 67 deletions(-)

-- 
2.19.2

Re: [Qemu-devel] [PATCH v4 0/3] misc usb-mtp fixes

Posted by Peter Maydell 4 years, 10 months ago

On Mon, 1 Apr 2019 at 22:17, Bandan Das <bsd@redhat.com> wrote:
>
> v4:
>   Added 1/3: <jpgva0nuddm.fsf@linux.bootlegged.copy>
> v3:
>   2/2: Fix indentation
>        Add back sending RES_OK for success
> v2:
>   1/2: Add Reviewed-by tag
>   2/2: remove extra vars and directly call usb_mtp_queue_result
>
> The first patch removes a unnecessary function
> and the second is just a code reorg of usb_mtp_write_data
> to make it less confusing. Applies on top of
> [PATCH v3] usb-mtp: fix return status of delete
> Message-ID:
>
> Bandan Das (3):
>   usb-mtp: fix return status of delete
>   usb-mtp: remove usb_mtp_object_free_one
>   usb-mtp: refactor the flow of usb_mtp_write_data

Hi Bandan, Gerd -- what's the status of this patchset?
I think this is the one that fixes the CID1399415
Coverity issue about usb_mtp_write_data() return values, right?

thanks
-- PMM

Re: [Qemu-devel] [PATCH v4 0/3] misc usb-mtp fixes

Posted by Gerd Hoffmann 4 years, 10 months ago

> > Bandan Das (3):
> >   usb-mtp: fix return status of delete
> >   usb-mtp: remove usb_mtp_object_free_one
> >   usb-mtp: refactor the flow of usb_mtp_write_data
> 
> Hi Bandan, Gerd -- what's the status of this patchset?
> I think this is the one that fixes the CID1399415
> Coverity issue about usb_mtp_write_data() return values, right?

1+2 fixes where merged during 4.0 freeze, 3 left for post-freeze.
It can follow now, queued up, next usb pull will have it.

thanks for the reminder,
  Gerd