[Qemu-devel] [PATCH] Add coroutine_fn to bdrv_check_co_entry

n.alekseev2104@gmail.com posted 1 patch 5 years, 1 month ago
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test checkpatch passed
Test asan passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190401093051.16488-1-n.alekseev2104@gmail.com
Maintainers: Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>
block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[Qemu-devel] [PATCH] Add coroutine_fn to bdrv_check_co_entry
Posted by n.alekseev2104@gmail.com 5 years, 1 month ago
From: Nikita Alekseev <n.alekseev2104@gmail.com>

bdrv_check_co_entry calls bdrv_co_check, which is a coroutine function.
Thus, it also needs to be marked as a coroutine.

Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
---
 block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block.c b/block.c
index 0a93ee9ac8..776c43f177 100644
--- a/block.c
+++ b/block.c
@@ -4121,7 +4121,7 @@ typedef struct CheckCo {
     int ret;
 } CheckCo;
 
-static void bdrv_check_co_entry(void *opaque)
+static void coroutine_fn bdrv_check_co_entry(void *opaque)
 {
     CheckCo *cco = opaque;
     cco->ret = bdrv_co_check(cco->bs, cco->res, cco->fix);
-- 
2.21.0


Re: [Qemu-devel] [PATCH] Add coroutine_fn to bdrv_check_co_entry
Posted by Stefan Hajnoczi 5 years ago
On Mon, Apr 01, 2019 at 12:30:51PM +0300, n.alekseev2104@gmail.com wrote:
> From: Nikita Alekseev <n.alekseev2104@gmail.com>
> 
> bdrv_check_co_entry calls bdrv_co_check, which is a coroutine function.
> Thus, it also needs to be marked as a coroutine.
> 
> Signed-off-by: Nikita Alekseev <n.alekseev2104@gmail.com>
> ---
>  block.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thank you!  I prefixed the commit message with "block: ".  Most commits
have a subsystem prefix to make browsing/searching git log easier.  In
the future you can add it yourself - look at git log for a file to
discover what prefix other people recently used.

Thanks, applied to my block-next tree:
https://github.com/stefanha/qemu/commits/block-next

Stefan