filemon: various fixes / improvements to file monitor for USB MTP

[Qemu-devel] [PATCH 0/3] filemon: various fixes / improvements to file monitor for USB MTP

Daniel P. Berrangé posted 3 patches 5 years, 1 month ago

Download series mbox

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test asan passed

Test checkpatch passed

Failed in applying to current master (apply log)

authz/listfile.c              |   2 +-
hw/usb/dev-mtp.c              |  10 +-
include/authz/listfile.h      |   2 +-
include/qemu/filemonitor.h    |  16 +-
tests/test-util-filemonitor.c | 648 +++++++++++++++++-----------------
util/filemonitor-inotify.c    |  26 +-
util/filemonitor-stub.c       |   4 +-
util/trace-events             |   6 +-
8 files changed, 354 insertions(+), 360 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/3] filemon: various fixes / improvements to file monitor for USB MTP

Posted by Daniel P. Berrangé 5 years, 1 month ago

Previously posted in 2 separate pieces at

  https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04885.html
  https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg05833.html

And a failed pull request

  https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg06035.html

The last patch had bigger changes in the test suite than anticipated,
so needs a explicit new review before I can justify re-trying the PULL
request

Daniel P. Berrangé (3):
  tests: refactor file monitor test to make it more understandable
  filemon: ensure watch IDs are unique to QFileMonitor scope
  filemon: fix watch IDs to avoid potential wraparound issues

 authz/listfile.c              |   2 +-
 hw/usb/dev-mtp.c              |  10 +-
 include/authz/listfile.h      |   2 +-
 include/qemu/filemonitor.h    |  16 +-
 tests/test-util-filemonitor.c | 648 +++++++++++++++++-----------------
 util/filemonitor-inotify.c    |  26 +-
 util/filemonitor-stub.c       |   4 +-
 util/trace-events             |   6 +-
 8 files changed, 354 insertions(+), 360 deletions(-)

-- 
2.20.1