hw/ppc/Makefile.objs | 2 +- hw/ppc/prep.c | 1 - hw/ppc/spapr.c | 48 ++- hw/ppc/spapr_pci.c | 19 ++ hw/ppc/spapr_pci_nvlink2.c | 450 ++++++++++++++++++++++++ hw/vfio/pci-quirks.c | 131 +++++++ hw/vfio/pci.c | 14 + hw/vfio/pci.h | 2 + hw/vfio/trace-events | 4 + include/hw/pci-host/spapr.h | 45 +++ include/hw/ppc/spapr.h | 5 +- target/ppc/cpu-models.c | 2 +- target/ppc/cpu-models.h | 3 +- target/ppc/cpu.h | 239 +++++++------ target/ppc/dfp_helper.c | 14 +- target/ppc/excp_helper.c | 87 +++-- target/ppc/fpu_helper.c | 134 +++++--- target/ppc/gdbstub.c | 34 +- target/ppc/helper_regs.h | 10 +- target/ppc/int_helper.c | 70 ++-- target/ppc/kvm.c | 178 ++++++---- target/ppc/kvm_ppc.h | 3 +- target/ppc/machine.c | 106 +++--- target/ppc/mem_helper.c | 33 +- target/ppc/mfrom_table.inc.c | 3 +- target/ppc/mfrom_table_gen.c | 8 +- target/ppc/misc_helper.c | 9 +- target/ppc/mmu-hash32.c | 19 +- target/ppc/mmu-hash64.c | 62 ++-- target/ppc/mmu_helper.c | 131 ++++--- target/ppc/monitor.c | 13 +- target/ppc/translate.c | 507 +++++++++++++++++----------- target/ppc/translate/fp-impl.inc.c | 52 +-- target/ppc/translate/spe-impl.inc.c | 14 +- target/ppc/translate/vmx-impl.inc.c | 26 +- target/ppc/translate/vsx-impl.inc.c | 15 +- target/ppc/translate_init.inc.c | 240 +++++++------ 37 files changed, 1921 insertions(+), 812 deletions(-) create mode 100644 hw/ppc/spapr_pci_nvlink2.c
target/ppc has a lot of old code that doesn't stick to the modern style guidelines. That means we keep getting checkpatch warnings from code motions in there, or from people copying the local style rather than the global style. I'm sick of it, so here's a big series to fix many of the style problems in target/ppc. It doesn't cover every checkpatch warning: outright false positives are ignored of course, but there are also some things that it's not obvious how to fix (often involving hairy nested macros). Still, it's a good start. Alexey Kardashevskiy (1): spapr: Support NVIDIA V100 GPU with NVLink2 David Gibson (23): target/ppc: Style fixes for ppc-models.[ch] target/ppc: Style fixes for cpu.[ch] target/ppc: Style fixes for int_helper.c target/ppc: Style fixes for fpu_helper.c target/ppc: Style fixes for dfp_helper.c target/ppc: Style fixes for excp_helper.c target/ppc: Style fixes for gdbstub.c target/ppc: Style fixes for helper_regs.h target/ppc: Style fixes for kvm_ppc.h and kvm.c target/ppc: Style fixes for machine.c target/ppc: Style fixes for mem_helper.c target/ppc: Style fixes for mfrom_table.inc.c & mfrom_table_gen.c target/ppc: Style fixes for misc_helper.c target/ppc: Style fixes for mmu-hash32.[ch] target/ppc: Style fixes for mmu-hash64.[ch] target/ppc: Style fixes for mmu_helper.c target/ppc: Style fixes for monitor.c target/ppc: Style fixes for translate_init.inc.c target/ppc: Style fixes for translate.c target/ppc: Style fixes for translate/fp-impl.inc.c target/ppc: Style fixes for translate/vsx-impl.inc.c target/ppc: Style fixes for translate/vmx-impl.inc.c target/ppc: Style fixes for translate/spe-impl.inc.c Philippe Mathieu-Daudé (1): hw/ppc/prep: Drop useless inclusion of "hw/input/i8042.h" hw/ppc/Makefile.objs | 2 +- hw/ppc/prep.c | 1 - hw/ppc/spapr.c | 48 ++- hw/ppc/spapr_pci.c | 19 ++ hw/ppc/spapr_pci_nvlink2.c | 450 ++++++++++++++++++++++++ hw/vfio/pci-quirks.c | 131 +++++++ hw/vfio/pci.c | 14 + hw/vfio/pci.h | 2 + hw/vfio/trace-events | 4 + include/hw/pci-host/spapr.h | 45 +++ include/hw/ppc/spapr.h | 5 +- target/ppc/cpu-models.c | 2 +- target/ppc/cpu-models.h | 3 +- target/ppc/cpu.h | 239 +++++++------ target/ppc/dfp_helper.c | 14 +- target/ppc/excp_helper.c | 87 +++-- target/ppc/fpu_helper.c | 134 +++++--- target/ppc/gdbstub.c | 34 +- target/ppc/helper_regs.h | 10 +- target/ppc/int_helper.c | 70 ++-- target/ppc/kvm.c | 178 ++++++---- target/ppc/kvm_ppc.h | 3 +- target/ppc/machine.c | 106 +++--- target/ppc/mem_helper.c | 33 +- target/ppc/mfrom_table.inc.c | 3 +- target/ppc/mfrom_table_gen.c | 8 +- target/ppc/misc_helper.c | 9 +- target/ppc/mmu-hash32.c | 19 +- target/ppc/mmu-hash64.c | 62 ++-- target/ppc/mmu_helper.c | 131 ++++--- target/ppc/monitor.c | 13 +- target/ppc/translate.c | 507 +++++++++++++++++----------- target/ppc/translate/fp-impl.inc.c | 52 +-- target/ppc/translate/spe-impl.inc.c | 14 +- target/ppc/translate/vmx-impl.inc.c | 26 +- target/ppc/translate/vsx-impl.inc.c | 15 +- target/ppc/translate_init.inc.c | 240 +++++++------ 37 files changed, 1921 insertions(+), 812 deletions(-) create mode 100644 hw/ppc/spapr_pci_nvlink2.c -- 2.20.1
Hi anyone about to comment on this series, Be aware there's a bogus groug@nongnu.org address is Cc list. Feel free to change it to groug@kaod.org or to remove it when you post. I'm watching the thread anyway. Cheers, -- Greg On Fri, 22 Mar 2019 11:15:19 +1100 David Gibson <david@gibson.dropbear.id.au> wrote: > target/ppc has a lot of old code that doesn't stick to the modern > style guidelines. That means we keep getting checkpatch warnings from > code motions in there, or from people copying the local style rather > than the global style. > > I'm sick of it, so here's a big series to fix many of the style > problems in target/ppc. > > It doesn't cover every checkpatch warning: outright false positives > are ignored of course, but there are also some things that it's not > obvious how to fix (often involving hairy nested macros). Still, it's > a good start. > > Alexey Kardashevskiy (1): > spapr: Support NVIDIA V100 GPU with NVLink2 > > David Gibson (23): > target/ppc: Style fixes for ppc-models.[ch] > target/ppc: Style fixes for cpu.[ch] > target/ppc: Style fixes for int_helper.c > target/ppc: Style fixes for fpu_helper.c > target/ppc: Style fixes for dfp_helper.c > target/ppc: Style fixes for excp_helper.c > target/ppc: Style fixes for gdbstub.c > target/ppc: Style fixes for helper_regs.h > target/ppc: Style fixes for kvm_ppc.h and kvm.c > target/ppc: Style fixes for machine.c > target/ppc: Style fixes for mem_helper.c > target/ppc: Style fixes for mfrom_table.inc.c & mfrom_table_gen.c > target/ppc: Style fixes for misc_helper.c > target/ppc: Style fixes for mmu-hash32.[ch] > target/ppc: Style fixes for mmu-hash64.[ch] > target/ppc: Style fixes for mmu_helper.c > target/ppc: Style fixes for monitor.c > target/ppc: Style fixes for translate_init.inc.c > target/ppc: Style fixes for translate.c > target/ppc: Style fixes for translate/fp-impl.inc.c > target/ppc: Style fixes for translate/vsx-impl.inc.c > target/ppc: Style fixes for translate/vmx-impl.inc.c > target/ppc: Style fixes for translate/spe-impl.inc.c > > Philippe Mathieu-Daudé (1): > hw/ppc/prep: Drop useless inclusion of "hw/input/i8042.h" > > hw/ppc/Makefile.objs | 2 +- > hw/ppc/prep.c | 1 - > hw/ppc/spapr.c | 48 ++- > hw/ppc/spapr_pci.c | 19 ++ > hw/ppc/spapr_pci_nvlink2.c | 450 ++++++++++++++++++++++++ > hw/vfio/pci-quirks.c | 131 +++++++ > hw/vfio/pci.c | 14 + > hw/vfio/pci.h | 2 + > hw/vfio/trace-events | 4 + > include/hw/pci-host/spapr.h | 45 +++ > include/hw/ppc/spapr.h | 5 +- > target/ppc/cpu-models.c | 2 +- > target/ppc/cpu-models.h | 3 +- > target/ppc/cpu.h | 239 +++++++------ > target/ppc/dfp_helper.c | 14 +- > target/ppc/excp_helper.c | 87 +++-- > target/ppc/fpu_helper.c | 134 +++++--- > target/ppc/gdbstub.c | 34 +- > target/ppc/helper_regs.h | 10 +- > target/ppc/int_helper.c | 70 ++-- > target/ppc/kvm.c | 178 ++++++---- > target/ppc/kvm_ppc.h | 3 +- > target/ppc/machine.c | 106 +++--- > target/ppc/mem_helper.c | 33 +- > target/ppc/mfrom_table.inc.c | 3 +- > target/ppc/mfrom_table_gen.c | 8 +- > target/ppc/misc_helper.c | 9 +- > target/ppc/mmu-hash32.c | 19 +- > target/ppc/mmu-hash64.c | 62 ++-- > target/ppc/mmu_helper.c | 131 ++++--- > target/ppc/monitor.c | 13 +- > target/ppc/translate.c | 507 +++++++++++++++++----------- > target/ppc/translate/fp-impl.inc.c | 52 +-- > target/ppc/translate/spe-impl.inc.c | 14 +- > target/ppc/translate/vmx-impl.inc.c | 26 +- > target/ppc/translate/vsx-impl.inc.c | 15 +- > target/ppc/translate_init.inc.c | 240 +++++++------ > 37 files changed, 1921 insertions(+), 812 deletions(-) > create mode 100644 hw/ppc/spapr_pci_nvlink2.c >
On Mon, Mar 25, 2019 at 09:56:34AM +0100, Greg Kurz wrote: > Hi anyone about to comment on this series, > > Be aware there's a bogus groug@nongnu.org address is Cc list. Feel > free to change it to groug@kaod.org or to remove it when you post. > I'm watching the thread anyway. Yeah, sorry about that. Thinko. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
On Fri, Mar 22, 2019 at 11:15:19AM +1100, David Gibson wrote: > target/ppc has a lot of old code that doesn't stick to the modern > style guidelines. That means we keep getting checkpatch warnings from > code motions in there, or from people copying the local style rather > than the global style. > > I'm sick of it, so here's a big series to fix many of the style > problems in target/ppc. > > It doesn't cover every checkpatch warning: outright false positives > are ignored of course, but there are also some things that it's not > obvious how to fix (often involving hairy nested macros). Still, it's > a good start. Oops, sorry, the first two patches weren't supposed to be in this series. > > Alexey Kardashevskiy (1): > spapr: Support NVIDIA V100 GPU with NVLink2 > > David Gibson (23): > target/ppc: Style fixes for ppc-models.[ch] > target/ppc: Style fixes for cpu.[ch] > target/ppc: Style fixes for int_helper.c > target/ppc: Style fixes for fpu_helper.c > target/ppc: Style fixes for dfp_helper.c > target/ppc: Style fixes for excp_helper.c > target/ppc: Style fixes for gdbstub.c > target/ppc: Style fixes for helper_regs.h > target/ppc: Style fixes for kvm_ppc.h and kvm.c > target/ppc: Style fixes for machine.c > target/ppc: Style fixes for mem_helper.c > target/ppc: Style fixes for mfrom_table.inc.c & mfrom_table_gen.c > target/ppc: Style fixes for misc_helper.c > target/ppc: Style fixes for mmu-hash32.[ch] > target/ppc: Style fixes for mmu-hash64.[ch] > target/ppc: Style fixes for mmu_helper.c > target/ppc: Style fixes for monitor.c > target/ppc: Style fixes for translate_init.inc.c > target/ppc: Style fixes for translate.c > target/ppc: Style fixes for translate/fp-impl.inc.c > target/ppc: Style fixes for translate/vsx-impl.inc.c > target/ppc: Style fixes for translate/vmx-impl.inc.c > target/ppc: Style fixes for translate/spe-impl.inc.c > > Philippe Mathieu-Daudé (1): > hw/ppc/prep: Drop useless inclusion of "hw/input/i8042.h" > > hw/ppc/Makefile.objs | 2 +- > hw/ppc/prep.c | 1 - > hw/ppc/spapr.c | 48 ++- > hw/ppc/spapr_pci.c | 19 ++ > hw/ppc/spapr_pci_nvlink2.c | 450 ++++++++++++++++++++++++ > hw/vfio/pci-quirks.c | 131 +++++++ > hw/vfio/pci.c | 14 + > hw/vfio/pci.h | 2 + > hw/vfio/trace-events | 4 + > include/hw/pci-host/spapr.h | 45 +++ > include/hw/ppc/spapr.h | 5 +- > target/ppc/cpu-models.c | 2 +- > target/ppc/cpu-models.h | 3 +- > target/ppc/cpu.h | 239 +++++++------ > target/ppc/dfp_helper.c | 14 +- > target/ppc/excp_helper.c | 87 +++-- > target/ppc/fpu_helper.c | 134 +++++--- > target/ppc/gdbstub.c | 34 +- > target/ppc/helper_regs.h | 10 +- > target/ppc/int_helper.c | 70 ++-- > target/ppc/kvm.c | 178 ++++++---- > target/ppc/kvm_ppc.h | 3 +- > target/ppc/machine.c | 106 +++--- > target/ppc/mem_helper.c | 33 +- > target/ppc/mfrom_table.inc.c | 3 +- > target/ppc/mfrom_table_gen.c | 8 +- > target/ppc/misc_helper.c | 9 +- > target/ppc/mmu-hash32.c | 19 +- > target/ppc/mmu-hash64.c | 62 ++-- > target/ppc/mmu_helper.c | 131 ++++--- > target/ppc/monitor.c | 13 +- > target/ppc/translate.c | 507 +++++++++++++++++----------- > target/ppc/translate/fp-impl.inc.c | 52 +-- > target/ppc/translate/spe-impl.inc.c | 14 +- > target/ppc/translate/vmx-impl.inc.c | 26 +- > target/ppc/translate/vsx-impl.inc.c | 15 +- > target/ppc/translate_init.inc.c | 240 +++++++------ > 37 files changed, 1921 insertions(+), 812 deletions(-) > create mode 100644 hw/ppc/spapr_pci_nvlink2.c > -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
David Gibson <david@gibson.dropbear.id.au> writes:
> target/ppc has a lot of old code that doesn't stick to the modern
> style guidelines. That means we keep getting checkpatch warnings from
> code motions in there, or from people copying the local style rather
> than the global style.
>
> I'm sick of it, so here's a big series to fix many of the style
> problems in target/ppc.
>
> It doesn't cover every checkpatch warning: outright false positives
> are ignored of course, but there are also some things that it's not
> obvious how to fix (often involving hairy nested macros). Still, it's
> a good start.
I reply because you marked this RFC, which indicates some uncertainty.
I'd like to encourage you.
The more bad examples exist in the code, the more time we'll waste on
correcting them in patch submission. You're sick of it. You're right.
We've demanded compliance to the QEMU coding style since 2009 (commit
e68b98dc723). If we had started to clean up existing code back then,
we'd be long done by now, and style cleanup's annoying impact on
git-blame would've long decayed to irrelevant levels.
I expect the only regrets you'll have about this series is not to have
done it earlier.
Diffstat without the patches you included by mistake:
26 files changed, 1210 insertions(+), 802 deletions(-)
This is actually a rather small fraction of the PPC code:
$ git-ls-files hw/ppc/ include/hw/ppc target/ppc/ | xargs wc | tail -n 1
90193 284261 3087364 total
$ git-ls-files hw/ppc/ include/hw/ppc target/ppc/ | wc -l
128
On Fri, Mar 22, 2019 at 07:55:57AM +0100, Markus Armbruster wrote: > David Gibson <david@gibson.dropbear.id.au> writes: > > > target/ppc has a lot of old code that doesn't stick to the modern > > style guidelines. That means we keep getting checkpatch warnings from > > code motions in there, or from people copying the local style rather > > than the global style. > > > > I'm sick of it, so here's a big series to fix many of the style > > problems in target/ppc. > > > > It doesn't cover every checkpatch warning: outright false positives > > are ignored of course, but there are also some things that it's not > > obvious how to fix (often involving hairy nested macros). Still, it's > > a good start. > > I reply because you marked this RFC, which indicates some uncertainty. > I'd like to encourage you. Well, in this case RFC was more a flag that I don't consider these patches ready to merge right away. But sure, I'll take encouragement. > The more bad examples exist in the code, the more time we'll waste on > correcting them in patch submission. You're sick of it. You're right. > > We've demanded compliance to the QEMU coding style since 2009 (commit > e68b98dc723). If we had started to clean up existing code back then, > we'd be long done by now, and style cleanup's annoying impact on > git-blame would've long decayed to irrelevant levels. > > I expect the only regrets you'll have about this series is not to have > done it earlier. Well.. the potential for conflicts with outstanding patches worries me a bit, but I definitely want to go ahead with this some time pretty soon. > > Diffstat without the patches you included by mistake: > > 26 files changed, 1210 insertions(+), 802 deletions(-) > > This is actually a rather small fraction of the PPC code: > > $ git-ls-files hw/ppc/ include/hw/ppc target/ppc/ | xargs wc | tail -n 1 > 90193 284261 3087364 total > $ git-ls-files hw/ppc/ include/hw/ppc target/ppc/ | wc -l > 128 Right, I'm only looking at target/ppc in this series, since that's where I've most encountered the problems. The spapr code in hw/ppc is mostly style compliant already. The other machines are a mixed bag, but I think they're mostly better than target/ppc at any rate. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
On Fri, 22 Mar 2019 11:15:19 +1100 David Gibson <david@gibson.dropbear.id.au> wrote: > target/ppc has a lot of old code that doesn't stick to the modern > style guidelines. That means we keep getting checkpatch warnings from > code motions in there, or from people copying the local style rather > than the global style. > > I'm sick of it, so here's a big series to fix many of the style > problems in target/ppc. > > It doesn't cover every checkpatch warning: outright false positives > are ignored of course, but there are also some things that it's not > obvious how to fix (often involving hairy nested macros). Still, it's > a good start. > Very nice cleanup ! :) I've sent some comments to make some cosmetic suggestions, but the series is already ok for me, so: Reviewed-by: Greg Kurz <groug@kaod.org> for the whole series, with or without my suggestions. > Alexey Kardashevskiy (1): > spapr: Support NVIDIA V100 GPU with NVLink2 > > David Gibson (23): > target/ppc: Style fixes for ppc-models.[ch] > target/ppc: Style fixes for cpu.[ch] > target/ppc: Style fixes for int_helper.c > target/ppc: Style fixes for fpu_helper.c > target/ppc: Style fixes for dfp_helper.c > target/ppc: Style fixes for excp_helper.c > target/ppc: Style fixes for gdbstub.c > target/ppc: Style fixes for helper_regs.h > target/ppc: Style fixes for kvm_ppc.h and kvm.c > target/ppc: Style fixes for machine.c > target/ppc: Style fixes for mem_helper.c > target/ppc: Style fixes for mfrom_table.inc.c & mfrom_table_gen.c > target/ppc: Style fixes for misc_helper.c > target/ppc: Style fixes for mmu-hash32.[ch] > target/ppc: Style fixes for mmu-hash64.[ch] > target/ppc: Style fixes for mmu_helper.c > target/ppc: Style fixes for monitor.c > target/ppc: Style fixes for translate_init.inc.c > target/ppc: Style fixes for translate.c > target/ppc: Style fixes for translate/fp-impl.inc.c > target/ppc: Style fixes for translate/vsx-impl.inc.c > target/ppc: Style fixes for translate/vmx-impl.inc.c > target/ppc: Style fixes for translate/spe-impl.inc.c > > Philippe Mathieu-Daudé (1): > hw/ppc/prep: Drop useless inclusion of "hw/input/i8042.h" > > hw/ppc/Makefile.objs | 2 +- > hw/ppc/prep.c | 1 - > hw/ppc/spapr.c | 48 ++- > hw/ppc/spapr_pci.c | 19 ++ > hw/ppc/spapr_pci_nvlink2.c | 450 ++++++++++++++++++++++++ > hw/vfio/pci-quirks.c | 131 +++++++ > hw/vfio/pci.c | 14 + > hw/vfio/pci.h | 2 + > hw/vfio/trace-events | 4 + > include/hw/pci-host/spapr.h | 45 +++ > include/hw/ppc/spapr.h | 5 +- > target/ppc/cpu-models.c | 2 +- > target/ppc/cpu-models.h | 3 +- > target/ppc/cpu.h | 239 +++++++------ > target/ppc/dfp_helper.c | 14 +- > target/ppc/excp_helper.c | 87 +++-- > target/ppc/fpu_helper.c | 134 +++++--- > target/ppc/gdbstub.c | 34 +- > target/ppc/helper_regs.h | 10 +- > target/ppc/int_helper.c | 70 ++-- > target/ppc/kvm.c | 178 ++++++---- > target/ppc/kvm_ppc.h | 3 +- > target/ppc/machine.c | 106 +++--- > target/ppc/mem_helper.c | 33 +- > target/ppc/mfrom_table.inc.c | 3 +- > target/ppc/mfrom_table_gen.c | 8 +- > target/ppc/misc_helper.c | 9 +- > target/ppc/mmu-hash32.c | 19 +- > target/ppc/mmu-hash64.c | 62 ++-- > target/ppc/mmu_helper.c | 131 ++++--- > target/ppc/monitor.c | 13 +- > target/ppc/translate.c | 507 +++++++++++++++++----------- > target/ppc/translate/fp-impl.inc.c | 52 +-- > target/ppc/translate/spe-impl.inc.c | 14 +- > target/ppc/translate/vmx-impl.inc.c | 26 +- > target/ppc/translate/vsx-impl.inc.c | 15 +- > target/ppc/translate_init.inc.c | 240 +++++++------ > 37 files changed, 1921 insertions(+), 812 deletions(-) > create mode 100644 hw/ppc/spapr_pci_nvlink2.c >
Patchew URL: https://patchew.org/QEMU/20190322001544.9794-1-david@gibson.dropbear.id.au/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190322001544.9794-1-david@gibson.dropbear.id.au
Subject: [Qemu-devel] [RFC for-4.1 00/25] Many style fixes for target/ppc
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/20190321144914.19934-1-clg@kaod.org -> patchew/20190321144914.19934-1-clg@kaod.org
* [new tag] patchew/20190322001544.9794-1-david@gibson.dropbear.id.au -> patchew/20190322001544.9794-1-david@gibson.dropbear.id.au
Switched to a new branch 'test'
d9a6215ecc target/ppc: Style fixes for translate/spe-impl.inc.c
65eb138512 target/ppc: Style fixes for translate/vmx-impl.inc.c
8d94edbb00 target/ppc: Style fixes for translate/vsx-impl.inc.c
3caa9d49eb target/ppc: Style fixes for translate/fp-impl.inc.c
101d9580ee target/ppc: Style fixes for translate.c
461682526f target/ppc: Style fixes for translate_init.inc.c
4aeb580b71 target/ppc: Style fixes for monitor.c
364bed3f12 target/ppc: Style fixes for mmu_helper.c
a2f32fdcab target/ppc: Style fixes for mmu-hash64.[ch]
d52341d796 target/ppc: Style fixes for mmu-hash32.[ch]
465ef88fa6 target/ppc: Style fixes for misc_helper.c
cf4f0dde0d target/ppc: Style fixes for mfrom_table.inc.c & mfrom_table_gen.c
6b40470682 target/ppc: Style fixes for mem_helper.c
197f1940be target/ppc: Style fixes for machine.c
cc497c316b target/ppc: Style fixes for kvm_ppc.h and kvm.c
62ba6a3440 target/ppc: Style fixes for helper_regs.h
a1eb273604 target/ppc: Style fixes for gdbstub.c
2731feaffd target/ppc: Style fixes for excp_helper.c
7061f73523 target/ppc: Style fixes for dfp_helper.c
07ce42ad0f target/ppc: Style fixes for fpu_helper.c
c4b4fbf526 target/ppc: Style fixes for int_helper.c
6a09c460c6 target/ppc: Style fixes for cpu.[ch]
d60f69cf64 target/ppc: Style fixes for ppc-models.[ch]
0b955f8caf hw/ppc/prep: Drop useless inclusion of "hw/input/i8042.h"
c57df151ad spapr: Support NVIDIA V100 GPU with NVLink2
=== OUTPUT BEGIN ===
1/25 Checking commit c57df151ad04 (spapr: Support NVIDIA V100 GPU with NVLink2)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#258:
new file mode 100644
total: 0 errors, 1 warnings, 877 lines checked
Patch 1/25 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/25 Checking commit 0b955f8caf6d (hw/ppc/prep: Drop useless inclusion of "hw/input/i8042.h")
3/25 Checking commit d60f69cf648e (target/ppc: Style fixes for ppc-models.[ch])
4/25 Checking commit 6a09c460c6d7 (target/ppc: Style fixes for cpu.[ch])
5/25 Checking commit c4b4fbf52642 (target/ppc: Style fixes for int_helper.c)
6/25 Checking commit 07ce42ad0f3b (target/ppc: Style fixes for fpu_helper.c)
WARNING: Block comments use a leading /* on a separate line
#129: FILE: target/ppc/fpu_helper.c:2229:
+ /* \
WARNING: Block comments use a leading /* on a separate line
#158: FILE: target/ppc/fpu_helper.c:2286:
+ /* \
WARNING: Block comments use a leading /* on a separate line
#181: FILE: target/ppc/fpu_helper.c:2340:
+ /* \
WARNING: Block comments use a leading /* on a separate line
#351: FILE: target/ppc/fpu_helper.c:3182:
+ /* \
total: 0 errors, 4 warnings, 328 lines checked
Patch 6/25 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/25 Checking commit 7061f73523cd (target/ppc: Style fixes for dfp_helper.c)
ERROR: spaces required around that '+' (ctx:VxV)
#35: FILE: target/ppc/dfp_helper.c:1119:
+ decNumberSetBCD(&dfp.t, digits+((size) / 4) - n, n); \
^
total: 1 errors, 0 warnings, 39 lines checked
Patch 7/25 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/25 Checking commit 2731feaffd29 (target/ppc: Style fixes for excp_helper.c)
9/25 Checking commit a1eb273604e4 (target/ppc: Style fixes for gdbstub.c)
10/25 Checking commit 62ba6a34409b (target/ppc: Style fixes for helper_regs.h)
11/25 Checking commit cc497c316b30 (target/ppc: Style fixes for kvm_ppc.h and kvm.c)
WARNING: line over 80 characters
#440: FILE: target/ppc/kvm.c:2719:
+ ((qemu_clock_get_ns(QEMU_CLOCK_REALTIME) - starttime) < max_ns)));
total: 0 errors, 1 warnings, 423 lines checked
Patch 11/25 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/25 Checking commit 197f1940bef9 (target/ppc: Style fixes for machine.c)
13/25 Checking commit 6b40470682e6 (target/ppc: Style fixes for mem_helper.c)
14/25 Checking commit cf4f0dde0d44 (target/ppc: Style fixes for mfrom_table.inc.c & mfrom_table_gen.c)
15/25 Checking commit 465ef88fa68e (target/ppc: Style fixes for misc_helper.c)
16/25 Checking commit d52341d79675 (target/ppc: Style fixes for mmu-hash32.[ch])
17/25 Checking commit a2f32fdcab89 (target/ppc: Style fixes for mmu-hash64.[ch])
18/25 Checking commit 364bed3f12a8 (target/ppc: Style fixes for mmu_helper.c)
19/25 Checking commit 4aeb580b7111 (target/ppc: Style fixes for monitor.c)
20/25 Checking commit 461682526fa3 (target/ppc: Style fixes for translate_init.inc.c)
21/25 Checking commit 101d9580ee2c (target/ppc: Style fixes for translate.c)
WARNING: Block comments use a leading /* on a separate line
#34: FILE: target/ppc/translate.c:59:
+ + 8 * 5 /* CRF */];
WARNING: Block comments use a leading /* on a separate line
#1244: FILE: target/ppc/translate.c:6701:
+ /* \
WARNING: Block comments use a leading /* on a separate line
#1266: FILE: target/ppc/translate.c:6727:
+ /* \
WARNING: Block comments use a leading /* on a separate line
#1298: FILE: target/ppc/translate.c:6770:
+ /* \
total: 0 errors, 4 warnings, 1332 lines checked
Patch 21/25 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/25 Checking commit 3caa9d49ebcd (target/ppc: Style fixes for translate/fp-impl.inc.c)
23/25 Checking commit 8d94edbb0049 (target/ppc: Style fixes for translate/vsx-impl.inc.c)
WARNING: Block comments use a leading /* on a separate line
#73: FILE: target/ppc/translate/vsx-impl.inc.c:1447:
+ /* \
total: 0 errors, 1 warnings, 57 lines checked
Patch 23/25 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
24/25 Checking commit 65eb1385127c (target/ppc: Style fixes for translate/vmx-impl.inc.c)
WARNING: Block comments use a leading /* on a separate line
#29: FILE: target/ppc/translate/vmx-impl.inc.c:31:
+ /* \
WARNING: Block comments use a leading /* on a separate line
#42: FILE: target/ppc/translate/vmx-impl.inc.c:66:
+ /* \
total: 0 errors, 2 warnings, 75 lines checked
Patch 24/25 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/25 Checking commit d9a6215eccb6 (target/ppc: Style fixes for translate/spe-impl.inc.c)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190322001544.9794-1-david@gibson.dropbear.id.au/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
© 2016 - 2024 Red Hat, Inc.