docker: trivial changes to `make docker` help

[Qemu-devel] [PATCH] docker: trivial changes to `make docker` help

Wainer dos Santos Moschetta posted 1 patch 5 years, 1 month ago

Download mbox

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test asan passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190321212528.6100-1-wainersm@redhat.com

Maintainers: "Philippe Mathieu-Daudé" <philmd@redhat.com>, Fam Zheng <fam@euphon.net>, "Alex Bennée" <alex.bennee@linaro.org>, Laurent Vivier <laurent@vivier.eu>, Michael Tokarev <mjt@tls.msk.ru>

tests/docker/Makefile.include | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] docker: trivial changes to `make docker` help

Posted by Wainer dos Santos Moschetta 5 years, 1 month ago

Apply double quotes and period punctuation uniformly.

Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
---
 tests/docker/Makefile.include | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index 60314d293a..c0e1bf57a3 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -151,15 +151,15 @@ docker:
 	@echo
 	@echo '    docker:              Print this help.'
 	@echo '    docker-all-tests:    Run all image/test combinations.'
-	@echo '    docker-TEST:         Run TEST on all image combinations.'
+	@echo '    docker-TEST:         Run "TEST" on all image combinations.'
 	@echo '    docker-clean:        Kill and remove residual docker testing containers.'
 	@echo '    docker-TEST@IMAGE:   Run "TEST" in container "IMAGE".'
 	@echo '                         Note: "TEST" is one of the listed test name,'
 	@echo '                         or a script name under $$QEMU_SRC/tests/docker/;'
-	@echo '                         "IMAGE" is one of the listed container name."'
+	@echo '                         "IMAGE" is one of the listed container name.'
 	@echo '    docker-image:        Build all images.'
 	@echo '    docker-image-IMAGE:  Build image "IMAGE".'
-	@echo '    docker-run:          For manually running a "TEST" with "IMAGE"'
+	@echo '    docker-run:          For manually running a "TEST" with "IMAGE".'
 	@echo
 	@echo 'Available container images:'
 	@echo '    $(DOCKER_IMAGES)'
-- 
2.20.1

Re: [Qemu-devel] [PATCH] docker: trivial changes to `make docker` help

Posted by Fam Zheng 5 years, 1 month ago


> On Mar 22, 2019, at 05:25, Wainer dos Santos Moschetta <wainersm@redhat.com> wrote:
> 
> Apply double quotes and period punctuation uniformly.
> 
> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> ---
> tests/docker/Makefile.include | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index 60314d293a..c0e1bf57a3 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -151,15 +151,15 @@ docker:
> 	@echo
> 	@echo '    docker:              Print this help.'
> 	@echo '    docker-all-tests:    Run all image/test combinations.'
> -	@echo '    docker-TEST:         Run TEST on all image combinations.'
> +	@echo '    docker-TEST:         Run "TEST" on all image combinations.'
> 	@echo '    docker-clean:        Kill and remove residual docker testing containers.'
> 	@echo '    docker-TEST@IMAGE:   Run "TEST" in container "IMAGE".'
> 	@echo '                         Note: "TEST" is one of the listed test name,'
> 	@echo '                         or a script name under $$QEMU_SRC/tests/docker/;'
> -	@echo '                         "IMAGE" is one of the listed container name."'
> +	@echo '                         "IMAGE" is one of the listed container name.'
> 	@echo '    docker-image:        Build all images.'
> 	@echo '    docker-image-IMAGE:  Build image "IMAGE".'
> -	@echo '    docker-run:          For manually running a "TEST" with "IMAGE"'
> +	@echo '    docker-run:          For manually running a "TEST" with "IMAGE".'
> 	@echo
> 	@echo 'Available container images:'
> 	@echo '    $(DOCKER_IMAGES)'
> -- 
> 2.20.1
> 
> 

Reviewed-by: Fam Zheng <fam@euphon.net>

Re: [Qemu-devel] [PATCH] docker: trivial changes to `make docker` help

Posted by Alex Bennée 5 years, 1 month ago

Wainer dos Santos Moschetta <wainersm@redhat.com> writes:

> Apply double quotes and period punctuation uniformly.
>
> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>

Queued to for-4.0/testing-and-fpu-fixes, thanks.

--
Alex Bennée