[Qemu-devel] [PATCH] hw/i386/Kconfig: PC uses I8257, not I82374

Paolo Bonzini posted 1 patch 5 years, 1 month ago
Failed in applying to current master (apply log)
hw/i386/Kconfig | 1 -
1 file changed, 1 deletion(-)
[Qemu-devel] [PATCH] hw/i386/Kconfig: PC uses I8257, not I82374
Posted by Paolo Bonzini 5 years, 1 month ago
CONFIG_I82374 is not needed for PC machines, since they create
i8257 directly instead.

Reported-by: Miroslav Rezanina <mrezanin@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/i386/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
index 4e4415fc88..756b1eaef8 100644
--- a/hw/i386/Kconfig
+++ b/hw/i386/Kconfig
@@ -23,7 +23,6 @@ config PC
     select I8254
     select PCKBD
     select PCSPK
-    select I82374
     select I8257
     select MC146818RTC
     # For ACPI builder:
-- 
2.20.1


Re: [Qemu-devel] [PATCH] hw/i386/Kconfig: PC uses I8257, not I82374
Posted by Stefano Garzarella 5 years, 1 month ago
On Wed, Mar 20, 2019 at 10:32:37AM +0100, Paolo Bonzini wrote:
> CONFIG_I82374 is not needed for PC machines, since they create
> i8257 directly instead.
> 
> Reported-by: Miroslav Rezanina <mrezanin@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/i386/Kconfig | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>