[Qemu-devel] [PATCH preliminary for 4.1 00/13] Convert I2C tests to qgraph

Paolo Bonzini posted 13 patches 5 years, 1 month ago
Test docker-clang@ubuntu failed
Test asan failed
Test checkpatch passed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190318171521.8524-1-pbonzini@redhat.com
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Thomas Huth <thuth@redhat.com>, Jean-Christophe Dubois <jcd@tribudubois.net>, Laurent Vivier <lvivier@redhat.com>
hw/arm/imx25_pdk.c                   |   9 ---
tests/Makefile.include               |  17 ++--
tests/ds1338-test.c                  |  45 ++++-------
tests/libqos/arm-imx25-pdk-machine.c |  92 ++++++++++++++++++++++
tests/libqos/arm-n800-machine.c      |  92 ++++++++++++++++++++++
tests/libqos/i2c-imx.c               |  40 ++++++----
tests/libqos/i2c-omap.c              |  70 +++++++++++------
tests/libqos/i2c.c                   |  74 ++++++++++++++++--
tests/libqos/i2c.h                   |  63 ++++++++++++---
tests/libqos/qgraph.c                |  12 ++-
tests/libqos/qgraph.h                |  15 ++--
tests/pca9552-test.c                 |  91 ++++++++--------------
tests/qos-test.c                     |  17 ++--
tests/tmp105-test.c                  | 112 ++++++++-------------------
14 files changed, 494 insertions(+), 255 deletions(-)
create mode 100644 tests/libqos/arm-imx25-pdk-machine.c
create mode 100644 tests/libqos/arm-n800-machine.c
[Qemu-devel] [PATCH preliminary for 4.1 00/13] Convert I2C tests to qgraph
Posted by Paolo Bonzini 5 years, 1 month ago
This series is meant to be a reference for converting tests to qgraph.
It covers a bit of everything: finding common code across multiple tests,
the kind of bug that you could find when running tests across more machine
types, creating new machines, and converting tests.

I have not yet tested it fully, and the first two patches are really
independent bugfixes and improvements to the qgraph API so they do not
really belong in this series.  However, I wanted to throw it out sooner
because I won't have much time to work on it during the freeze.

Paolo Bonzini (13):
  qgraph: allow extra_device_opts on bus nodes
  qgraph: fix qos_node_contains with options
  libqos: move common i2c code to libqos
  libqos: fix omap-i2c receiving more than 4 bytes
  pca9552-test: do not rely on state across tests
  imx25-pdk: create ds1338 for qtest inside the test
  libqos: split I2CAdapter initialization and allocation
  libqos: convert I2C to qgraph
  libqos: add ARM n800 machine object
  libqos: add ARM imx25-pdk machine object
  tests: convert OMAP i2c tests to qgraph
  tests: convert ds1338-test to qtest
  libqos: i2c: move address into QI2CDevice

 hw/arm/imx25_pdk.c                   |   9 ---
 tests/Makefile.include               |  17 ++--
 tests/ds1338-test.c                  |  45 ++++-------
 tests/libqos/arm-imx25-pdk-machine.c |  92 ++++++++++++++++++++++
 tests/libqos/arm-n800-machine.c      |  92 ++++++++++++++++++++++
 tests/libqos/i2c-imx.c               |  40 ++++++----
 tests/libqos/i2c-omap.c              |  70 +++++++++++------
 tests/libqos/i2c.c                   |  74 ++++++++++++++++--
 tests/libqos/i2c.h                   |  63 ++++++++++++---
 tests/libqos/qgraph.c                |  12 ++-
 tests/libqos/qgraph.h                |  15 ++--
 tests/pca9552-test.c                 |  91 ++++++++--------------
 tests/qos-test.c                     |  17 ++--
 tests/tmp105-test.c                  | 112 ++++++++-------------------
 14 files changed, 494 insertions(+), 255 deletions(-)
 create mode 100644 tests/libqos/arm-imx25-pdk-machine.c
 create mode 100644 tests/libqos/arm-n800-machine.c

-- 
2.20.1


Re: [Qemu-devel] [PATCH preliminary for 4.1 00/13] Convert I2C tests to qgraph
Posted by no-reply@patchew.org 5 years, 1 month ago
Patchew URL: https://patchew.org/QEMU/20190318171521.8524-1-pbonzini@redhat.com/



Hi,

This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===

clang -iquote /tmp/qemu-test/build/. -iquote . -iquote /tmp/qemu-test/src/tcg -iquote /tmp/qemu-test/src/tcg/i386 -I/tmp/qemu-test/src/linux-headers -I/tmp/qemu-test/build/linux-headers -iquote . -iquote /tmp/qemu-test/src -iquote /tmp/qemu-test/src/accel/tcg -iquote /tmp/qemu-test/src/include -I/tmp/qemu-test/src/tests/fp -I/tmp/qemu-test/src/tests/fp/berkeley-softfloat-3/source/include -I/tmp/qemu-test/src/tests/fp/berkeley-softfloat-3/source/8086-SSE -I/tmp/qemu-test/src/tests/fp/berkeley-testfloat-3/source -I/usr/include/pixman-1 -I/tmp/qemu-test/src/dtc/libfdt -Werror -DHAS_LIBSSH2_SFTP_FSYNC -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -fPIE -DPIE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -Wno-string-plus-int -Wno-initializer-overrides -Wexpansion-to-defined -Wendif-labels -Wno-shift-negative-value -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-definition -Wtype-limits -fstack-protector-strong -I/usr/include/p11-kit-1 -I/usr/include/libpng16 -I/usr/include/spice-1 -I/usr/include/spice-server -I/usr/include/cacard -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/nss3 -I/usr/include/nspr4 -pthread -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/uuid -I/usr/include/pixman-1 -DHW_POISON_H -DTARGET_ARM  -DSOFTFLOAT_ROUND_ODD -DINLINE_LEVEL=5 -DSOFTFLOAT_FAST_DIV32TO16 -DSOFTFLOAT_FAST_DIV64TO32 -DSOFTFLOAT_FAST_INT64  -DFLOAT16 -DFLOAT64 -DEXTFLOAT80 -DFLOAT128 -DFLOAT_ROUND_ODD -DLONG_DOUBLE_IS_EXTFLOAT80  -Wno-strict-prototypes -Wno-unknown-pragmas -Wno-uninitialized -Wno-missing-prototypes -Wno-return-type -Wno-unused-function -Wno-error -MMD -MP -MT writeCase_ab_extF80M.o -MF ./writeCase_ab_extF80M.d -fsanitize=undefined -fsanitize=address -g   -c -o writeCase_ab_extF80M.o /tmp/qemu-test/src/tests/fp/berkeley-testfloat-3/source/writeCase_ab_extF80M.c
clang -iquote /tmp/qemu-test/build/tests -iquote tests -iquote /tmp/qemu-test/src/tcg -iquote /tmp/qemu-test/src/tcg/i386 -I/tmp/qemu-test/src/linux-headers -I/tmp/qemu-test/build/linux-headers -iquote . -iquote /tmp/qemu-test/src -iquote /tmp/qemu-test/src/accel/tcg -iquote /tmp/qemu-test/src/include -I/usr/include/pixman-1  -I/tmp/qemu-test/src/dtc/libfdt -Werror -DHAS_LIBSSH2_SFTP_FSYNC  -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include  -fPIE -DPIE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99  -Wno-string-plus-int -Wno-initializer-overrides -Wexpansion-to-defined -Wendif-labels -Wno-shift-negative-value -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-definition -Wtype-limits -fstack-protector-strong  -I/usr/include/p11-kit-1    -I/usr/include/libpng16  -I/usr/include/spice-1 -I/usr/include/spice-server -I/usr/include/cacard -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/nss3 -I/usr/include/nspr4 -pthread -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/uuid -I/usr/include/pixman-1  -I/tmp/qemu-test/src/tests -MMD -MP -MT tests/tco-test.o -MF tests/tco-test.d -fsanitize=undefined -fsanitize=address -g   -c -o tests/tco-test.o /tmp/qemu-test/src/tests/tco-test.c
clang -iquote /tmp/qemu-test/build/tests -iquote tests -iquote /tmp/qemu-test/src/tcg -iquote /tmp/qemu-test/src/tcg/i386 -I/tmp/qemu-test/src/linux-headers -I/tmp/qemu-test/build/linux-headers -iquote . -iquote /tmp/qemu-test/src -iquote /tmp/qemu-test/src/accel/tcg -iquote /tmp/qemu-test/src/include -I/usr/include/pixman-1  -I/tmp/qemu-test/src/dtc/libfdt -Werror -DHAS_LIBSSH2_SFTP_FSYNC  -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include  -fPIE -DPIE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99  -Wno-string-plus-int -Wno-initializer-overrides -Wexpansion-to-defined -Wendif-labels -Wno-shift-negative-value -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-definition -Wtype-limits -fstack-protector-strong  -I/usr/include/p11-kit-1    -I/usr/include/libpng16  -I/usr/include/spice-1 -I/usr/include/spice-server -I/usr/include/cacard -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/nss3 -I/usr/include/nspr4 -pthread -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/uuid -I/usr/include/pixman-1  -I/tmp/qemu-test/src/tests -MMD -MP -MT tests/rtl8139-test.o -MF tests/rtl8139-test.d -fsanitize=undefined -fsanitize=address -g   -c -o tests/rtl8139-test.o /tmp/qemu-test/src/tests/rtl8139-test.c
/tmp/qemu-test/src/tests/libqos/qgraph.c:642:18: error: second argument to 'va_start' is not the last named parameter [-Werror,-Wvarargs]
    va_start(va, contained);
                 ^
1 error generated.


The full log is available at
http://patchew.org/logs/20190318171521.8524-1-pbonzini@redhat.com/testing.asan/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com