hw/ppc/prep: Drop useless inclusion of "hw/input/i8042.h"

[Qemu-devel] [PATCH] hw/ppc/prep: Drop useless inclusion of "hw/input/i8042.h"

Philippe Mathieu-Daudé posted 1 patch 5 years, 1 month ago

Download mbox

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test checkpatch passed

Test asan passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190316201528.9140-1-philmd@redhat.com

Maintainers: "Hervé Poussineau" <hpoussin@reactos.org>, David Gibson <david@gibson.dropbear.id.au>

hw/ppc/prep.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] hw/ppc/prep: Drop useless inclusion of "hw/input/i8042.h"

Posted by Philippe Mathieu-Daudé 5 years, 1 month ago

In commit 47973a2dbf we split the last generic chipset out of
the PC board, but missed to remove the i8042 keyboard controller.
This omission was later fixed in commit 7cb00357c1, but here we
forgot to remove the "i8042.h" include. Do it now.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/ppc/prep.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
index 847d320465..b7f459d475 100644
--- a/hw/ppc/prep.c
+++ b/hw/ppc/prep.c
@@ -40,7 +40,6 @@
 #include "hw/ide.h"
 #include "hw/loader.h"
 #include "hw/timer/mc146818rtc.h"
-#include "hw/input/i8042.h"
 #include "hw/isa/pc87312.h"
 #include "hw/net/ne2000-isa.h"
 #include "sysemu/arch_init.h"
-- 
2.20.1

Re: [Qemu-devel] [PATCH] hw/ppc/prep: Drop useless inclusion of "hw/input/i8042.h"

Posted by David Gibson 5 years, 1 month ago

On Sat, Mar 16, 2019 at 09:15:28PM +0100, Philippe Mathieu-Daudé wrote:
> In commit 47973a2dbf we split the last generic chipset out of
> the PC board, but missed to remove the i8042 keyboard controller.
> This omission was later fixed in commit 7cb00357c1, but here we
> forgot to remove the "i8042.h" include. Do it now.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Applied to ppc-for-4.1.

> ---
>  hw/ppc/prep.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
> index 847d320465..b7f459d475 100644
> --- a/hw/ppc/prep.c
> +++ b/hw/ppc/prep.c
> @@ -40,7 +40,6 @@
>  #include "hw/ide.h"
>  #include "hw/loader.h"
>  #include "hw/timer/mc146818rtc.h"
> -#include "hw/input/i8042.h"
>  #include "hw/isa/pc87312.h"
>  #include "hw/net/ne2000-isa.h"
>  #include "sysemu/arch_init.h"

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson