[Qemu-devel] [PATCH 0/2] kconfig: add fine-grained dependencies for MSI

Paolo Bonzini posted 2 patches 4 days ago
Test asan passed
Test docker-clang@ubuntu passed
Test docker-mingw@fedora passed
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190314143032.16870-1-pbonzini@redhat.com
Kconfig.host          | 3 +++
Makefile              | 3 ++-
hw/Kconfig            | 1 +
hw/intc/Kconfig       | 3 +++
hw/misc/Kconfig       | 4 ++--
hw/net/Kconfig        | 4 ++--
hw/pci-bridge/Kconfig | 6 +++---
hw/pci-host/Kconfig   | 1 +
hw/pci/Kconfig        | 4 ++++
hw/ppc/Kconfig        | 1 +
hw/rdma/Kconfig       | 3 +++
hw/rdma/Makefile.objs | 6 ++----
hw/s390x/Kconfig      | 1 +
13 files changed, 28 insertions(+), 12 deletions(-)
create mode 100644 hw/rdma/Kconfig

[Qemu-devel] [PATCH 0/2] kconfig: add fine-grained dependencies for MSI

Posted by Paolo Bonzini 4 days ago
RISC-V targets did not include PCIe ports before the Kconfig transition,
and grew them afterwards, but they are nonfunctional because the interrupt
controller does not support MSI.  This patch restores the situation prior to
the introduction of Kconfig; in fact, it will automatically drop devices
that require MSI unless the binary includes an MSI-enabled board.

Paolo

Paolo Bonzini (2):
  kconfig: add CONFIG_MSI
  kconfig: add dependencies on CONFIG_MSI

 Kconfig.host          | 3 +++
 Makefile              | 3 ++-
 hw/Kconfig            | 1 +
 hw/intc/Kconfig       | 3 +++
 hw/misc/Kconfig       | 4 ++--
 hw/net/Kconfig        | 4 ++--
 hw/pci-bridge/Kconfig | 6 +++---
 hw/pci-host/Kconfig   | 1 +
 hw/pci/Kconfig        | 4 ++++
 hw/ppc/Kconfig        | 1 +
 hw/rdma/Kconfig       | 3 +++
 hw/rdma/Makefile.objs | 6 ++----
 hw/s390x/Kconfig      | 1 +
 13 files changed, 28 insertions(+), 12 deletions(-)
 create mode 100644 hw/rdma/Kconfig

-- 
2.20.1


Re: [Qemu-devel] [PATCH 0/2] kconfig: add fine-grained dependencies for MSI

Posted by Andrea Bolognani 3 days ago
On Thu, 2019-03-14 at 15:30 +0100, Paolo Bonzini wrote:
> RISC-V targets did not include PCIe ports before the Kconfig transition,
> and grew them afterwards, but they are nonfunctional because the interrupt
> controller does not support MSI.  This patch restores the situation prior to
> the introduction of Kconfig; in fact, it will automatically drop devices
> that require MSI unless the binary includes an MSI-enabled board.
> 
> Paolo
> 
> Paolo Bonzini (2):
>   kconfig: add CONFIG_MSI
>   kconfig: add dependencies on CONFIG_MSI
> 
>  Kconfig.host          | 3 +++
>  Makefile              | 3 ++-
>  hw/Kconfig            | 1 +
>  hw/intc/Kconfig       | 3 +++
>  hw/misc/Kconfig       | 4 ++--
>  hw/net/Kconfig        | 4 ++--
>  hw/pci-bridge/Kconfig | 6 +++---
>  hw/pci-host/Kconfig   | 1 +
>  hw/pci/Kconfig        | 4 ++++
>  hw/ppc/Kconfig        | 1 +
>  hw/rdma/Kconfig       | 3 +++
>  hw/rdma/Makefile.objs | 6 ++----
>  hw/s390x/Kconfig      | 1 +
>  13 files changed, 28 insertions(+), 12 deletions(-)
>  create mode 100644 hw/rdma/Kconfig

FWIW

  Tested-by: Andrea Bolognani <abologna@redhat.com>

Thanks for addressing this :)

-- 
Andrea Bolognani / Red Hat / Virtualization


Re: [Qemu-devel] [PATCH 0/2] kconfig: add fine-grained dependencies for MSI

Posted by Michael S. Tsirkin 4 days ago
On Thu, Mar 14, 2019 at 03:30:30PM +0100, Paolo Bonzini wrote:
> RISC-V targets did not include PCIe ports before the Kconfig transition,
> and grew them afterwards, but they are nonfunctional because the interrupt
> controller does not support MSI.  This patch restores the situation prior to
> the introduction of Kconfig; in fact, it will automatically drop devices
> that require MSI unless the binary includes an MSI-enabled board.
> 
> Paolo

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

> Paolo Bonzini (2):
>   kconfig: add CONFIG_MSI
>   kconfig: add dependencies on CONFIG_MSI
> 
>  Kconfig.host          | 3 +++
>  Makefile              | 3 ++-
>  hw/Kconfig            | 1 +
>  hw/intc/Kconfig       | 3 +++
>  hw/misc/Kconfig       | 4 ++--
>  hw/net/Kconfig        | 4 ++--
>  hw/pci-bridge/Kconfig | 6 +++---
>  hw/pci-host/Kconfig   | 1 +
>  hw/pci/Kconfig        | 4 ++++
>  hw/ppc/Kconfig        | 1 +
>  hw/rdma/Kconfig       | 3 +++
>  hw/rdma/Makefile.objs | 6 ++----
>  hw/s390x/Kconfig      | 1 +
>  13 files changed, 28 insertions(+), 12 deletions(-)
>  create mode 100644 hw/rdma/Kconfig
> 
> -- 
> 2.20.1

Re: [Qemu-devel] [PATCH 0/2] kconfig: add fine-grained dependencies for MSI

Posted by Alistair Francis 4 days ago
On Thu, Mar 14, 2019 at 10:09 AM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Thu, Mar 14, 2019 at 03:30:30PM +0100, Paolo Bonzini wrote:
> > RISC-V targets did not include PCIe ports before the Kconfig transition,
> > and grew them afterwards, but they are nonfunctional because the interrupt
> > controller does not support MSI.  This patch restores the situation prior to
> > the introduction of Kconfig; in fact, it will automatically drop devices
> > that require MSI unless the binary includes an MSI-enabled board.
> >
> > Paolo
>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

Thanks for the patch Paolo.

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

>
> > Paolo Bonzini (2):
> >   kconfig: add CONFIG_MSI
> >   kconfig: add dependencies on CONFIG_MSI
> >
> >  Kconfig.host          | 3 +++
> >  Makefile              | 3 ++-
> >  hw/Kconfig            | 1 +
> >  hw/intc/Kconfig       | 3 +++
> >  hw/misc/Kconfig       | 4 ++--
> >  hw/net/Kconfig        | 4 ++--
> >  hw/pci-bridge/Kconfig | 6 +++---
> >  hw/pci-host/Kconfig   | 1 +
> >  hw/pci/Kconfig        | 4 ++++
> >  hw/ppc/Kconfig        | 1 +
> >  hw/rdma/Kconfig       | 3 +++
> >  hw/rdma/Makefile.objs | 6 ++----
> >  hw/s390x/Kconfig      | 1 +
> >  13 files changed, 28 insertions(+), 12 deletions(-)
> >  create mode 100644 hw/rdma/Kconfig
> >
> > --
> > 2.20.1
>

Re: [Qemu-devel] [PATCH 0/2] kconfig: add fine-grained dependencies for MSI

Posted by Palmer Dabbelt 4 days ago
On Thu, 14 Mar 2019 10:30:20 PDT (-0700), alistair23@gmail.com wrote:
> On Thu, Mar 14, 2019 at 10:09 AM Michael S. Tsirkin <mst@redhat.com> wrote:
>>
>> On Thu, Mar 14, 2019 at 03:30:30PM +0100, Paolo Bonzini wrote:
>> > RISC-V targets did not include PCIe ports before the Kconfig transition,
>> > and grew them afterwards, but they are nonfunctional because the interrupt
>> > controller does not support MSI.  This patch restores the situation prior to
>> > the introduction of Kconfig; in fact, it will automatically drop devices
>> > that require MSI unless the binary includes an MSI-enabled board.
>> >
>> > Paolo
>>
>> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>
> Thanks for the patch Paolo.
>
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Paolo: I assume this is going in through your tree?  I'm dropping it from my 
inbox.

Thanks for fixing this!

>
> Alistair
>
>>
>> > Paolo Bonzini (2):
>> >   kconfig: add CONFIG_MSI
>> >   kconfig: add dependencies on CONFIG_MSI
>> >
>> >  Kconfig.host          | 3 +++
>> >  Makefile              | 3 ++-
>> >  hw/Kconfig            | 1 +
>> >  hw/intc/Kconfig       | 3 +++
>> >  hw/misc/Kconfig       | 4 ++--
>> >  hw/net/Kconfig        | 4 ++--
>> >  hw/pci-bridge/Kconfig | 6 +++---
>> >  hw/pci-host/Kconfig   | 1 +
>> >  hw/pci/Kconfig        | 4 ++++
>> >  hw/ppc/Kconfig        | 1 +
>> >  hw/rdma/Kconfig       | 3 +++
>> >  hw/rdma/Makefile.objs | 6 ++----
>> >  hw/s390x/Kconfig      | 1 +
>> >  13 files changed, 28 insertions(+), 12 deletions(-)
>> >  create mode 100644 hw/rdma/Kconfig
>> >
>> > --
>> > 2.20.1
>>