[Qemu-devel] [PATCH] slirp: remove empty state.h

Marc-André Lureau posted 1 patch 5 years, 1 month ago
Test asan failed
Test docker-clang@ubuntu passed
Test docker-mingw@fedora passed
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190313173949.2369-1-marcandre.lureau@redhat.com
Maintainers: Samuel Thibault <samuel.thibault@ens-lyon.org>, Jan Kiszka <jan.kiszka@siemens.com>
slirp/src/state.h | 0
slirp/src/state.c | 1 -
2 files changed, 1 deletion(-)
delete mode 100644 slirp/src/state.h
[Qemu-devel] [PATCH] slirp: remove empty state.h
Posted by Marc-André Lureau 5 years, 1 month ago
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 slirp/src/state.h | 0
 slirp/src/state.c | 1 -
 2 files changed, 1 deletion(-)
 delete mode 100644 slirp/src/state.h

diff --git a/slirp/src/state.h b/slirp/src/state.h
deleted file mode 100644
index e69de29bb2..0000000000
diff --git a/slirp/src/state.c b/slirp/src/state.c
index f5dd80cdc8..c3e3f0b671 100644
--- a/slirp/src/state.c
+++ b/slirp/src/state.c
@@ -23,7 +23,6 @@
  */
 #include "slirp.h"
 #include "vmstate.h"
-#include "state.h"
 #include "stream.h"
 
 static int slirp_tcp_post_load(void *opaque, int version)
-- 
2.21.0.4.g36eb1cb9cf


Re: [Qemu-devel] [PATCH] slirp: remove empty state.h
Posted by Eric Blake 5 years, 1 month ago
On 3/13/19 12:39 PM, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  slirp/src/state.h | 0
>  slirp/src/state.c | 1 -
>  2 files changed, 1 deletion(-)
>  delete mode 100644 slirp/src/state.h

Made empty in commit d890344, before moving to its current location in
c2d63650.

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/slirp/src/state.h b/slirp/src/state.h
> deleted file mode 100644
> index e69de29bb2..0000000000
> diff --git a/slirp/src/state.c b/slirp/src/state.c
> index f5dd80cdc8..c3e3f0b671 100644
> --- a/slirp/src/state.c
> +++ b/slirp/src/state.c
> @@ -23,7 +23,6 @@
>   */
>  #include "slirp.h"
>  #include "vmstate.h"
> -#include "state.h"
>  #include "stream.h"
>  
>  static int slirp_tcp_post_load(void *opaque, int version)
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH] slirp: remove empty state.h
Posted by Samuel Thibault 5 years, 1 month ago
Eric Blake, le mer. 13 mars 2019 13:21:23 -0500, a ecrit:
> On 3/13/19 12:39 PM, Marc-André Lureau wrote:
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> >  slirp/src/state.h | 0
> >  slirp/src/state.c | 1 -
> >  2 files changed, 1 deletion(-)
> >  delete mode 100644 slirp/src/state.h
> 
> Made empty in commit d890344, before moving to its current location in
> c2d63650.
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>

Applied and sent pull request, thanks!