maint: Ignore built elf2dmp

[Qemu-devel] [PATCH for-4.0] maint: Ignore built elf2dmp

Posted by Eric Blake 6 years, 6 months ago

Commit 3fa2d384 added a binary 'elf2dmp' but did not ignore it
during an in-tree build.

Signed-off-by: Eric Blake <eblake@redhat.com>
---

Yes, I know we want to get rid of in-tree builds for 4.1; but
for 4.0, this patch may still make sense.

 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 77522561b8e..42d2d473559 100644
--- a/.gitignore
+++ b/.gitignore
@@ -6,6 +6,7 @@
 /config-target.*
 /config.status
 /config-temp
+/elf2dmp
 /trace-events-all
 /trace/generated-events.h
 /trace/generated-events.c
-- 
2.20.1

Re: [Qemu-devel] [PATCH for-4.0] maint: Ignore built elf2dmp

Posted by Stefano Garzarella 6 years, 6 months ago

On Wed, Mar 13, 2019 at 09:45:57AM -0500, Eric Blake wrote:
> Commit 3fa2d384 added a binary 'elf2dmp' but did not ignore it
> during an in-tree build.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> 
> Yes, I know we want to get rid of in-tree builds for 4.1; but
> for 4.0, this patch may still make sense.
> 
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-4.0] maint: Ignore built elf2dmp

Posted by Laurent Vivier 6 years, 6 months ago

On 13/03/2019 15:45, Eric Blake wrote:
> Commit 3fa2d384 added a binary 'elf2dmp' but did not ignore it
> during an in-tree build.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> 
> Yes, I know we want to get rid of in-tree builds for 4.1; but
> for 4.0, this patch may still make sense.
> 
>   .gitignore | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> index 77522561b8e..42d2d473559 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -6,6 +6,7 @@
>   /config-target.*
>   /config.status
>   /config-temp
> +/elf2dmp
>   /trace-events-all
>   /trace/generated-events.h
>   /trace/generated-events.c
> 


Applied to my trivial-patches branch.

Thanks,
Laurent

Re: [Qemu-devel] [PATCH for-4.0] maint: Ignore built elf2dmp

Posted by Philippe Mathieu-Daudé 6 years, 6 months ago

On 3/13/19 3:45 PM, Eric Blake wrote:
> Commit 3fa2d384 added a binary 'elf2dmp' but did not ignore it
> during an in-tree build.

I'd use ".gitignore" or "elf2dmp" prefix in subject rather than "maint".

> 
> Signed-off-by: Eric Blake <eblake@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
> 
> Yes, I know we want to get rid of in-tree builds for 4.1; but
> for 4.0, this patch may still make sense.
> 
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> index 77522561b8e..42d2d473559 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -6,6 +6,7 @@
>  /config-target.*
>  /config.status
>  /config-temp
> +/elf2dmp
>  /trace-events-all
>  /trace/generated-events.h
>  /trace/generated-events.c
>