config-all-devices.mak: rebuild on reconfigure

[Qemu-devel] [PATCH] config-all-devices.mak: rebuild on reconfigure

Posted by Paolo Bonzini 6 years, 8 months ago

This ensures that softmmu directories are culled after a
"./configure --target-list=x86_64-linux-user".

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 6ccb8639b0..24af22bf08 100644
--- a/Makefile
+++ b/Makefile
@@ -331,10 +331,10 @@ SUBDIR_DEVICES_MAK=$(patsubst %, %/config-devices.mak, $(filter %-softmmu, $(TAR
 SUBDIR_DEVICES_MAK_DEP=$(patsubst %, %.d, $(SUBDIR_DEVICES_MAK))
 
 ifeq ($(SUBDIR_DEVICES_MAK),)
-config-all-devices.mak:
+config-all-devices.mak: config-host.mak
 	$(call quiet-command,echo '# no devices' > $@,"GEN","$@")
 else
-config-all-devices.mak: $(SUBDIR_DEVICES_MAK)
+config-all-devices.mak: $(SUBDIR_DEVICES_MAK) config-host.mak
 	$(call quiet-command, sed -n \
              's|^\([^=]*\)=\(.*\)$$|\1:=$$(findstring y,$$(\1)\2)|p' \
              $(SUBDIR_DEVICES_MAK) | sort -u > $@, \
-- 
2.20.1

Re: [Qemu-devel] [PATCH] config-all-devices.mak: rebuild on reconfigure

Posted by Eric Blake 6 years, 8 months ago

On 3/13/19 7:42 AM, Paolo Bonzini wrote:
> This ensures that softmmu directories are culled after a
> "./configure --target-list=x86_64-linux-user".
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/Makefile b/Makefile
> index 6ccb8639b0..24af22bf08 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -331,10 +331,10 @@ SUBDIR_DEVICES_MAK=$(patsubst %, %/config-devices.mak, $(filter %-softmmu, $(TAR
>  SUBDIR_DEVICES_MAK_DEP=$(patsubst %, %.d, $(SUBDIR_DEVICES_MAK))
>  
>  ifeq ($(SUBDIR_DEVICES_MAK),)
> -config-all-devices.mak:
> +config-all-devices.mak: config-host.mak
>  	$(call quiet-command,echo '# no devices' > $@,"GEN","$@")
>  else
> -config-all-devices.mak: $(SUBDIR_DEVICES_MAK)
> +config-all-devices.mak: $(SUBDIR_DEVICES_MAK) config-host.mak
>  	$(call quiet-command, sed -n \
>               's|^\([^=]*\)=\(.*\)$$|\1:=$$(findstring y,$$(\1)\2)|p' \
>               $(SUBDIR_DEVICES_MAK) | sort -u > $@, \
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH] config-all-devices.mak: rebuild on reconfigure

Posted by Stefano Garzarella 6 years, 8 months ago

On Wed, Mar 13, 2019 at 01:42:32PM +0100, Paolo Bonzini wrote:
> This ensures that softmmu directories are culled after a
> "./configure --target-list=x86_64-linux-user".
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>