scripts/qemu-binfmt-conf.sh | 211 1 file changed, 133 insertions(+), 78 deletions(-)
Hi,
This series reworks qemu-binfmt-conf.sh:
* Argument <CPU> from option '--systemd' is generalized to <TARGETS>, and it is
accepted for any mode (default, debian or systemd). It can be a single target
arch or a list of them.
* Option '-r|--clear' is added, which allows to remove an already registered
target interpreter or a list of them. The implementation is functional but
partial. Please, see the corresponding commit.
* Option '-t|--test' is added, which allows to execute the CHECK according
to the provided arguments, but no interpreter is configured.
* Support to set options through environment variables: QEMU_TARGETS,
QEMU_PATH, QEMU_SUFFIX, QEMU_PERSISTENT, QEMU_CREDENTIAL, QEMU_CLEAR and
QEMU_TEST.
The following changes are not backward compatible:
* Option '--persistent' no longer requires/accepts an argument.
* Option '--credential' no longer requires/accepts an argument.
* Option '--systemd' no longer requires/accepts an argument.
* Option '--qemu-path' is renamed to '--path'.
* Option '--qemu-suffix' is renamed to '--suffix'.
The functionality of all of them is untouched. Changes are related to syntax only.
v7:
* Check that a interpreter exists before trying to remove it.
v6:
* Don't need to use "find".
* Put the ";;" at the same position.
* Set BINFMT_CLEAR to ':', to allow --test to work with --clear.
* Do not show DEBIANDIR and SYSTEMDDIR in the Env-variable column.
Based on:
* [PATCH v5 0/10] qemu-binfmt-conf.sh
* should have been [PATCH v5 0/9] qemu-binfmt-conf.sh
* [PATCH v4 0/10] qemu-binfmt-conf.sh
* [PATCH v3 0/10] qemu-binfmt-conf.sh
* [PATCH v2] qemu-binfmt-conf.sh: add CPUS, add --reset, make -p and -c boolean (no arg)
* [PATCH] qemu-binfmt-conf.sh: add CPUS, add --reset, make -p and -c boolean (no arg)
* scripts/qemu-binfmt-conf.sh: allow clearing of entries
Regards
Unai Martinez-Corral (9):
qemu-binfmt-conf.sh: enforce safe style consistency
qemu-binfmt-conf.sh: make opts -p and -c boolean
qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT
qemu-binfmt-conf.sh: use the same presentation format as for qemu-*
qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options
qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX
qemu-binfmt-conf.sh: generalize <CPU> to positional TARGETS
qemu-binfmt-conf.sh: add option --clear
qemu-binfmt-conf.sh: add --test
scripts/qemu-binfmt-conf.sh | 211
1 file changed, 133 insertions(+), 78 deletions(-)
Patchew URL: https://patchew.org/QEMU/20190312195009.GA6@99bbefa4bcea/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190312195009.GA6@99bbefa4bcea Subject: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190312195009.GA6@99bbefa4bcea -> patchew/20190312195009.GA6@99bbefa4bcea Switched to a new branch 'test' 80845c64d4 qemu-binfmt-conf.sh: add --test 5586270420 qemu-binfmt-conf.sh: add option --clear 43da463d22 qemu-binfmt-conf.sh: generalize <CPU> to positional TARGETS c2176e0775 qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX b0aeb4ee2d qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options ec6834e25c qemu-binfmt-conf.sh: use the same presentation format as for qemu-* 3a8283a663 qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT 33f94e2196 qemu-binfmt-conf.sh: make opts -p and -c boolean 48df1b0b47 qemu-binfmt-conf.sh: enforce safe style consistency === OUTPUT BEGIN === 1/9 Checking commit 48df1b0b4706 (qemu-binfmt-conf.sh: enforce safe style consistency) WARNING: line over 80 characters #53: FILE: scripts/qemu-binfmt-conf.sh:299: + if [ "x$magic" = "x" ] || [ "x$mask" = "x" ] || [ "x$family" = "x" ] ; then total: 0 errors, 1 warnings, 47 lines checked Patch 1/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/9 Checking commit 33f94e2196e8 (qemu-binfmt-conf.sh: make opts -p and -c boolean) ERROR: line over 90 characters #51: FILE: scripts/qemu-binfmt-conf.sh:327: +options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 0 warnings, 43 lines checked Patch 2/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/9 Checking commit 3a8283a6638c (qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT) 4/9 Checking commit ec6834e25c3d (qemu-binfmt-conf.sh: use the same presentation format as for qemu-*) WARNING: line over 80 characters #50: FILE: scripts/qemu-binfmt-conf.sh:179: +-F|--qemu-suffix SUFFIX add a suffix to the default interpreter name ERROR: line over 90 characters #51: FILE: scripts/qemu-binfmt-conf.sh:180: +-p|--persistent QEMU_PERSISTENT (yes) load the interpreter and keep it in memory; all future ERROR: line over 90 characters #53: FILE: scripts/qemu-binfmt-conf.sh:182: +-c|--credential QEMU_CREDENTIAL (yes) credential and security tokens are calculated according ERROR: line over 90 characters #58: FILE: scripts/qemu-binfmt-conf.sh:187: + systemd-binfmt.service for the given CPU; if CPU is "ALL", ERROR: line over 90 characters #60: FILE: scripts/qemu-binfmt-conf.sh:189: +-d|--debian don't write into /proc, generate update-binfmts templates ERROR: line over 90 characters #85: FILE: scripts/qemu-binfmt-conf.sh:206: +The environment variable HOST_ARCH allows to override 'uname' to generate configuration files for a total: 5 errors, 1 warnings, 79 lines checked Patch 4/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/9 Checking commit b0aeb4ee2de7 (qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options) WARNING: line over 80 characters #36: FILE: scripts/qemu-binfmt-conf.sh:180: +-F|--suffix SUFFIX add a suffix to the default interpreter name ERROR: line over 90 characters #45: FILE: scripts/qemu-binfmt-conf.sh:333: +options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 1 warnings, 38 lines checked Patch 5/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/9 Checking commit c2176e07753b (qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX) WARNING: line over 80 characters #23: FILE: scripts/qemu-binfmt-conf.sh:180: +-F|--suffix SUFFIX QEMU_SUFFIX add a suffix to the default interpreter name total: 0 errors, 1 warnings, 30 lines checked Patch 6/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/9 Checking commit 43da463d2254 (qemu-binfmt-conf.sh: generalize <CPU> to positional TARGETS) ERROR: line over 90 characters #77: FILE: scripts/qemu-binfmt-conf.sh:199: +TARGETS QEMU_TARGETS A single arch name or a list of them (see all names below); WARNING: line over 80 characters #90: FILE: scripts/qemu-binfmt-conf.sh:211: +-s|--systemd don't write into /proc, generate file(s) for ERROR: line over 90 characters #104: FILE: scripts/qemu-binfmt-conf.sh:230: +The environment variable HOST_ARCH allows to override 'uname' to generate configuration files for ERROR: line over 90 characters #146: FILE: scripts/qemu-binfmt-conf.sh:359: +options=$(getopt -o dsQ:S:e:hcp -l debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 3 errors, 1 warnings, 141 lines checked Patch 7/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/9 Checking commit 558627042036 (qemu-binfmt-conf.sh: add option --clear) WARNING: line over 80 characters #33: FILE: scripts/qemu-binfmt-conf.sh:200: + if empty, configure/clear all known targets; ERROR: line over 90 characters #41: FILE: scripts/qemu-binfmt-conf.sh:209: +-r|--clear QEMU_CLEAR (yes) remove registered interpreters for target TARGETS; ERROR: line over 90 characters #84: FILE: scripts/qemu-binfmt-conf.sh:377: +options=$(getopt -o rdsQ:S:e:hcp -l clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 2 errors, 1 warnings, 85 lines checked Patch 8/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/9 Checking commit 80845c64d48d (qemu-binfmt-conf.sh: add --test) WARNING: line over 80 characters #20: FILE: scripts/qemu-binfmt-conf.sh:200: + if empty, configure/clear all known targets. ERROR: line over 90 characters #28: FILE: scripts/qemu-binfmt-conf.sh:210: +-t|--test QEMU_TEST (yes) test the setup with the provided arguments, but do not ERROR: line over 90 characters #58: FILE: scripts/qemu-binfmt-conf.sh:377: +options=$(getopt -o trdsQ:S:e:hcp -l test,clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 2 errors, 1 warnings, 61 lines checked Patch 9/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190312195009.GA6@99bbefa4bcea/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190312195009.GA6@99bbefa4bcea/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190312195009.GA6@99bbefa4bcea Subject: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20190312195009.GA6@99bbefa4bcea -> patchew/20190312195009.GA6@99bbefa4bcea Switched to a new branch 'test' e819d6ed9e qemu-binfmt-conf.sh: add --test 26b615abf3 qemu-binfmt-conf.sh: add option --clear cee08eb4c4 qemu-binfmt-conf.sh: generalize <CPU> to positional TARGETS a96a30ce40 qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX 9548ba20ec qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options 20a81b773e qemu-binfmt-conf.sh: use the same presentation format as for qemu-* e3a537235c qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT b074dbd867 qemu-binfmt-conf.sh: make opts -p and -c boolean 0a24c9fd04 qemu-binfmt-conf.sh: enforce safe style consistency === OUTPUT BEGIN === 1/9 Checking commit 0a24c9fd04c2 (qemu-binfmt-conf.sh: enforce safe style consistency) WARNING: line over 80 characters #53: FILE: scripts/qemu-binfmt-conf.sh:299: + if [ "x$magic" = "x" ] || [ "x$mask" = "x" ] || [ "x$family" = "x" ] ; then total: 0 errors, 1 warnings, 47 lines checked Patch 1/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/9 Checking commit b074dbd867b5 (qemu-binfmt-conf.sh: make opts -p and -c boolean) ERROR: line over 90 characters #51: FILE: scripts/qemu-binfmt-conf.sh:327: +options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 0 warnings, 43 lines checked Patch 2/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/9 Checking commit e3a537235c0e (qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT) 4/9 Checking commit 20a81b773ed2 (qemu-binfmt-conf.sh: use the same presentation format as for qemu-*) WARNING: line over 80 characters #50: FILE: scripts/qemu-binfmt-conf.sh:179: +-F|--qemu-suffix SUFFIX add a suffix to the default interpreter name ERROR: line over 90 characters #51: FILE: scripts/qemu-binfmt-conf.sh:180: +-p|--persistent QEMU_PERSISTENT (yes) load the interpreter and keep it in memory; all future ERROR: line over 90 characters #53: FILE: scripts/qemu-binfmt-conf.sh:182: +-c|--credential QEMU_CREDENTIAL (yes) credential and security tokens are calculated according ERROR: line over 90 characters #58: FILE: scripts/qemu-binfmt-conf.sh:187: + systemd-binfmt.service for the given CPU; if CPU is "ALL", ERROR: line over 90 characters #60: FILE: scripts/qemu-binfmt-conf.sh:189: +-d|--debian don't write into /proc, generate update-binfmts templates ERROR: line over 90 characters #85: FILE: scripts/qemu-binfmt-conf.sh:206: +The environment variable HOST_ARCH allows to override 'uname' to generate configuration files for a total: 5 errors, 1 warnings, 79 lines checked Patch 4/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/9 Checking commit 9548ba20ec02 (qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options) WARNING: line over 80 characters #36: FILE: scripts/qemu-binfmt-conf.sh:180: +-F|--suffix SUFFIX add a suffix to the default interpreter name ERROR: line over 90 characters #45: FILE: scripts/qemu-binfmt-conf.sh:333: +options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 1 warnings, 38 lines checked Patch 5/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/9 Checking commit a96a30ce403f (qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX) WARNING: line over 80 characters #23: FILE: scripts/qemu-binfmt-conf.sh:180: +-F|--suffix SUFFIX QEMU_SUFFIX add a suffix to the default interpreter name total: 0 errors, 1 warnings, 30 lines checked Patch 6/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/9 Checking commit cee08eb4c4dd (qemu-binfmt-conf.sh: generalize <CPU> to positional TARGETS) ERROR: line over 90 characters #77: FILE: scripts/qemu-binfmt-conf.sh:199: +TARGETS QEMU_TARGETS A single arch name or a list of them (see all names below); WARNING: line over 80 characters #90: FILE: scripts/qemu-binfmt-conf.sh:211: +-s|--systemd don't write into /proc, generate file(s) for ERROR: line over 90 characters #104: FILE: scripts/qemu-binfmt-conf.sh:230: +The environment variable HOST_ARCH allows to override 'uname' to generate configuration files for ERROR: line over 90 characters #146: FILE: scripts/qemu-binfmt-conf.sh:359: +options=$(getopt -o dsQ:S:e:hcp -l debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 3 errors, 1 warnings, 141 lines checked Patch 7/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/9 Checking commit 26b615abf382 (qemu-binfmt-conf.sh: add option --clear) WARNING: line over 80 characters #33: FILE: scripts/qemu-binfmt-conf.sh:200: + if empty, configure/clear all known targets; ERROR: line over 90 characters #41: FILE: scripts/qemu-binfmt-conf.sh:209: +-r|--clear QEMU_CLEAR (yes) remove registered interpreters for target TARGETS; ERROR: line over 90 characters #84: FILE: scripts/qemu-binfmt-conf.sh:377: +options=$(getopt -o rdsQ:S:e:hcp -l clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 2 errors, 1 warnings, 85 lines checked Patch 8/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/9 Checking commit e819d6ed9e9e (qemu-binfmt-conf.sh: add --test) WARNING: line over 80 characters #20: FILE: scripts/qemu-binfmt-conf.sh:200: + if empty, configure/clear all known targets. ERROR: line over 90 characters #28: FILE: scripts/qemu-binfmt-conf.sh:210: +-t|--test QEMU_TEST (yes) test the setup with the provided arguments, but do not ERROR: line over 90 characters #58: FILE: scripts/qemu-binfmt-conf.sh:377: +options=$(getopt -o trdsQ:S:e:hcp -l test,clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 2 errors, 1 warnings, 61 lines checked Patch 9/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190312195009.GA6@99bbefa4bcea/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190312195009.GA6@99bbefa4bcea/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190312195009.GA6@99bbefa4bcea Subject: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190312171824.5134-1-crosa@redhat.com -> patchew/20190312171824.5134-1-crosa@redhat.com t [tag update] patchew/20190312195009.GA6@99bbefa4bcea -> patchew/20190312195009.GA6@99bbefa4bcea Switched to a new branch 'test' 4f59914a93 qemu-binfmt-conf.sh: add --test 8ee65ac438 qemu-binfmt-conf.sh: add option --clear 7a45257d07 qemu-binfmt-conf.sh: generalize <CPU> to positional TARGETS 1ecee77209 qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX 2eaac17758 qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options 3ebee7e51b qemu-binfmt-conf.sh: use the same presentation format as for qemu-* c1b1e47474 qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT 299ff87880 qemu-binfmt-conf.sh: make opts -p and -c boolean 9883443648 qemu-binfmt-conf.sh: enforce safe style consistency === OUTPUT BEGIN === 1/9 Checking commit 98834436488d (qemu-binfmt-conf.sh: enforce safe style consistency) WARNING: line over 80 characters #53: FILE: scripts/qemu-binfmt-conf.sh:299: + if [ "x$magic" = "x" ] || [ "x$mask" = "x" ] || [ "x$family" = "x" ] ; then total: 0 errors, 1 warnings, 47 lines checked Patch 1/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/9 Checking commit 299ff87880d0 (qemu-binfmt-conf.sh: make opts -p and -c boolean) ERROR: line over 90 characters #51: FILE: scripts/qemu-binfmt-conf.sh:327: +options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 0 warnings, 43 lines checked Patch 2/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/9 Checking commit c1b1e4747422 (qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT) 4/9 Checking commit 3ebee7e51b66 (qemu-binfmt-conf.sh: use the same presentation format as for qemu-*) WARNING: line over 80 characters #51: FILE: scripts/qemu-binfmt-conf.sh:179: +-F|--qemu-suffix SUFFIX add a suffix to the default interpreter name ERROR: line over 90 characters #52: FILE: scripts/qemu-binfmt-conf.sh:180: +-p|--persistent QEMU_PERSISTENT (yes) load the interpreter and keep it in memory; all future ERROR: line over 90 characters #54: FILE: scripts/qemu-binfmt-conf.sh:182: +-c|--credential QEMU_CREDENTIAL (yes) credential and security tokens are calculated according ERROR: line over 90 characters #59: FILE: scripts/qemu-binfmt-conf.sh:187: + systemd-binfmt.service for the given CPU; if CPU is "ALL", ERROR: line over 90 characters #61: FILE: scripts/qemu-binfmt-conf.sh:189: +-d|--debian don't write into /proc, generate update-binfmts templates ERROR: line over 90 characters #86: FILE: scripts/qemu-binfmt-conf.sh:206: +The environment variable HOST_ARCH allows to override 'uname' to generate configuration files for a total: 5 errors, 1 warnings, 79 lines checked Patch 4/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/9 Checking commit 2eaac17758b7 (qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options) WARNING: line over 80 characters #36: FILE: scripts/qemu-binfmt-conf.sh:180: +-F|--suffix SUFFIX add a suffix to the default interpreter name ERROR: line over 90 characters #45: FILE: scripts/qemu-binfmt-conf.sh:333: +options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 1 warnings, 38 lines checked Patch 5/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/9 Checking commit 1ecee7720915 (qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX) WARNING: line over 80 characters #23: FILE: scripts/qemu-binfmt-conf.sh:180: +-F|--suffix SUFFIX QEMU_SUFFIX add a suffix to the default interpreter name total: 0 errors, 1 warnings, 30 lines checked Patch 6/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/9 Checking commit 7a45257d07e2 (qemu-binfmt-conf.sh: generalize <CPU> to positional TARGETS) ERROR: line over 90 characters #78: FILE: scripts/qemu-binfmt-conf.sh:199: +TARGETS QEMU_TARGETS A single arch name or a list of them (see all names below); WARNING: line over 80 characters #91: FILE: scripts/qemu-binfmt-conf.sh:211: +-s|--systemd don't write into /proc, generate file(s) for ERROR: line over 90 characters #105: FILE: scripts/qemu-binfmt-conf.sh:230: +The environment variable HOST_ARCH allows to override 'uname' to generate configuration files for ERROR: line over 90 characters #147: FILE: scripts/qemu-binfmt-conf.sh:359: +options=$(getopt -o dsQ:S:e:hcp -l debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 3 errors, 1 warnings, 141 lines checked Patch 7/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/9 Checking commit 8ee65ac43884 (qemu-binfmt-conf.sh: add option --clear) WARNING: line over 80 characters #34: FILE: scripts/qemu-binfmt-conf.sh:200: + if empty, configure/clear all known targets; ERROR: line over 90 characters #42: FILE: scripts/qemu-binfmt-conf.sh:209: +-r|--clear QEMU_CLEAR (yes) remove registered interpreters for target TARGETS; ERROR: line over 90 characters #85: FILE: scripts/qemu-binfmt-conf.sh:377: +options=$(getopt -o rdsQ:S:e:hcp -l clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 2 errors, 1 warnings, 85 lines checked Patch 8/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/9 Checking commit 4f59914a93c2 (qemu-binfmt-conf.sh: add --test) WARNING: line over 80 characters #21: FILE: scripts/qemu-binfmt-conf.sh:200: + if empty, configure/clear all known targets. ERROR: line over 90 characters #29: FILE: scripts/qemu-binfmt-conf.sh:210: +-t|--test QEMU_TEST (yes) test the setup with the provided arguments, but do not ERROR: line over 90 characters #59: FILE: scripts/qemu-binfmt-conf.sh:377: +options=$(getopt -o trdsQ:S:e:hcp -l test,clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 2 errors, 1 warnings, 61 lines checked Patch 9/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190312195009.GA6@99bbefa4bcea/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190312195009.GA6@99bbefa4bcea/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190312195009.GA6@99bbefa4bcea Subject: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190312195009.GA6@99bbefa4bcea -> patchew/20190312195009.GA6@99bbefa4bcea Switched to a new branch 'test' a651b8320d qemu-binfmt-conf.sh: add --test e2f86ce293 qemu-binfmt-conf.sh: add option --clear 2ea57e2602 qemu-binfmt-conf.sh: generalize <CPU> to positional TARGETS 197281ce2d qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX bedab65ee6 qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options 70f19ed83e qemu-binfmt-conf.sh: use the same presentation format as for qemu-* 4df30acc1d qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT 67b173ceee qemu-binfmt-conf.sh: make opts -p and -c boolean 22962854ea qemu-binfmt-conf.sh: enforce safe style consistency === OUTPUT BEGIN === 1/9 Checking commit 22962854eaba (qemu-binfmt-conf.sh: enforce safe style consistency) WARNING: line over 80 characters #53: FILE: scripts/qemu-binfmt-conf.sh:299: + if [ "x$magic" = "x" ] || [ "x$mask" = "x" ] || [ "x$family" = "x" ] ; then total: 0 errors, 1 warnings, 47 lines checked Patch 1/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/9 Checking commit 67b173ceee23 (qemu-binfmt-conf.sh: make opts -p and -c boolean) ERROR: line over 90 characters #51: FILE: scripts/qemu-binfmt-conf.sh:327: +options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 0 warnings, 43 lines checked Patch 2/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/9 Checking commit 4df30acc1de5 (qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT) 4/9 Checking commit 70f19ed83eb8 (qemu-binfmt-conf.sh: use the same presentation format as for qemu-*) WARNING: line over 80 characters #51: FILE: scripts/qemu-binfmt-conf.sh:179: +-F|--qemu-suffix SUFFIX add a suffix to the default interpreter name ERROR: line over 90 characters #52: FILE: scripts/qemu-binfmt-conf.sh:180: +-p|--persistent QEMU_PERSISTENT (yes) load the interpreter and keep it in memory; all future ERROR: line over 90 characters #54: FILE: scripts/qemu-binfmt-conf.sh:182: +-c|--credential QEMU_CREDENTIAL (yes) credential and security tokens are calculated according ERROR: line over 90 characters #59: FILE: scripts/qemu-binfmt-conf.sh:187: + systemd-binfmt.service for the given CPU; if CPU is "ALL", ERROR: line over 90 characters #61: FILE: scripts/qemu-binfmt-conf.sh:189: +-d|--debian don't write into /proc, generate update-binfmts templates ERROR: line over 90 characters #86: FILE: scripts/qemu-binfmt-conf.sh:206: +The environment variable HOST_ARCH allows to override 'uname' to generate configuration files for a total: 5 errors, 1 warnings, 79 lines checked Patch 4/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/9 Checking commit bedab65ee6a6 (qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options) WARNING: line over 80 characters #36: FILE: scripts/qemu-binfmt-conf.sh:180: +-F|--suffix SUFFIX add a suffix to the default interpreter name ERROR: line over 90 characters #45: FILE: scripts/qemu-binfmt-conf.sh:333: +options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 1 warnings, 38 lines checked Patch 5/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/9 Checking commit 197281ce2d90 (qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX) WARNING: line over 80 characters #23: FILE: scripts/qemu-binfmt-conf.sh:180: +-F|--suffix SUFFIX QEMU_SUFFIX add a suffix to the default interpreter name total: 0 errors, 1 warnings, 30 lines checked Patch 6/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/9 Checking commit 2ea57e260288 (qemu-binfmt-conf.sh: generalize <CPU> to positional TARGETS) ERROR: line over 90 characters #78: FILE: scripts/qemu-binfmt-conf.sh:199: +TARGETS QEMU_TARGETS A single arch name or a list of them (see all names below); WARNING: line over 80 characters #91: FILE: scripts/qemu-binfmt-conf.sh:211: +-s|--systemd don't write into /proc, generate file(s) for ERROR: line over 90 characters #105: FILE: scripts/qemu-binfmt-conf.sh:230: +The environment variable HOST_ARCH allows to override 'uname' to generate configuration files for ERROR: line over 90 characters #147: FILE: scripts/qemu-binfmt-conf.sh:359: +options=$(getopt -o dsQ:S:e:hcp -l debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 3 errors, 1 warnings, 141 lines checked Patch 7/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/9 Checking commit e2f86ce29301 (qemu-binfmt-conf.sh: add option --clear) WARNING: line over 80 characters #34: FILE: scripts/qemu-binfmt-conf.sh:200: + if empty, configure/clear all known targets; ERROR: line over 90 characters #42: FILE: scripts/qemu-binfmt-conf.sh:209: +-r|--clear QEMU_CLEAR (yes) remove registered interpreters for target TARGETS; ERROR: line over 90 characters #85: FILE: scripts/qemu-binfmt-conf.sh:377: +options=$(getopt -o rdsQ:S:e:hcp -l clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 2 errors, 1 warnings, 85 lines checked Patch 8/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/9 Checking commit a651b8320daf (qemu-binfmt-conf.sh: add --test) WARNING: line over 80 characters #20: FILE: scripts/qemu-binfmt-conf.sh:200: + if empty, configure/clear all known targets. ERROR: line over 90 characters #28: FILE: scripts/qemu-binfmt-conf.sh:210: +-t|--test QEMU_TEST (yes) test the setup with the provided arguments, but do not ERROR: line over 90 characters #58: FILE: scripts/qemu-binfmt-conf.sh:377: +options=$(getopt -o trdsQ:S:e:hcp -l test,clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 2 errors, 1 warnings, 61 lines checked Patch 9/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190312195009.GA6@99bbefa4bcea/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190312195009.GA6@99bbefa4bcea/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190312195009.GA6@99bbefa4bcea Subject: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190312195009.GA6@99bbefa4bcea -> patchew/20190312195009.GA6@99bbefa4bcea * [new tag] patchew/20190312202337.5278-1-jsnow@redhat.com -> patchew/20190312202337.5278-1-jsnow@redhat.com Switched to a new branch 'test' e34a81207f qemu-binfmt-conf.sh: add --test f00350ba93 qemu-binfmt-conf.sh: add option --clear 8cf5c653b4 qemu-binfmt-conf.sh: generalize <CPU> to positional TARGETS 702f89668f qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX 577373fdef qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options 6383a3e38d qemu-binfmt-conf.sh: use the same presentation format as for qemu-* 2e28f97bc5 qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT 81913cda1b qemu-binfmt-conf.sh: make opts -p and -c boolean f0f634b937 qemu-binfmt-conf.sh: enforce safe style consistency === OUTPUT BEGIN === 1/9 Checking commit f0f634b937a6 (qemu-binfmt-conf.sh: enforce safe style consistency) WARNING: line over 80 characters #53: FILE: scripts/qemu-binfmt-conf.sh:299: + if [ "x$magic" = "x" ] || [ "x$mask" = "x" ] || [ "x$family" = "x" ] ; then total: 0 errors, 1 warnings, 47 lines checked Patch 1/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/9 Checking commit 81913cda1b66 (qemu-binfmt-conf.sh: make opts -p and -c boolean) ERROR: line over 90 characters #51: FILE: scripts/qemu-binfmt-conf.sh:327: +options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 0 warnings, 43 lines checked Patch 2/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/9 Checking commit 2e28f97bc500 (qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT) 4/9 Checking commit 6383a3e38da3 (qemu-binfmt-conf.sh: use the same presentation format as for qemu-*) WARNING: line over 80 characters #51: FILE: scripts/qemu-binfmt-conf.sh:179: +-F|--qemu-suffix SUFFIX add a suffix to the default interpreter name ERROR: line over 90 characters #52: FILE: scripts/qemu-binfmt-conf.sh:180: +-p|--persistent QEMU_PERSISTENT (yes) load the interpreter and keep it in memory; all future ERROR: line over 90 characters #54: FILE: scripts/qemu-binfmt-conf.sh:182: +-c|--credential QEMU_CREDENTIAL (yes) credential and security tokens are calculated according ERROR: line over 90 characters #59: FILE: scripts/qemu-binfmt-conf.sh:187: + systemd-binfmt.service for the given CPU; if CPU is "ALL", ERROR: line over 90 characters #61: FILE: scripts/qemu-binfmt-conf.sh:189: +-d|--debian don't write into /proc, generate update-binfmts templates ERROR: line over 90 characters #86: FILE: scripts/qemu-binfmt-conf.sh:206: +The environment variable HOST_ARCH allows to override 'uname' to generate configuration files for a total: 5 errors, 1 warnings, 79 lines checked Patch 4/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/9 Checking commit 577373fdef4c (qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options) WARNING: line over 80 characters #36: FILE: scripts/qemu-binfmt-conf.sh:180: +-F|--suffix SUFFIX add a suffix to the default interpreter name ERROR: line over 90 characters #45: FILE: scripts/qemu-binfmt-conf.sh:333: +options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 1 warnings, 38 lines checked Patch 5/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/9 Checking commit 702f89668f16 (qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX) WARNING: line over 80 characters #23: FILE: scripts/qemu-binfmt-conf.sh:180: +-F|--suffix SUFFIX QEMU_SUFFIX add a suffix to the default interpreter name total: 0 errors, 1 warnings, 30 lines checked Patch 6/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/9 Checking commit 8cf5c653b405 (qemu-binfmt-conf.sh: generalize <CPU> to positional TARGETS) ERROR: line over 90 characters #78: FILE: scripts/qemu-binfmt-conf.sh:199: +TARGETS QEMU_TARGETS A single arch name or a list of them (see all names below); WARNING: line over 80 characters #91: FILE: scripts/qemu-binfmt-conf.sh:211: +-s|--systemd don't write into /proc, generate file(s) for ERROR: line over 90 characters #105: FILE: scripts/qemu-binfmt-conf.sh:230: +The environment variable HOST_ARCH allows to override 'uname' to generate configuration files for ERROR: line over 90 characters #147: FILE: scripts/qemu-binfmt-conf.sh:359: +options=$(getopt -o dsQ:S:e:hcp -l debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 3 errors, 1 warnings, 141 lines checked Patch 7/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/9 Checking commit f00350ba93af (qemu-binfmt-conf.sh: add option --clear) WARNING: line over 80 characters #33: FILE: scripts/qemu-binfmt-conf.sh:200: + if empty, configure/clear all known targets; ERROR: line over 90 characters #41: FILE: scripts/qemu-binfmt-conf.sh:209: +-r|--clear QEMU_CLEAR (yes) remove registered interpreters for target TARGETS; ERROR: line over 90 characters #84: FILE: scripts/qemu-binfmt-conf.sh:377: +options=$(getopt -o rdsQ:S:e:hcp -l clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 2 errors, 1 warnings, 85 lines checked Patch 8/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/9 Checking commit e34a81207fc2 (qemu-binfmt-conf.sh: add --test) WARNING: line over 80 characters #20: FILE: scripts/qemu-binfmt-conf.sh:200: + if empty, configure/clear all known targets. ERROR: line over 90 characters #28: FILE: scripts/qemu-binfmt-conf.sh:210: +-t|--test QEMU_TEST (yes) test the setup with the provided arguments, but do not ERROR: line over 90 characters #58: FILE: scripts/qemu-binfmt-conf.sh:377: +options=$(getopt -o trdsQ:S:e:hcp -l test,clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 2 errors, 1 warnings, 61 lines checked Patch 9/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190312195009.GA6@99bbefa4bcea/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190312195009.GA6@99bbefa4bcea/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190312195009.GA6@99bbefa4bcea Subject: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190312195009.GA6@99bbefa4bcea -> patchew/20190312195009.GA6@99bbefa4bcea Switched to a new branch 'test' 0159f7ddf9 qemu-binfmt-conf.sh: add --test 613876a18c qemu-binfmt-conf.sh: add option --clear 3a8c528ea3 qemu-binfmt-conf.sh: generalize <CPU> to positional TARGETS 65a55027a7 qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX 062cf95f26 qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options 96648ab968 qemu-binfmt-conf.sh: use the same presentation format as for qemu-* 2adaecf085 qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT a9d09a2295 qemu-binfmt-conf.sh: make opts -p and -c boolean 9d0d2f8cab qemu-binfmt-conf.sh: enforce safe style consistency === OUTPUT BEGIN === 1/9 Checking commit 9d0d2f8cab52 (qemu-binfmt-conf.sh: enforce safe style consistency) WARNING: line over 80 characters #53: FILE: scripts/qemu-binfmt-conf.sh:299: + if [ "x$magic" = "x" ] || [ "x$mask" = "x" ] || [ "x$family" = "x" ] ; then total: 0 errors, 1 warnings, 47 lines checked Patch 1/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/9 Checking commit a9d09a229536 (qemu-binfmt-conf.sh: make opts -p and -c boolean) ERROR: line over 90 characters #51: FILE: scripts/qemu-binfmt-conf.sh:327: +options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 0 warnings, 43 lines checked Patch 2/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/9 Checking commit 2adaecf08517 (qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT) 4/9 Checking commit 96648ab968bd (qemu-binfmt-conf.sh: use the same presentation format as for qemu-*) WARNING: line over 80 characters #51: FILE: scripts/qemu-binfmt-conf.sh:179: +-F|--qemu-suffix SUFFIX add a suffix to the default interpreter name ERROR: line over 90 characters #52: FILE: scripts/qemu-binfmt-conf.sh:180: +-p|--persistent QEMU_PERSISTENT (yes) load the interpreter and keep it in memory; all future ERROR: line over 90 characters #54: FILE: scripts/qemu-binfmt-conf.sh:182: +-c|--credential QEMU_CREDENTIAL (yes) credential and security tokens are calculated according ERROR: line over 90 characters #59: FILE: scripts/qemu-binfmt-conf.sh:187: + systemd-binfmt.service for the given CPU; if CPU is "ALL", ERROR: line over 90 characters #61: FILE: scripts/qemu-binfmt-conf.sh:189: +-d|--debian don't write into /proc, generate update-binfmts templates ERROR: line over 90 characters #86: FILE: scripts/qemu-binfmt-conf.sh:206: +The environment variable HOST_ARCH allows to override 'uname' to generate configuration files for a total: 5 errors, 1 warnings, 79 lines checked Patch 4/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/9 Checking commit 062cf95f2651 (qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options) WARNING: line over 80 characters #36: FILE: scripts/qemu-binfmt-conf.sh:180: +-F|--suffix SUFFIX add a suffix to the default interpreter name ERROR: line over 90 characters #45: FILE: scripts/qemu-binfmt-conf.sh:333: +options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 1 warnings, 38 lines checked Patch 5/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/9 Checking commit 65a55027a798 (qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX) WARNING: line over 80 characters #23: FILE: scripts/qemu-binfmt-conf.sh:180: +-F|--suffix SUFFIX QEMU_SUFFIX add a suffix to the default interpreter name total: 0 errors, 1 warnings, 30 lines checked Patch 6/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/9 Checking commit 3a8c528ea335 (qemu-binfmt-conf.sh: generalize <CPU> to positional TARGETS) ERROR: line over 90 characters #77: FILE: scripts/qemu-binfmt-conf.sh:199: +TARGETS QEMU_TARGETS A single arch name or a list of them (see all names below); WARNING: line over 80 characters #90: FILE: scripts/qemu-binfmt-conf.sh:211: +-s|--systemd don't write into /proc, generate file(s) for ERROR: line over 90 characters #104: FILE: scripts/qemu-binfmt-conf.sh:230: +The environment variable HOST_ARCH allows to override 'uname' to generate configuration files for ERROR: line over 90 characters #146: FILE: scripts/qemu-binfmt-conf.sh:359: +options=$(getopt -o dsQ:S:e:hcp -l debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 3 errors, 1 warnings, 141 lines checked Patch 7/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/9 Checking commit 613876a18c9b (qemu-binfmt-conf.sh: add option --clear) WARNING: line over 80 characters #33: FILE: scripts/qemu-binfmt-conf.sh:200: + if empty, configure/clear all known targets; ERROR: line over 90 characters #41: FILE: scripts/qemu-binfmt-conf.sh:209: +-r|--clear QEMU_CLEAR (yes) remove registered interpreters for target TARGETS; ERROR: line over 90 characters #84: FILE: scripts/qemu-binfmt-conf.sh:377: +options=$(getopt -o rdsQ:S:e:hcp -l clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 2 errors, 1 warnings, 85 lines checked Patch 8/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/9 Checking commit 0159f7ddf923 (qemu-binfmt-conf.sh: add --test) WARNING: line over 80 characters #20: FILE: scripts/qemu-binfmt-conf.sh:200: + if empty, configure/clear all known targets. ERROR: line over 90 characters #28: FILE: scripts/qemu-binfmt-conf.sh:210: +-t|--test QEMU_TEST (yes) test the setup with the provided arguments, but do not ERROR: line over 90 characters #58: FILE: scripts/qemu-binfmt-conf.sh:377: +options=$(getopt -o trdsQ:S:e:hcp -l test,clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 2 errors, 1 warnings, 61 lines checked Patch 9/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190312195009.GA6@99bbefa4bcea/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190312195009.GA6@99bbefa4bcea/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190312195009.GA6@99bbefa4bcea Subject: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190312195009.GA6@99bbefa4bcea -> patchew/20190312195009.GA6@99bbefa4bcea Switched to a new branch 'test' 06fcdd2f68 qemu-binfmt-conf.sh: add --test 67dcee9729 qemu-binfmt-conf.sh: add option --clear 7bedb69707 qemu-binfmt-conf.sh: generalize <CPU> to positional TARGETS 3875b6eff7 qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX e6af40a676 qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options 1143ec15c3 qemu-binfmt-conf.sh: use the same presentation format as for qemu-* 07fe769605 qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT b5dc35e961 qemu-binfmt-conf.sh: make opts -p and -c boolean 9f57529d18 qemu-binfmt-conf.sh: enforce safe style consistency === OUTPUT BEGIN === 1/9 Checking commit 9f57529d18af (qemu-binfmt-conf.sh: enforce safe style consistency) WARNING: line over 80 characters #53: FILE: scripts/qemu-binfmt-conf.sh:299: + if [ "x$magic" = "x" ] || [ "x$mask" = "x" ] || [ "x$family" = "x" ] ; then total: 0 errors, 1 warnings, 47 lines checked Patch 1/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/9 Checking commit b5dc35e96166 (qemu-binfmt-conf.sh: make opts -p and -c boolean) ERROR: line over 90 characters #51: FILE: scripts/qemu-binfmt-conf.sh:327: +options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 0 warnings, 43 lines checked Patch 2/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/9 Checking commit 07fe76960563 (qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT) 4/9 Checking commit 1143ec15c340 (qemu-binfmt-conf.sh: use the same presentation format as for qemu-*) WARNING: line over 80 characters #51: FILE: scripts/qemu-binfmt-conf.sh:179: +-F|--qemu-suffix SUFFIX add a suffix to the default interpreter name ERROR: line over 90 characters #52: FILE: scripts/qemu-binfmt-conf.sh:180: +-p|--persistent QEMU_PERSISTENT (yes) load the interpreter and keep it in memory; all future ERROR: line over 90 characters #54: FILE: scripts/qemu-binfmt-conf.sh:182: +-c|--credential QEMU_CREDENTIAL (yes) credential and security tokens are calculated according ERROR: line over 90 characters #59: FILE: scripts/qemu-binfmt-conf.sh:187: + systemd-binfmt.service for the given CPU; if CPU is "ALL", ERROR: line over 90 characters #61: FILE: scripts/qemu-binfmt-conf.sh:189: +-d|--debian don't write into /proc, generate update-binfmts templates ERROR: line over 90 characters #86: FILE: scripts/qemu-binfmt-conf.sh:206: +The environment variable HOST_ARCH allows to override 'uname' to generate configuration files for a total: 5 errors, 1 warnings, 79 lines checked Patch 4/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/9 Checking commit e6af40a67671 (qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options) WARNING: line over 80 characters #36: FILE: scripts/qemu-binfmt-conf.sh:180: +-F|--suffix SUFFIX add a suffix to the default interpreter name ERROR: line over 90 characters #45: FILE: scripts/qemu-binfmt-conf.sh:333: +options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 1 warnings, 38 lines checked Patch 5/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/9 Checking commit 3875b6eff7eb (qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX) WARNING: line over 80 characters #23: FILE: scripts/qemu-binfmt-conf.sh:180: +-F|--suffix SUFFIX QEMU_SUFFIX add a suffix to the default interpreter name total: 0 errors, 1 warnings, 30 lines checked Patch 6/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/9 Checking commit 7bedb69707b1 (qemu-binfmt-conf.sh: generalize <CPU> to positional TARGETS) ERROR: line over 90 characters #77: FILE: scripts/qemu-binfmt-conf.sh:199: +TARGETS QEMU_TARGETS A single arch name or a list of them (see all names below); WARNING: line over 80 characters #90: FILE: scripts/qemu-binfmt-conf.sh:211: +-s|--systemd don't write into /proc, generate file(s) for ERROR: line over 90 characters #104: FILE: scripts/qemu-binfmt-conf.sh:230: +The environment variable HOST_ARCH allows to override 'uname' to generate configuration files for ERROR: line over 90 characters #146: FILE: scripts/qemu-binfmt-conf.sh:359: +options=$(getopt -o dsQ:S:e:hcp -l debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 3 errors, 1 warnings, 141 lines checked Patch 7/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/9 Checking commit 67dcee9729cd (qemu-binfmt-conf.sh: add option --clear) WARNING: line over 80 characters #33: FILE: scripts/qemu-binfmt-conf.sh:200: + if empty, configure/clear all known targets; ERROR: line over 90 characters #41: FILE: scripts/qemu-binfmt-conf.sh:209: +-r|--clear QEMU_CLEAR (yes) remove registered interpreters for target TARGETS; ERROR: line over 90 characters #84: FILE: scripts/qemu-binfmt-conf.sh:377: +options=$(getopt -o rdsQ:S:e:hcp -l clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 2 errors, 1 warnings, 85 lines checked Patch 8/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/9 Checking commit 06fcdd2f68ce (qemu-binfmt-conf.sh: add --test) WARNING: line over 80 characters #20: FILE: scripts/qemu-binfmt-conf.sh:200: + if empty, configure/clear all known targets. ERROR: line over 90 characters #28: FILE: scripts/qemu-binfmt-conf.sh:210: +-t|--test QEMU_TEST (yes) test the setup with the provided arguments, but do not ERROR: line over 90 characters #58: FILE: scripts/qemu-binfmt-conf.sh:377: +options=$(getopt -o trdsQ:S:e:hcp -l test,clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 2 errors, 1 warnings, 61 lines checked Patch 9/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190312195009.GA6@99bbefa4bcea/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190312195009.GA6@99bbefa4bcea/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190312195009.GA6@99bbefa4bcea Subject: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190312195009.GA6@99bbefa4bcea -> patchew/20190312195009.GA6@99bbefa4bcea Switched to a new branch 'test' db00757392 qemu-binfmt-conf.sh: add --test d9371a760a qemu-binfmt-conf.sh: add option --clear 3e38998afe qemu-binfmt-conf.sh: generalize <CPU> to positional TARGETS c05e91d1d2 qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX e5c54cc358 qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options 443291983a qemu-binfmt-conf.sh: use the same presentation format as for qemu-* b979bcce07 qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT d02fe8d3da qemu-binfmt-conf.sh: make opts -p and -c boolean a8c25771ea qemu-binfmt-conf.sh: enforce safe style consistency === OUTPUT BEGIN === 1/9 Checking commit a8c25771ea74 (qemu-binfmt-conf.sh: enforce safe style consistency) WARNING: line over 80 characters #53: FILE: scripts/qemu-binfmt-conf.sh:299: + if [ "x$magic" = "x" ] || [ "x$mask" = "x" ] || [ "x$family" = "x" ] ; then total: 0 errors, 1 warnings, 47 lines checked Patch 1/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/9 Checking commit d02fe8d3daab (qemu-binfmt-conf.sh: make opts -p and -c boolean) ERROR: line over 90 characters #51: FILE: scripts/qemu-binfmt-conf.sh:327: +options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 0 warnings, 43 lines checked Patch 2/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/9 Checking commit b979bcce0795 (qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT) 4/9 Checking commit 443291983a5d (qemu-binfmt-conf.sh: use the same presentation format as for qemu-*) WARNING: line over 80 characters #50: FILE: scripts/qemu-binfmt-conf.sh:179: +-F|--qemu-suffix SUFFIX add a suffix to the default interpreter name ERROR: line over 90 characters #51: FILE: scripts/qemu-binfmt-conf.sh:180: +-p|--persistent QEMU_PERSISTENT (yes) load the interpreter and keep it in memory; all future ERROR: line over 90 characters #53: FILE: scripts/qemu-binfmt-conf.sh:182: +-c|--credential QEMU_CREDENTIAL (yes) credential and security tokens are calculated according ERROR: line over 90 characters #58: FILE: scripts/qemu-binfmt-conf.sh:187: + systemd-binfmt.service for the given CPU; if CPU is "ALL", ERROR: line over 90 characters #60: FILE: scripts/qemu-binfmt-conf.sh:189: +-d|--debian don't write into /proc, generate update-binfmts templates ERROR: line over 90 characters #85: FILE: scripts/qemu-binfmt-conf.sh:206: +The environment variable HOST_ARCH allows to override 'uname' to generate configuration files for a total: 5 errors, 1 warnings, 79 lines checked Patch 4/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/9 Checking commit e5c54cc358b8 (qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options) WARNING: line over 80 characters #36: FILE: scripts/qemu-binfmt-conf.sh:180: +-F|--suffix SUFFIX add a suffix to the default interpreter name ERROR: line over 90 characters #45: FILE: scripts/qemu-binfmt-conf.sh:333: +options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 1 warnings, 38 lines checked Patch 5/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/9 Checking commit c05e91d1d23d (qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX) WARNING: line over 80 characters #23: FILE: scripts/qemu-binfmt-conf.sh:180: +-F|--suffix SUFFIX QEMU_SUFFIX add a suffix to the default interpreter name total: 0 errors, 1 warnings, 30 lines checked Patch 6/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/9 Checking commit 3e38998afeae (qemu-binfmt-conf.sh: generalize <CPU> to positional TARGETS) ERROR: line over 90 characters #77: FILE: scripts/qemu-binfmt-conf.sh:199: +TARGETS QEMU_TARGETS A single arch name or a list of them (see all names below); WARNING: line over 80 characters #90: FILE: scripts/qemu-binfmt-conf.sh:211: +-s|--systemd don't write into /proc, generate file(s) for ERROR: line over 90 characters #104: FILE: scripts/qemu-binfmt-conf.sh:230: +The environment variable HOST_ARCH allows to override 'uname' to generate configuration files for ERROR: line over 90 characters #146: FILE: scripts/qemu-binfmt-conf.sh:359: +options=$(getopt -o dsQ:S:e:hcp -l debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 3 errors, 1 warnings, 141 lines checked Patch 7/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/9 Checking commit d9371a760a47 (qemu-binfmt-conf.sh: add option --clear) WARNING: line over 80 characters #33: FILE: scripts/qemu-binfmt-conf.sh:200: + if empty, configure/clear all known targets; ERROR: line over 90 characters #41: FILE: scripts/qemu-binfmt-conf.sh:209: +-r|--clear QEMU_CLEAR (yes) remove registered interpreters for target TARGETS; ERROR: line over 90 characters #84: FILE: scripts/qemu-binfmt-conf.sh:377: +options=$(getopt -o rdsQ:S:e:hcp -l clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 2 errors, 1 warnings, 85 lines checked Patch 8/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/9 Checking commit db0075739279 (qemu-binfmt-conf.sh: add --test) WARNING: line over 80 characters #20: FILE: scripts/qemu-binfmt-conf.sh:200: + if empty, configure/clear all known targets. ERROR: line over 90 characters #28: FILE: scripts/qemu-binfmt-conf.sh:210: +-t|--test QEMU_TEST (yes) test the setup with the provided arguments, but do not ERROR: line over 90 characters #58: FILE: scripts/qemu-binfmt-conf.sh:377: +options=$(getopt -o trdsQ:S:e:hcp -l test,clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 2 errors, 1 warnings, 61 lines checked Patch 9/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190312195009.GA6@99bbefa4bcea/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
© 2016 - 2025 Red Hat, Inc.