The result of this typo would be that "select_foo" would be treated as a "select"
keyword followed by "_foo".  Nothing too bad, but easy to fix so let's be clean.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 scripts/minikconf.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/minikconf.py b/scripts/minikconf.py
index 5421db0ed0..0ffc6c38da 100644
--- a/scripts/minikconf.py
+++ b/scripts/minikconf.py
@@ -592,7 +592,7 @@ class KconfigParser:
         if not self.src.startswith(rest, self.cursor):
             return False
         length = len(rest)
-        if self.src[self.cursor + length].isalnum() or self.src[self.cursor + length] == '|':
+        if self.src[self.cursor + length].isalnum() or self.src[self.cursor + length] == '_':
             return False
         self.cursor += length
         return True
-- 
2.20.1

Patchew URL: https://patchew.org/QEMU/20190312165733.31387-1-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190312165733.31387-1-pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH] minikconf: fix parser typo

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20190312165733.31387-1-pbonzini@redhat.com -> patchew/20190312165733.31387-1-pbonzini@redhat.com
Switched to a new branch 'test'
7685a0cc9f minikconf: fix parser typo

=== OUTPUT BEGIN ===
ERROR: line over 90 characters
#22: FILE: scripts/minikconf.py:595:
+        if self.src[self.cursor + length].isalnum() or self.src[self.cursor + length] == '_':

total: 1 errors, 0 warnings, 8 lines checked

Commit 7685a0cc9f94 (minikconf: fix parser typo) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190312165733.31387-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com