The following changes since commit 377b155bde451d5ac545fbdcdfbf6ca17a4228f5:

  Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2019-03-11 18:26:37 +0000)

are available in the Git repository at:

  git://github.com/bonzini/qemu.git tags/for-upstream

for you to fetch changes up to 1e25879e6f832373775492c11c648ab2fff69bd5:

  test-migration: fix memory leak (2019-03-12 15:18:40 +0100)

----------------------------------------------------------------
* ASAN fixes

----------------------------------------------------------------
Paolo Bonzini (4):
      test-char: fix undefined behavior
      test-bdrv-graph-mod: fix Error leak
      migration: fix memory leak
      test-migration: fix memory leak

 migration/socket.c          | 1 +
 tests/migration-test.c      | 3 ++-
 tests/test-bdrv-graph-mod.c | 1 +
 tests/test-char.c           | 2 +-
 4 files changed, 5 insertions(+), 2 deletions(-)
-- 
2.20.1

On 3/12/19 9:36 AM, Paolo Bonzini wrote:
> The following changes since commit 377b155bde451d5ac545fbdcdfbf6ca17a4228f5:
> 
>   Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2019-03-11 18:26:37 +0000)
> 
> are available in the Git repository at:
> 
>   git://github.com/bonzini/qemu.git tags/for-upstream
> 
> for you to fetch changes up to 1e25879e6f832373775492c11c648ab2fff69bd5:
> 
>   test-migration: fix memory leak (2019-03-12 15:18:40 +0100)
> 
> ----------------------------------------------------------------
> * ASAN fixes
> 
> ----------------------------------------------------------------
> Paolo Bonzini (4):
>       test-char: fix undefined behavior
>       test-bdrv-graph-mod: fix Error leak

I argued for a better fix for patch 2. Although the changes are minor
and therefore probably okay to take the pull request as-is, it also
feels like this pull request is needlessly rushed: it is less than 30
minutes after the patch was first posted to the list.  And since they
ARE bug-fixes, the content in these patches are appropriate during soft
freeze, rather than having to get in today.

Oh well, I'm fine whether this goes in as-is (and we do a followup patch
to use error_free_or_abort) or if we get a v2 on this series.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

On 12/03/19 15:50, Eric Blake wrote:
> I argued for a better fix for patch 2. Although the changes are minor
> and therefore probably okay to take the pull request as-is, it also
> feels like this pull request is needlessly rushed: it is less than 30
> minutes after the patch was first posted to the list.  And since they
> ARE bug-fixes, the content in these patches are appropriate during soft
> freeze, rather than having to get in today.

True, on the other hand the failures are in master and they are causing
Patch to mark all series as testing failures (asan failures are not yet
sent to the mailing list).

I'm sorry for not noticing your answer to patch 2.

Paolo

On 3/12/19 9:54 AM, Paolo Bonzini wrote:
> On 12/03/19 15:50, Eric Blake wrote:
>> I argued for a better fix for patch 2. Although the changes are minor
>> and therefore probably okay to take the pull request as-is, it also
>> feels like this pull request is needlessly rushed: it is less than 30
>> minutes after the patch was first posted to the list.  And since they
>> ARE bug-fixes, the content in these patches are appropriate during soft
>> freeze, rather than having to get in today.
> 
> True, on the other hand the failures are in master and they are causing
> Patch to mark all series as testing failures (asan failures are not yet
> sent to the mailing list).

Okay, that gives some more context (making patchew more reliable on
other patches is indeed a reasonable reason for a quick fix). (And it
makes a change for you to get a complaint about a fast patch, after the
recent complaints you've had in the other direction about why a small
patch doesn't go fast :)

> 
> I'm sorry for not noticing your answer to patch 2.

Such is life when mails cross. No hard feelings.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

On Tue, 12 Mar 2019 at 14:38, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> The following changes since commit 377b155bde451d5ac545fbdcdfbf6ca17a4228f5:
>
>   Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2019-03-11 18:26:37 +0000)
>
> are available in the Git repository at:
>
>   git://github.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to 1e25879e6f832373775492c11c648ab2fff69bd5:
>
>   test-migration: fix memory leak (2019-03-12 15:18:40 +0100)
>
> ----------------------------------------------------------------
> * ASAN fixes
>
> ----------------------------------------------------------------

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0
for any user-visible changes.

-- PMM