riscv/Kconfig: enable PCI_DEVICES

[Qemu-devel] [PATCH] riscv/Kconfig: enable PCI_DEVICES

Posted by David Abdurachmanov 6 years, 8 months ago

Re-enable PCI_DEVICES for RISC-V.
The patch is based on other <arch>/Kconfig.

Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
Fixes: 82a230d5a303 ("riscv-softmmu.mak: replace CONFIG_* with Kconfig "select" directives")
---
 hw/riscv/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig
index e0ee3043a6..8c7fc1f31d 100644
--- a/hw/riscv/Kconfig
+++ b/hw/riscv/Kconfig
@@ -26,6 +26,9 @@ config SPIKE
 
 config RISCV_VIRT
     bool
+    imply PCI_DEVICES
+    imply TEST_DEVICES
+    select PCI
     select HART
     select SERIAL
     select VIRTIO_MMIO
-- 
2.20.1

Re: [Qemu-devel] [PATCH] riscv/Kconfig: enable PCI_DEVICES

Posted by Thomas Huth 6 years, 8 months ago

On 11/03/2019 10.12, David Abdurachmanov wrote:
> Re-enable PCI_DEVICES for RISC-V.
> The patch is based on other <arch>/Kconfig.
> 
> Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
> Fixes: 82a230d5a303 ("riscv-softmmu.mak: replace CONFIG_* with Kconfig "select" directives")
> ---
>  hw/riscv/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig
> index e0ee3043a6..8c7fc1f31d 100644
> --- a/hw/riscv/Kconfig
> +++ b/hw/riscv/Kconfig
> @@ -26,6 +26,9 @@ config SPIKE
>  
>  config RISCV_VIRT
>      bool
> +    imply PCI_DEVICES
> +    imply TEST_DEVICES
> +    select PCI
>      select HART
>      select SERIAL
>      select VIRTIO_MMIO
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [PATCH] riscv/Kconfig: enable PCI_DEVICES

Posted by Paolo Bonzini 6 years, 8 months ago

On 11/03/19 13:46, Thomas Huth wrote:
> On 11/03/2019 10.12, David Abdurachmanov wrote:
>> Re-enable PCI_DEVICES for RISC-V.
>> The patch is based on other <arch>/Kconfig.
>>
>> Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
>> Fixes: 82a230d5a303 ("riscv-softmmu.mak: replace CONFIG_* with Kconfig "select" directives")
>> ---
>>  hw/riscv/Kconfig | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig
>> index e0ee3043a6..8c7fc1f31d 100644
>> --- a/hw/riscv/Kconfig
>> +++ b/hw/riscv/Kconfig
>> @@ -26,6 +26,9 @@ config SPIKE
>>  
>>  config RISCV_VIRT
>>      bool
>> +    imply PCI_DEVICES
>> +    imply TEST_DEVICES
>> +    select PCI
>>      select HART
>>      select SERIAL
>>      select VIRTIO_MMIO
>>
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> 

Queued, thanks.

Paolo

Re: [Qemu-devel] [PATCH] riscv/Kconfig: enable PCI_DEVICES

Posted by Palmer Dabbelt 6 years, 8 months ago

On Mon, 11 Mar 2019 06:52:33 PDT (-0700), pbonzini@redhat.com wrote:
> On 11/03/19 13:46, Thomas Huth wrote:
>> On 11/03/2019 10.12, David Abdurachmanov wrote:
>>> Re-enable PCI_DEVICES for RISC-V.
>>> The patch is based on other <arch>/Kconfig.
>>>
>>> Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
>>> Fixes: 82a230d5a303 ("riscv-softmmu.mak: replace CONFIG_* with Kconfig "select" directives")
>>> ---
>>>  hw/riscv/Kconfig | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig
>>> index e0ee3043a6..8c7fc1f31d 100644
>>> --- a/hw/riscv/Kconfig
>>> +++ b/hw/riscv/Kconfig
>>> @@ -26,6 +26,9 @@ config SPIKE
>>>
>>>  config RISCV_VIRT
>>>      bool
>>> +    imply PCI_DEVICES
>>> +    imply TEST_DEVICES
>>> +    select PCI
>>>      select HART
>>>      select SERIAL
>>>      select VIRTIO_MMIO
>>>
>>
>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>>
>
> Queued, thanks.

Thanks for picking this up!