vfio-pci: enable by default

[Qemu-devel] [PATCH] vfio-pci: enable by default

Paolo Bonzini posted 1 patch 6 years, 8 months ago

Download mbox

Test asan failed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190308173622.21386-1-pbonzini@redhat.com

Maintainers: Alex Williamson <alex.williamson@redhat.com>

hw/vfio/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] vfio-pci: enable by default

Posted by Paolo Bonzini 6 years, 8 months ago

CONFIG_VFIO_PCI was not "default y" - and once you do that, it is also important
to disable it if PCI is not there.

Reported-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/vfio/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/vfio/Kconfig b/hw/vfio/Kconfig
index ebda9fdf22..34da2a3cfd 100644
--- a/hw/vfio/Kconfig
+++ b/hw/vfio/Kconfig
@@ -4,8 +4,9 @@ config VFIO
 
 config VFIO_PCI
     bool
+    default y
     select VFIO
-    depends on LINUX
+    depends on LINUX && PCI
 
 config VFIO_CCW
     bool
-- 
2.20.1

Re: [Qemu-devel] [PATCH] vfio-pci: enable by default

Posted by Daniel Henrique Barboza 6 years, 8 months ago

Just faced this problem when trying to test vfio-pci using upstream:

qemu-system-ppc64: -device vfio-pci,host=0035:03:00.0,id=hostdev8: 
'vfio-pci' is not a valid device model name


This patch fixed it.

Tested-by: Daniel Henrique Barboza <danielhb413@gmail.com>


On 3/8/19 2:36 PM, Paolo Bonzini wrote:
> CONFIG_VFIO_PCI was not "default y" - and once you do that, it is also important
> to disable it if PCI is not there.
>
> Reported-by: Alex Williamson <alex.williamson@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   hw/vfio/Kconfig | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/vfio/Kconfig b/hw/vfio/Kconfig
> index ebda9fdf22..34da2a3cfd 100644
> --- a/hw/vfio/Kconfig
> +++ b/hw/vfio/Kconfig
> @@ -4,8 +4,9 @@ config VFIO
>   
>   config VFIO_PCI
>       bool
> +    default y
>       select VFIO
> -    depends on LINUX
> +    depends on LINUX && PCI
>   
>   config VFIO_CCW
>       bool

Re: [Qemu-devel] [PATCH] vfio-pci: enable by default

Posted by Alex Williamson 6 years, 8 months ago

On Fri,  8 Mar 2019 18:36:22 +0100
Paolo Bonzini <pbonzini@redhat.com> wrote:

> CONFIG_VFIO_PCI was not "default y" - and once you do that, it is also important
> to disable it if PCI is not there.
> 
> Reported-by: Alex Williamson <alex.williamson@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/vfio/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks Paolo!  FWIW...

Tested-by: Alex Williamson <alex.williamson@redhat.com>

> diff --git a/hw/vfio/Kconfig b/hw/vfio/Kconfig
> index ebda9fdf22..34da2a3cfd 100644
> --- a/hw/vfio/Kconfig
> +++ b/hw/vfio/Kconfig
> @@ -4,8 +4,9 @@ config VFIO
>  
>  config VFIO_PCI
>      bool
> +    default y
>      select VFIO
> -    depends on LINUX
> +    depends on LINUX && PCI
>  
>  config VFIO_CCW
>      bool