[v1] file-posix: Make auto-read-only dynamic

[Qemu-devel] [PATCH 1/8] tests/virtio-blk-test: Disable auto-read-only

Posted by Kevin Wolf 6 years, 8 months ago

tests/virtio-blk-test uses a temporary image file that it deletes while
QEMU is still running, so it can't be reopened when writers are
attached or detached. Disable auto-read-only to keep it always writable.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 tests/virtio-blk-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c
index 8d2fc9c710..0e464aeea4 100644
--- a/tests/virtio-blk-test.c
+++ b/tests/virtio-blk-test.c
@@ -72,7 +72,7 @@ static QOSState *pci_test_start(void)
     QOSState *qs;
     const char *arch = qtest_get_arch();
     char *tmp_path;
-    const char *cmd = "-drive if=none,id=drive0,file=%s,format=raw "
+    const char *cmd = "-drive if=none,id=drive0,file=%s,format=raw,auto-read-only=off "
                       "-drive if=none,id=drive1,file=null-co://,format=raw "
                       "-device virtio-blk-pci,id=drv0,drive=drive0,"
                       "addr=%x.%x";
-- 
2.20.1

Re: [Qemu-devel] [PATCH 1/8] tests/virtio-blk-test: Disable auto-read-only

Posted by Eric Blake 6 years, 8 months ago

On 3/8/19 9:37 AM, Kevin Wolf wrote:
> tests/virtio-blk-test uses a temporary image file that it deletes while
> QEMU is still running, so it can't be reopened when writers are
> attached or detached. Disable auto-read-only to keep it always writable.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  tests/virtio-blk-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c
> index 8d2fc9c710..0e464aeea4 100644
> --- a/tests/virtio-blk-test.c
> +++ b/tests/virtio-blk-test.c
> @@ -72,7 +72,7 @@ static QOSState *pci_test_start(void)
>      QOSState *qs;
>      const char *arch = qtest_get_arch();
>      char *tmp_path;
> -    const char *cmd = "-drive if=none,id=drive0,file=%s,format=raw "
> +    const char *cmd = "-drive if=none,id=drive0,file=%s,format=raw,auto-read-only=off "
>                        "-drive if=none,id=drive1,file=null-co://,format=raw "
>                        "-device virtio-blk-pci,id=drv0,drive=drive0,"
>                        "addr=%x.%x";
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org