[Qemu-devel] [PATCH 0/9] tcg: Add tcg_gen_extract2_{i32,i64}

Richard Henderson posted 9 patches 5 years, 1 month ago
Test docker-mingw@fedora passed
Test asan failed
Test checkpatch failed
Test docker-clang@ubuntu passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190307144126.31847-1-richard.henderson@linaro.org
Maintainers: Richard Henderson <rth@twiddle.net>, Palmer Dabbelt <palmer@sifive.com>, Stefan Weil <sw@weilnetz.de>, Andrzej Zaborowski <balrogg@gmail.com>, Aleksandar Rikalo <arikalo@wavecomp.com>, Alistair Francis <Alistair.Francis@wdc.com>, Peter Maydell <peter.maydell@linaro.org>, Aurelien Jarno <aurelien@aurel32.net>, Claudio Fontana <claudio.fontana@huawei.com>
tcg/aarch64/tcg-target.h     |   2 +
tcg/arm/tcg-target.h         |   1 +
tcg/i386/tcg-target.h        |   2 +
tcg/mips/tcg-target.h        |   2 +
tcg/ppc/tcg-target.h         |   2 +
tcg/riscv/tcg-target.h       |   2 +
tcg/s390/tcg-target.h        |   2 +
tcg/sparc/tcg-target.h       |   2 +
tcg/tcg-op.h                 |   6 ++
tcg/tcg-opc.h                |   2 +
tcg/tcg.h                    |   1 +
tcg/tci/tcg-target.h         |   2 +
target/arm/translate-a64.c   |  44 +++++++------
tcg/aarch64/tcg-target.inc.c |  11 ++++
tcg/arm/tcg-target.inc.c     |  25 +++++++
tcg/i386/tcg-target.inc.c    |  11 ++++
tcg/optimize.c               |  10 +++
tcg/tcg-op.c                 | 123 ++++++++++++++++++++++++++++-------
tcg/tcg.c                    |   4 ++
tcg/README                   |   5 ++
20 files changed, 213 insertions(+), 46 deletions(-)
[Qemu-devel] [PATCH 0/9] tcg: Add tcg_gen_extract2_{i32,i64}
Posted by Richard Henderson 5 years, 1 month ago
The primary motivator here is usage within s390x,
but (as with any good primitive) the opcode has
applications outside that.


r~


David Hildenbrand (1):
  tcg: Implement tcg_gen_extract2_{i32,i64}

Richard Henderson (8):
  tcg: Add INDEX_op_extract2_{i32,i64}
  tcg: Use extract2 in tcg_gen_shifti_i64
  tcg: Use extract2 in tcg_gen_deposit_{i32,i64}
  tcg/i386: Support INDEX_op_extract2_{i32,i64}
  tcg/arm: Support INDEX_op_extract2_i32
  tcg/aarch64: Support INDEX_op_extract2_{i32,i64}
  target/arm: Use extract2 for EXTR
  target/arm: Simplify BFXIL expansion

 tcg/aarch64/tcg-target.h     |   2 +
 tcg/arm/tcg-target.h         |   1 +
 tcg/i386/tcg-target.h        |   2 +
 tcg/mips/tcg-target.h        |   2 +
 tcg/ppc/tcg-target.h         |   2 +
 tcg/riscv/tcg-target.h       |   2 +
 tcg/s390/tcg-target.h        |   2 +
 tcg/sparc/tcg-target.h       |   2 +
 tcg/tcg-op.h                 |   6 ++
 tcg/tcg-opc.h                |   2 +
 tcg/tcg.h                    |   1 +
 tcg/tci/tcg-target.h         |   2 +
 target/arm/translate-a64.c   |  44 +++++++------
 tcg/aarch64/tcg-target.inc.c |  11 ++++
 tcg/arm/tcg-target.inc.c     |  25 +++++++
 tcg/i386/tcg-target.inc.c    |  11 ++++
 tcg/optimize.c               |  10 +++
 tcg/tcg-op.c                 | 123 ++++++++++++++++++++++++++++-------
 tcg/tcg.c                    |   4 ++
 tcg/README                   |   5 ++
 20 files changed, 213 insertions(+), 46 deletions(-)

-- 
2.17.2


Re: [Qemu-devel] [PATCH 0/9] tcg: Add tcg_gen_extract2_{i32,i64}
Posted by no-reply@patchew.org 5 years, 1 month ago
Patchew URL: https://patchew.org/QEMU/20190307144126.31847-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190307144126.31847-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH 0/9] tcg: Add tcg_gen_extract2_{i32,i64}

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20190307144126.31847-1-richard.henderson@linaro.org -> patchew/20190307144126.31847-1-richard.henderson@linaro.org
Switched to a new branch 'test'
a5ab4c242b target/arm: Simplify BFXIL expansion
d1fcb8aecd target/arm: Use extract2 for EXTR
197413642f tcg/aarch64: Support INDEX_op_extract2_{i32, i64}
65cc26fced tcg/arm: Support INDEX_op_extract2_i32
0f7ffc52ad tcg/i386: Support INDEX_op_extract2_{i32, i64}
f11f5ed5da tcg: Use extract2 in tcg_gen_deposit_{i32, i64}
b51641ae95 tcg: Use extract2 in tcg_gen_shifti_i64
9526239495 tcg: Add INDEX_op_extract2_{i32,i64}
4846d47020 tcg: Implement tcg_gen_extract2_{i32, i64}

=== OUTPUT BEGIN ===
1/9 Checking commit 4846d470202c (tcg: Implement tcg_gen_extract2_{i32, i64})
2/9 Checking commit 9526239495d9 (tcg: Add INDEX_op_extract2_{i32,i64})
ERROR: spaces required around that ':' (ctx:VxE)
#108: FILE: tcg/optimize.c:1205:
+        CASE_OP_32_64(extract2):
                                ^

total: 1 errors, 0 warnings, 199 lines checked

Patch 2/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/9 Checking commit b51641ae9525 (tcg: Use extract2 in tcg_gen_shifti_i64)
4/9 Checking commit f11f5ed5da7f (tcg: Use extract2 in tcg_gen_deposit_{i32, i64})
5/9 Checking commit 0f7ffc52ad1b (tcg/i386: Support INDEX_op_extract2_{i32, i64})
ERROR: spaces required around that ':' (ctx:VxE)
#48: FILE: tcg/i386/tcg-target.inc.c:2591:
+    OP_32_64(extract2):
                       ^

total: 1 errors, 0 warnings, 51 lines checked

Patch 5/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/9 Checking commit 65cc26fced44 (tcg/arm: Support INDEX_op_extract2_i32)
7/9 Checking commit 197413642f19 (tcg/aarch64: Support INDEX_op_extract2_{i32, i64})
8/9 Checking commit d1fcb8aecd2f (target/arm: Use extract2 for EXTR)
9/9 Checking commit a5ab4c242ba6 (target/arm: Simplify BFXIL expansion)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190307144126.31847-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH 0/9] tcg: Add tcg_gen_extract2_{i32,i64}
Posted by David Hildenbrand 5 years ago
On 07.03.19 15:41, Richard Henderson wrote:
> The primary motivator here is usage within s390x,
> but (as with any good primitive) the opcode has
> applications outside that.

I am planning to send the next big part of vector instruction support
(Vector Integer Instructions) soon, that would make use of these patches.

-- 

Thanks,

David / dhildenb

Re: [Qemu-devel] [PATCH 0/9] tcg: Add tcg_gen_extract2_{i32,i64}
Posted by Richard Henderson 5 years ago
On 4/9/19 8:53 AM, David Hildenbrand wrote:
> On 07.03.19 15:41, Richard Henderson wrote:
>> The primary motivator here is usage within s390x,
>> but (as with any good primitive) the opcode has
>> applications outside that.
> 
> I am planning to send the next big part of vector instruction support
> (Vector Integer Instructions) soon, that would make use of these patches.

I'll be sure to get them into the first pull after 4.1 opens.


r~

Re: [Qemu-devel] [PATCH 0/9] tcg: Add tcg_gen_extract2_{i32,i64}
Posted by David Hildenbrand 5 years ago
On 09.04.19 21:02, Richard Henderson wrote:
> On 4/9/19 8:53 AM, David Hildenbrand wrote:
>> On 07.03.19 15:41, Richard Henderson wrote:
>>> The primary motivator here is usage within s390x,
>>> but (as with any good primitive) the opcode has
>>> applications outside that.
>>
>> I am planning to send the next big part of vector instruction support
>> (Vector Integer Instructions) soon, that would make use of these patches.
> 
> I'll be sure to get them into the first pull after 4.1 opens.
> 

Nice, I'll be posting the next series, referencing this series (might
take some days as the amount of instructions is getting out of hand).
Thanks!


-- 

Thanks,

David / dhildenb

Re: [Qemu-devel] [PATCH 0/9] tcg: Add tcg_gen_extract2_{i32,i64}
Posted by no-reply@patchew.org 5 years, 1 month ago
Patchew URL: https://patchew.org/QEMU/20190307144126.31847-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190307144126.31847-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH 0/9] tcg: Add tcg_gen_extract2_{i32,i64}

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190307144126.31847-1-richard.henderson@linaro.org -> patchew/20190307144126.31847-1-richard.henderson@linaro.org
Switched to a new branch 'test'
a7913aa23f target/arm: Simplify BFXIL expansion
39046cd16f target/arm: Use extract2 for EXTR
896fc67f40 tcg/aarch64: Support INDEX_op_extract2_{i32, i64}
a4d81fe0bf tcg/arm: Support INDEX_op_extract2_i32
e4d782a991 tcg/i386: Support INDEX_op_extract2_{i32, i64}
c614b0e300 tcg: Use extract2 in tcg_gen_deposit_{i32, i64}
c3d7ab05b4 tcg: Use extract2 in tcg_gen_shifti_i64
6ab392e136 tcg: Add INDEX_op_extract2_{i32,i64}
ed214d13db tcg: Implement tcg_gen_extract2_{i32, i64}

=== OUTPUT BEGIN ===
1/9 Checking commit ed214d13dbba (tcg: Implement tcg_gen_extract2_{i32, i64})
2/9 Checking commit 6ab392e1361b (tcg: Add INDEX_op_extract2_{i32,i64})
ERROR: spaces required around that ':' (ctx:VxE)
#109: FILE: tcg/optimize.c:1205:
+        CASE_OP_32_64(extract2):
                                ^

total: 1 errors, 0 warnings, 199 lines checked

Patch 2/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/9 Checking commit c3d7ab05b49c (tcg: Use extract2 in tcg_gen_shifti_i64)
4/9 Checking commit c614b0e30007 (tcg: Use extract2 in tcg_gen_deposit_{i32, i64})
5/9 Checking commit e4d782a99180 (tcg/i386: Support INDEX_op_extract2_{i32, i64})
ERROR: spaces required around that ':' (ctx:VxE)
#48: FILE: tcg/i386/tcg-target.inc.c:2591:
+    OP_32_64(extract2):
                       ^

total: 1 errors, 0 warnings, 51 lines checked

Patch 5/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/9 Checking commit a4d81fe0bf4b (tcg/arm: Support INDEX_op_extract2_i32)
7/9 Checking commit 896fc67f40fa (tcg/aarch64: Support INDEX_op_extract2_{i32, i64})
8/9 Checking commit 39046cd16fe9 (target/arm: Use extract2 for EXTR)
9/9 Checking commit a7913aa23f53 (target/arm: Simplify BFXIL expansion)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190307144126.31847-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH 0/9] tcg: Add tcg_gen_extract2_{i32,i64}
Posted by no-reply@patchew.org 5 years, 1 month ago
Patchew URL: https://patchew.org/QEMU/20190307144126.31847-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190307144126.31847-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH 0/9] tcg: Add tcg_gen_extract2_{i32,i64}

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190307144126.31847-1-richard.henderson@linaro.org -> patchew/20190307144126.31847-1-richard.henderson@linaro.org
Switched to a new branch 'test'
fd5c8534d8 target/arm: Simplify BFXIL expansion
ff97eff064 target/arm: Use extract2 for EXTR
14907a5cdf tcg/aarch64: Support INDEX_op_extract2_{i32, i64}
571ce62802 tcg/arm: Support INDEX_op_extract2_i32
47322e4359 tcg/i386: Support INDEX_op_extract2_{i32, i64}
71c243e0b1 tcg: Use extract2 in tcg_gen_deposit_{i32, i64}
7f01d6944a tcg: Use extract2 in tcg_gen_shifti_i64
6040cdd72c tcg: Add INDEX_op_extract2_{i32,i64}
fd5a59c277 tcg: Implement tcg_gen_extract2_{i32, i64}

=== OUTPUT BEGIN ===
1/9 Checking commit fd5a59c277d1 (tcg: Implement tcg_gen_extract2_{i32, i64})
2/9 Checking commit 6040cdd72c14 (tcg: Add INDEX_op_extract2_{i32,i64})
ERROR: spaces required around that ':' (ctx:VxE)
#109: FILE: tcg/optimize.c:1205:
+        CASE_OP_32_64(extract2):
                                ^

total: 1 errors, 0 warnings, 199 lines checked

Patch 2/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/9 Checking commit 7f01d6944a7a (tcg: Use extract2 in tcg_gen_shifti_i64)
4/9 Checking commit 71c243e0b1d7 (tcg: Use extract2 in tcg_gen_deposit_{i32, i64})
5/9 Checking commit 47322e435956 (tcg/i386: Support INDEX_op_extract2_{i32, i64})
ERROR: spaces required around that ':' (ctx:VxE)
#48: FILE: tcg/i386/tcg-target.inc.c:2591:
+    OP_32_64(extract2):
                       ^

total: 1 errors, 0 warnings, 51 lines checked

Patch 5/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/9 Checking commit 571ce62802b8 (tcg/arm: Support INDEX_op_extract2_i32)
7/9 Checking commit 14907a5cdf13 (tcg/aarch64: Support INDEX_op_extract2_{i32, i64})
8/9 Checking commit ff97eff06477 (target/arm: Use extract2 for EXTR)
9/9 Checking commit fd5c8534d847 (target/arm: Simplify BFXIL expansion)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190307144126.31847-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH 0/9] tcg: Add tcg_gen_extract2_{i32,i64}
Posted by no-reply@patchew.org 5 years, 1 month ago
Patchew URL: https://patchew.org/QEMU/20190307144126.31847-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190307144126.31847-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH 0/9] tcg: Add tcg_gen_extract2_{i32,i64}

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190307144126.31847-1-richard.henderson@linaro.org -> patchew/20190307144126.31847-1-richard.henderson@linaro.org
Switched to a new branch 'test'
3898cccde9 target/arm: Simplify BFXIL expansion
2ada5d316c target/arm: Use extract2 for EXTR
49b4870227 tcg/aarch64: Support INDEX_op_extract2_{i32, i64}
92cd638e55 tcg/arm: Support INDEX_op_extract2_i32
9b93a7bdeb tcg/i386: Support INDEX_op_extract2_{i32, i64}
d5d7cc7750 tcg: Use extract2 in tcg_gen_deposit_{i32, i64}
67a6356446 tcg: Use extract2 in tcg_gen_shifti_i64
17714e10e2 tcg: Add INDEX_op_extract2_{i32,i64}
c7936c5b94 tcg: Implement tcg_gen_extract2_{i32, i64}

=== OUTPUT BEGIN ===
1/9 Checking commit c7936c5b9404 (tcg: Implement tcg_gen_extract2_{i32, i64})
2/9 Checking commit 17714e10e223 (tcg: Add INDEX_op_extract2_{i32,i64})
ERROR: spaces required around that ':' (ctx:VxE)
#109: FILE: tcg/optimize.c:1205:
+        CASE_OP_32_64(extract2):
                                ^

total: 1 errors, 0 warnings, 199 lines checked

Patch 2/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/9 Checking commit 67a63564468a (tcg: Use extract2 in tcg_gen_shifti_i64)
4/9 Checking commit d5d7cc7750e3 (tcg: Use extract2 in tcg_gen_deposit_{i32, i64})
5/9 Checking commit 9b93a7bdebcd (tcg/i386: Support INDEX_op_extract2_{i32, i64})
ERROR: spaces required around that ':' (ctx:VxE)
#48: FILE: tcg/i386/tcg-target.inc.c:2591:
+    OP_32_64(extract2):
                       ^

total: 1 errors, 0 warnings, 51 lines checked

Patch 5/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/9 Checking commit 92cd638e55c0 (tcg/arm: Support INDEX_op_extract2_i32)
7/9 Checking commit 49b4870227e8 (tcg/aarch64: Support INDEX_op_extract2_{i32, i64})
8/9 Checking commit 2ada5d316ccb (target/arm: Use extract2 for EXTR)
9/9 Checking commit 3898cccde939 (target/arm: Simplify BFXIL expansion)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190307144126.31847-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH 0/9] tcg: Add tcg_gen_extract2_{i32,i64}
Posted by no-reply@patchew.org 5 years, 1 month ago
Patchew URL: https://patchew.org/QEMU/20190307144126.31847-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190307144126.31847-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH 0/9] tcg: Add tcg_gen_extract2_{i32,i64}

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190307144126.31847-1-richard.henderson@linaro.org -> patchew/20190307144126.31847-1-richard.henderson@linaro.org
Switched to a new branch 'test'
3292d7b43c target/arm: Simplify BFXIL expansion
ff6ac2e56f target/arm: Use extract2 for EXTR
cf32404712 tcg/aarch64: Support INDEX_op_extract2_{i32, i64}
7bb2bf5b2f tcg/arm: Support INDEX_op_extract2_i32
77cd89c565 tcg/i386: Support INDEX_op_extract2_{i32, i64}
c74535f601 tcg: Use extract2 in tcg_gen_deposit_{i32, i64}
bf3e4eb1b5 tcg: Use extract2 in tcg_gen_shifti_i64
7880a5be65 tcg: Add INDEX_op_extract2_{i32,i64}
6f428742fe tcg: Implement tcg_gen_extract2_{i32, i64}

=== OUTPUT BEGIN ===
1/9 Checking commit 6f428742fe41 (tcg: Implement tcg_gen_extract2_{i32, i64})
2/9 Checking commit 7880a5be6520 (tcg: Add INDEX_op_extract2_{i32,i64})
ERROR: spaces required around that ':' (ctx:VxE)
#109: FILE: tcg/optimize.c:1205:
+        CASE_OP_32_64(extract2):
                                ^

total: 1 errors, 0 warnings, 199 lines checked

Patch 2/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/9 Checking commit bf3e4eb1b5b0 (tcg: Use extract2 in tcg_gen_shifti_i64)
4/9 Checking commit c74535f601dc (tcg: Use extract2 in tcg_gen_deposit_{i32, i64})
5/9 Checking commit 77cd89c565b5 (tcg/i386: Support INDEX_op_extract2_{i32, i64})
ERROR: spaces required around that ':' (ctx:VxE)
#48: FILE: tcg/i386/tcg-target.inc.c:2591:
+    OP_32_64(extract2):
                       ^

total: 1 errors, 0 warnings, 51 lines checked

Patch 5/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/9 Checking commit 7bb2bf5b2fa4 (tcg/arm: Support INDEX_op_extract2_i32)
7/9 Checking commit cf324047128d (tcg/aarch64: Support INDEX_op_extract2_{i32, i64})
8/9 Checking commit ff6ac2e56f23 (target/arm: Use extract2 for EXTR)
9/9 Checking commit 3292d7b43c8b (target/arm: Simplify BFXIL expansion)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190307144126.31847-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH 0/9] tcg: Add tcg_gen_extract2_{i32,i64}
Posted by no-reply@patchew.org 5 years, 1 month ago
Patchew URL: https://patchew.org/QEMU/20190307144126.31847-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190307144126.31847-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH 0/9] tcg: Add tcg_gen_extract2_{i32,i64}

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190307144126.31847-1-richard.henderson@linaro.org -> patchew/20190307144126.31847-1-richard.henderson@linaro.org
Switched to a new branch 'test'
172cb1c264 target/arm: Simplify BFXIL expansion
56c87bc882 target/arm: Use extract2 for EXTR
ea8806e468 tcg/aarch64: Support INDEX_op_extract2_{i32, i64}
691d675f4b tcg/arm: Support INDEX_op_extract2_i32
5ec13c83f2 tcg/i386: Support INDEX_op_extract2_{i32, i64}
3c7a3f7506 tcg: Use extract2 in tcg_gen_deposit_{i32, i64}
d3c1df2016 tcg: Use extract2 in tcg_gen_shifti_i64
71cd157f8a tcg: Add INDEX_op_extract2_{i32,i64}
6274d657b3 tcg: Implement tcg_gen_extract2_{i32, i64}

=== OUTPUT BEGIN ===
1/9 Checking commit 6274d657b3ba (tcg: Implement tcg_gen_extract2_{i32, i64})
2/9 Checking commit 71cd157f8a4c (tcg: Add INDEX_op_extract2_{i32,i64})
ERROR: spaces required around that ':' (ctx:VxE)
#109: FILE: tcg/optimize.c:1205:
+        CASE_OP_32_64(extract2):
                                ^

total: 1 errors, 0 warnings, 199 lines checked

Patch 2/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/9 Checking commit d3c1df201649 (tcg: Use extract2 in tcg_gen_shifti_i64)
4/9 Checking commit 3c7a3f75068b (tcg: Use extract2 in tcg_gen_deposit_{i32, i64})
5/9 Checking commit 5ec13c83f2f5 (tcg/i386: Support INDEX_op_extract2_{i32, i64})
ERROR: spaces required around that ':' (ctx:VxE)
#48: FILE: tcg/i386/tcg-target.inc.c:2591:
+    OP_32_64(extract2):
                       ^

total: 1 errors, 0 warnings, 51 lines checked

Patch 5/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/9 Checking commit 691d675f4b74 (tcg/arm: Support INDEX_op_extract2_i32)
7/9 Checking commit ea8806e468a7 (tcg/aarch64: Support INDEX_op_extract2_{i32, i64})
8/9 Checking commit 56c87bc882dc (target/arm: Use extract2 for EXTR)
9/9 Checking commit 172cb1c264ae (target/arm: Simplify BFXIL expansion)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190307144126.31847-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com