[v6] CODING_STYLE: trivial update

[Qemu-devel] [PATCH v6 0/2] CODING_STYLE: trivial update

Wei Yang posted 2 patches 5 years, 2 months ago

Diff against v1 v2 v3 v4 v5
Download series mbox

Test asan passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu failed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190304071631.27567-1-richardw.yang@linux.intel.com

CODING_STYLE | 47 +++++++++++++++++++++++++++++++++++++++++++----
1 file changed, 43 insertions(+), 4 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v6 0/2] CODING_STYLE: trivial update

Posted by Wei Yang 5 years, 2 months ago

The first one is suggested by Igor Mammedov to provide rule for multiline
code.

The second is a trivial fix to make example code all indented with 4 spaces.

v6:
  * add ) for last example of function
v5:
  * mostly address function variants
v4:
  * one exception case for function
v3:
  * fix typo in both changelog and example
v2:
  * adjust Patch 1 as suggested by Eric

Wei Yang (2):
  CODING_STYLE: specify the indent rule for multiline code
  CODING_STYLE: indent example code as all others

 CODING_STYLE | 47 +++++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 43 insertions(+), 4 deletions(-)

-- 
2.19.1

Re: [Qemu-devel] [PATCH v6 0/2] CODING_STYLE: trivial update

Posted by Stefano Garzarella 5 years, 2 months ago

On Mon, Mar 04, 2019 at 03:16:29PM +0800, Wei Yang wrote:
> The first one is suggested by Igor Mammedov to provide rule for multiline
> code.
> 
> The second is a trivial fix to make example code all indented with 4 spaces.
> 
> v6:
>   * add ) for last example of function
> v5:
>   * mostly address function variants
> v4:
>   * one exception case for function
> v3:
>   * fix typo in both changelog and example
> v2:
>   * adjust Patch 1 as suggested by Eric
> 
> Wei Yang (2):
>   CODING_STYLE: specify the indent rule for multiline code
>   CODING_STYLE: indent example code as all others
> 
>  CODING_STYLE | 47 +++++++++++++++++++++++++++++++++++++++++++----
>  1 file changed, 43 insertions(+), 4 deletions(-)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

Thanks,
Stefano

Re: [Qemu-devel] [PATCH v6 0/2] CODING_STYLE: trivial update

Posted by Wei Yang 5 years, 1 month ago

Is this patch set picked up by someone?

On Mon, Mar 04, 2019 at 03:16:29PM +0800, Wei Yang wrote:
>The first one is suggested by Igor Mammedov to provide rule for multiline
>code.
>
>The second is a trivial fix to make example code all indented with 4 spaces.
>
>v6:
>  * add ) for last example of function
>v5:
>  * mostly address function variants
>v4:
>  * one exception case for function
>v3:
>  * fix typo in both changelog and example
>v2:
>  * adjust Patch 1 as suggested by Eric
>
>Wei Yang (2):
>  CODING_STYLE: specify the indent rule for multiline code
>  CODING_STYLE: indent example code as all others
>
> CODING_STYLE | 47 +++++++++++++++++++++++++++++++++++++++++++----
> 1 file changed, 43 insertions(+), 4 deletions(-)
>
>-- 
>2.19.1

-- 
Wei Yang
Help you, Help me