1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH] linux-user: Nicer strace output of chroot() syscall

Helge Deller posted 1 patch 6 years, 8 months ago
Test docker-mingw@fedora passed
Test asan passed
Test docker-clang@ubuntu passed
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190227191115.GA20163@ls3530.dellerweb.de
Maintainers: Riku Voipio <riku.voipio@iki.fi>, Laurent Vivier <laurent@vivier.eu>
[Qemu-devel] [PATCH] linux-user: Nicer strace output of chroot() syscall
Posted by Helge Deller 6 years, 8 months ago 
Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/linux-user/strace.c b/linux-user/strace.c
index 7318392e57..6f72a74c09 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -1235,6 +1235,18 @@ print_chdir(const struct syscallname *name,
 }
 #endif
 
+#ifdef TARGET_NR_chroot
+static void
+print_chroot(const struct syscallname *name,
+    abi_long arg0, abi_long arg1, abi_long arg2,
+    abi_long arg3, abi_long arg4, abi_long arg5)
+{
+    print_syscall_prologue(name);
+    print_string(arg0, 1);
+    print_syscall_epilogue(name);
+}
+#endif
+
 #ifdef TARGET_NR_chmod
 static void
 print_chmod(const struct syscallname *name,
diff --git a/linux-user/strace.list b/linux-user/strace.list
index ff8bb19f5f..db21ce4177 100644
--- a/linux-user/strace.list
+++ b/linux-user/strace.list
@@ -77,7 +77,7 @@
 { TARGET_NR_chown32, "chown32" , NULL, NULL, NULL },
 #endif
 #ifdef TARGET_NR_chroot
-{ TARGET_NR_chroot, "chroot" , NULL, NULL, NULL },
+{ TARGET_NR_chroot, "chroot" , NULL, print_chroot, NULL },
 #endif
 #ifdef TARGET_NR_clock_adjtime
 { TARGET_NR_clock_adjtime, "clock_adjtime" , NULL, print_clock_adjtime, NULL },
Re: [Qemu-devel] [PATCH] linux-user: Nicer strace output of chroot() syscall
Posted by Laurent Vivier 6 years, 8 months ago 
On 27/02/2019 20:11, Helge Deller wrote:
> Signed-off-by: Helge Deller <deller@gmx.de>
> 
> diff --git a/linux-user/strace.c b/linux-user/strace.c
> index 7318392e57..6f72a74c09 100644
> --- a/linux-user/strace.c
> +++ b/linux-user/strace.c
> @@ -1235,6 +1235,18 @@ print_chdir(const struct syscallname *name,
>  }
>  #endif
>  
> +#ifdef TARGET_NR_chroot
> +static void
> +print_chroot(const struct syscallname *name,
> +    abi_long arg0, abi_long arg1, abi_long arg2,
> +    abi_long arg3, abi_long arg4, abi_long arg5)
> +{
> +    print_syscall_prologue(name);
> +    print_string(arg0, 1);
> +    print_syscall_epilogue(name);
> +}
> +#endif
> +
>  #ifdef TARGET_NR_chmod
>  static void
>  print_chmod(const struct syscallname *name,
> diff --git a/linux-user/strace.list b/linux-user/strace.list
> index ff8bb19f5f..db21ce4177 100644
> --- a/linux-user/strace.list
> +++ b/linux-user/strace.list
> @@ -77,7 +77,7 @@
>  { TARGET_NR_chown32, "chown32" , NULL, NULL, NULL },
>  #endif
>  #ifdef TARGET_NR_chroot
> -{ TARGET_NR_chroot, "chroot" , NULL, NULL, NULL },
> +{ TARGET_NR_chroot, "chroot" , NULL, print_chroot, NULL },
>  #endif
>  #ifdef TARGET_NR_clock_adjtime
>  { TARGET_NR_clock_adjtime, "clock_adjtime" , NULL, print_clock_adjtime, NULL },
> 

Applied to my linux-user branch.

Thanks,
Laurent
Re: [Qemu-devel] [PATCH] linux-user: Nicer strace output of chroot() syscall
Posted by Laurent Vivier 6 years, 8 months ago 
On 27/02/2019 20:11, Helge Deller wrote:
> Signed-off-by: Helge Deller <deller@gmx.de>
> 
> diff --git a/linux-user/strace.c b/linux-user/strace.c
> index 7318392e57..6f72a74c09 100644
> --- a/linux-user/strace.c
> +++ b/linux-user/strace.c
> @@ -1235,6 +1235,18 @@ print_chdir(const struct syscallname *name,
>  }
>  #endif
>  
> +#ifdef TARGET_NR_chroot
> +static void
> +print_chroot(const struct syscallname *name,
> +    abi_long arg0, abi_long arg1, abi_long arg2,
> +    abi_long arg3, abi_long arg4, abi_long arg5)
> +{
> +    print_syscall_prologue(name);
> +    print_string(arg0, 1);
> +    print_syscall_epilogue(name);
> +}
> +#endif
> +
>  #ifdef TARGET_NR_chmod
>  static void
>  print_chmod(const struct syscallname *name,
> diff --git a/linux-user/strace.list b/linux-user/strace.list
> index ff8bb19f5f..db21ce4177 100644
> --- a/linux-user/strace.list
> +++ b/linux-user/strace.list
> @@ -77,7 +77,7 @@
>  { TARGET_NR_chown32, "chown32" , NULL, NULL, NULL },
>  #endif
>  #ifdef TARGET_NR_chroot
> -{ TARGET_NR_chroot, "chroot" , NULL, NULL, NULL },
> +{ TARGET_NR_chroot, "chroot" , NULL, print_chroot, NULL },
>  #endif
>  #ifdef TARGET_NR_clock_adjtime
>  { TARGET_NR_clock_adjtime, "clock_adjtime" , NULL, print_clock_adjtime, NULL },
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.