[Qemu-devel] [PATCH v6 3/3] nbd: fix outdated qapi docs syntax for tls-creds

Daniel P. Berrangé posted 3 patches 6 years, 8 months ago
Maintainers: Eric Blake <eblake@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Markus Armbruster <armbru@redhat.com>, Max Reitz <mreitz@redhat.com>
[Qemu-devel] [PATCH v6 3/3] nbd: fix outdated qapi docs syntax for tls-creds
Posted by Daniel P. Berrangé 6 years, 8 months ago
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 qapi/block.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qapi/block.json b/qapi/block.json
index 79623088e7..145c268bb6 100644
--- a/qapi/block.json
+++ b/qapi/block.json
@@ -224,7 +224,7 @@
 # QEMU instance could refer to them as "nbd:HOST:PORT:exportname=NAME".
 #
 # @addr: Address on which to listen.
-# @tls-creds: (optional) ID of the TLS credentials object. Since 2.6
+# @tls-creds: ID of the TLS credentials object (since 2.6).
 # @tls-authz: ID of the QAuthZ authorization object used to validate
 #             the client's x509 distinguished name. This object is
 #             is only resolved at time of use, so can be deleted and
-- 
2.20.1


Re: [Qemu-devel] [PATCH v6 3/3] nbd: fix outdated qapi docs syntax for tls-creds
Posted by Eric Blake 6 years, 8 months ago
On 2/27/19 10:20 AM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  qapi/block.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qapi/block.json b/qapi/block.json
> index 79623088e7..145c268bb6 100644
> --- a/qapi/block.json
> +++ b/qapi/block.json
> @@ -224,7 +224,7 @@
>  # QEMU instance could refer to them as "nbd:HOST:PORT:exportname=NAME".
>  #
>  # @addr: Address on which to listen.
> -# @tls-creds: (optional) ID of the TLS credentials object. Since 2.6
> +# @tls-creds: ID of the TLS credentials object (since 2.6).

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org