[Qemu-devel] [PATCH v5 0/5] qcow2 check improvements part I

Vladimir Sementsov-Ogievskiy posted 5 patches 6 years, 8 months ago
Test asan passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu failed
Test checkpatch passed
Failed in applying to current master (apply log)
block/qcow2-refcount.c     | 80 ++++++++++++++++++++++++--------------
tests/qemu-iotests/138     | 12 +++---
tests/qemu-iotests/138.out |  5 ++-
3 files changed, 59 insertions(+), 38 deletions(-)
[Qemu-devel] [PATCH v5 0/5] qcow2 check improvements part I
Posted by Vladimir Sementsov-Ogievskiy 6 years, 8 months ago
Hi all!

v5:
01: - add Max's r-b
02: - s/it's/it/ in comment in block/qcow2-refcount.c [Max]
    - fix comment style accordingly to updated checkpatch
      ('/*' on separate line)
    - add Max's r-b
04: - add Max's r-b
05: - refactor change in check_oflag_copied, to increase
      res->corruptions separately from l2_dirty variable [Max]

v4 was derived from "[PATCH v3 0/8] qcow2 check improvements"
(https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02284.html)

v4:
Some patches are new, some patches are not included and are postponed to
part II.

01,03 - unchanged
02: handle broken iotest
04-05: new

Vladimir Sementsov-Ogievskiy (5):
  qcow2-refcount: fix check_oflag_copied
  qcow2-refcount: avoid eating RAM
  qcow2-refcount: check_refcounts_l2: reduce ignored overlaps
  qcow2-refcount: check_refcounts_l2: don't count fixed cluster as
    allocated
  qcow2-refcount: don't mask corruptions under internal errors

 block/qcow2-refcount.c     | 80 ++++++++++++++++++++++++--------------
 tests/qemu-iotests/138     | 12 +++---
 tests/qemu-iotests/138.out |  5 ++-
 3 files changed, 59 insertions(+), 38 deletions(-)

-- 
2.18.0


Re: [Qemu-devel] [PATCH v5 0/5] qcow2 check improvements part I
Posted by Max Reitz 6 years, 7 months ago
On 27.02.19 14:14, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
> 
> v5:
> 01: - add Max's r-b
> 02: - s/it's/it/ in comment in block/qcow2-refcount.c [Max]
>     - fix comment style accordingly to updated checkpatch
>       ('/*' on separate line)
>     - add Max's r-b
> 04: - add Max's r-b
> 05: - refactor change in check_oflag_copied, to increase
>       res->corruptions separately from l2_dirty variable [Max]
> 
> v4 was derived from "[PATCH v3 0/8] qcow2 check improvements"
> (https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02284.html)
> 
> v4:
> Some patches are new, some patches are not included and are postponed to
> part II.
> 
> 01,03 - unchanged
> 02: handle broken iotest
> 04-05: new
> 
> Vladimir Sementsov-Ogievskiy (5):
>   qcow2-refcount: fix check_oflag_copied
>   qcow2-refcount: avoid eating RAM
>   qcow2-refcount: check_refcounts_l2: reduce ignored overlaps
>   qcow2-refcount: check_refcounts_l2: don't count fixed cluster as
>     allocated
>   qcow2-refcount: don't mask corruptions under internal errors
> 
>  block/qcow2-refcount.c     | 80 ++++++++++++++++++++++++--------------
>  tests/qemu-iotests/138     | 12 +++---
>  tests/qemu-iotests/138.out |  5 ++-
>  3 files changed, 59 insertions(+), 38 deletions(-)

Thanks, resolved the contextual conflicts that this series has with
Kevin’s data-file series, and applied it to my block-next branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block-next

Max