[Qemu-devel] [PATCH v2 0/7] s390x/tcg: Cleanups and refactorings for vector instructions

David Hildenbrand posted 7 patches 6 years, 8 months ago
Test asan passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu failed
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190225200318.16102-1-david@redhat.com
Maintainers: Cornelia Huck <cohuck@redhat.com>, Richard Henderson <rth@twiddle.net>, David Hildenbrand <david@redhat.com>
target/s390x/cc_helper.c     |  8 +++
target/s390x/helper.c        |  1 +
target/s390x/insn-data.def   |  4 ++
target/s390x/insn-format.def |  2 +-
target/s390x/internal.h      |  1 +
target/s390x/translate.c     | 94 +++++++++++++++++++++++++-----------
6 files changed, 80 insertions(+), 30 deletions(-)
[Qemu-devel] [PATCH v2 0/7] s390x/tcg: Cleanups and refactorings for vector instructions
Posted by David Hildenbrand 6 years, 8 months ago
Before we start with the real magic, some more cleanups and refactorings.
This series does not depend on other patches not yet in master.

Also add a variant of "LOAD LENGTHENED" that is used along with
vector instructions in linux (HFP instructions that can be used without
HFP  ). Implement "LOAD COUNT TO BLOCK BOUNDARY", introduced with
vector facility but not operating on vectors.

v1 -> v2:
- "s390x/tcg: Simplify disassembler operands initialization"
-- s/simply/simplify/ in description
- "s390x/tcg: Implement LOAD COUNT TO BLOCK BOUNDARY"
-- Use bit magic without a helper to calculate the count

David Hildenbrand (7):
  s390x/tcg: RXE has an optional M3 field
  s390x/tcg: Simplify disassembler operands initialization
  s390x/tcg: Clarify terminology in vec_reg_offset()
  s390x/tcg: Factor out vec_full_reg_offset()
  s390x/tcg: Factor out gen_addi_and_wrap_i64() from get_address()
  s390x/tcg: Implement LOAD LENGTHENED short HFP to long HFP
  s390x/tcg: Implement LOAD COUNT TO BLOCK BOUNDARY

 target/s390x/cc_helper.c     |  8 +++
 target/s390x/helper.c        |  1 +
 target/s390x/insn-data.def   |  4 ++
 target/s390x/insn-format.def |  2 +-
 target/s390x/internal.h      |  1 +
 target/s390x/translate.c     | 94 +++++++++++++++++++++++++-----------
 6 files changed, 80 insertions(+), 30 deletions(-)

-- 
2.17.2


Re: [Qemu-devel] [PATCH v2 0/7] s390x/tcg: Cleanups and refactorings for vector instructions
Posted by David Hildenbrand 6 years, 8 months ago
On 25.02.19 21:03, David Hildenbrand wrote:
> Before we start with the real magic, some more cleanups and refactorings.
> This series does not depend on other patches not yet in master.
> 
> Also add a variant of "LOAD LENGTHENED" that is used along with
> vector instructions in linux (HFP instructions that can be used without
> HFP  ). Implement "LOAD COUNT TO BLOCK BOUNDARY", introduced with
> vector facility but not operating on vectors.
> 
> v1 -> v2:
> - "s390x/tcg: Simplify disassembler operands initialization"
> -- s/simply/simplify/ in description
> - "s390x/tcg: Implement LOAD COUNT TO BLOCK BOUNDARY"
> -- Use bit magic without a helper to calculate the count

Oh, and dropped the "inline" from "s390x/tcg: Factor out
gen_addi_and_wrap_i64() from get_address()"

> 
> David Hildenbrand (7):
>   s390x/tcg: RXE has an optional M3 field
>   s390x/tcg: Simplify disassembler operands initialization
>   s390x/tcg: Clarify terminology in vec_reg_offset()
>   s390x/tcg: Factor out vec_full_reg_offset()
>   s390x/tcg: Factor out gen_addi_and_wrap_i64() from get_address()
>   s390x/tcg: Implement LOAD LENGTHENED short HFP to long HFP
>   s390x/tcg: Implement LOAD COUNT TO BLOCK BOUNDARY
> 
>  target/s390x/cc_helper.c     |  8 +++
>  target/s390x/helper.c        |  1 +
>  target/s390x/insn-data.def   |  4 ++
>  target/s390x/insn-format.def |  2 +-
>  target/s390x/internal.h      |  1 +
>  target/s390x/translate.c     | 94 +++++++++++++++++++++++++-----------
>  6 files changed, 80 insertions(+), 30 deletions(-)
> 


-- 

Thanks,

David / dhildenb

Re: [Qemu-devel] [PATCH v2 0/7] s390x/tcg: Cleanups and refactorings for vector instructions
Posted by Cornelia Huck 6 years, 8 months ago
On Mon, 25 Feb 2019 21:03:11 +0100
David Hildenbrand <david@redhat.com> wrote:

> Before we start with the real magic, some more cleanups and refactorings.
> This series does not depend on other patches not yet in master.
> 
> Also add a variant of "LOAD LENGTHENED" that is used along with
> vector instructions in linux (HFP instructions that can be used without
> HFP  ). Implement "LOAD COUNT TO BLOCK BOUNDARY", introduced with
> vector facility but not operating on vectors.
> 
> v1 -> v2:
> - "s390x/tcg: Simplify disassembler operands initialization"
> -- s/simply/simplify/ in description
> - "s390x/tcg: Implement LOAD COUNT TO BLOCK BOUNDARY"
> -- Use bit magic without a helper to calculate the count
> 
> David Hildenbrand (7):
>   s390x/tcg: RXE has an optional M3 field
>   s390x/tcg: Simplify disassembler operands initialization
>   s390x/tcg: Clarify terminology in vec_reg_offset()
>   s390x/tcg: Factor out vec_full_reg_offset()
>   s390x/tcg: Factor out gen_addi_and_wrap_i64() from get_address()
>   s390x/tcg: Implement LOAD LENGTHENED short HFP to long HFP
>   s390x/tcg: Implement LOAD COUNT TO BLOCK BOUNDARY
> 
>  target/s390x/cc_helper.c     |  8 +++
>  target/s390x/helper.c        |  1 +
>  target/s390x/insn-data.def   |  4 ++
>  target/s390x/insn-format.def |  2 +-
>  target/s390x/internal.h      |  1 +
>  target/s390x/translate.c     | 94 +++++++++++++++++++++++++-----------
>  6 files changed, 80 insertions(+), 30 deletions(-)
> 

Thanks, applied.