iotests: use -M accel=qtest in 238

[Qemu-devel] [PATCH v3] iotests: use -M accel=qtest in 238

Posted by Stefan Hajnoczi 6 years, 8 months ago

Test 238 does not require the kvm accelerator.  tcg and qtest work too.

Use qtest since it's always built in while kvm and tcg are not.

Suggested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 tests/qemu-iotests/238 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/238 b/tests/qemu-iotests/238
index f81ee1112f..c7f8d9422b 100755
--- a/tests/qemu-iotests/238
+++ b/tests/qemu-iotests/238
@@ -33,7 +33,7 @@ else:
     virtio_scsi_device = 'virtio-scsi-pci'
 
 vm = QEMUMachine(iotests.qemu_prog)
-vm.add_args('-machine', 'accel=kvm')
+vm.add_args('-machine', 'accel=qtest')
 vm.launch()
 
 log(vm.qmp('blockdev-add', node_name='hd0', driver='null-co'))
-- 
2.20.1

Re: [Qemu-devel] [PATCH v3] iotests: use -M accel=qtest in 238

Posted by Thomas Huth 6 years, 8 months ago

On 25/02/2019 17.18, Stefan Hajnoczi wrote:
> Test 238 does not require the kvm accelerator.  tcg and qtest work too.
> 
> Use qtest since it's always built in while kvm and tcg are not.
> 
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  tests/qemu-iotests/238 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/238 b/tests/qemu-iotests/238
> index f81ee1112f..c7f8d9422b 100755
> --- a/tests/qemu-iotests/238
> +++ b/tests/qemu-iotests/238
> @@ -33,7 +33,7 @@ else:
>      virtio_scsi_device = 'virtio-scsi-pci'
>  
>  vm = QEMUMachine(iotests.qemu_prog)
> -vm.add_args('-machine', 'accel=kvm')
> +vm.add_args('-machine', 'accel=qtest')
>  vm.launch()
>  
>  log(vm.qmp('blockdev-add', node_name='hd0', driver='null-co'))
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [PATCH v3] iotests: use -M accel=qtest in 238

Posted by Kevin Wolf 6 years, 8 months ago

Am 25.02.2019 um 17:18 hat Stefan Hajnoczi geschrieben:
> Test 238 does not require the kvm accelerator.  tcg and qtest work too.
> 
> Use qtest since it's always built in while kvm and tcg are not.
> 
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  tests/qemu-iotests/238 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/238 b/tests/qemu-iotests/238
> index f81ee1112f..c7f8d9422b 100755
> --- a/tests/qemu-iotests/238
> +++ b/tests/qemu-iotests/238
> @@ -33,7 +33,7 @@ else:
>      virtio_scsi_device = 'virtio-scsi-pci'
>  
>  vm = QEMUMachine(iotests.qemu_prog)
> -vm.add_args('-machine', 'accel=kvm')
> +vm.add_args('-machine', 'accel=qtest')
>  vm.launch()

Why not use iotests.VM? This would be a qtest machine automatically.

Kevin

Re: [Qemu-devel] [Qemu-block] [PATCH v3] iotests: use -M accel=qtest in 238

Posted by Stefan Hajnoczi 6 years, 8 months ago

On Tue, Feb 26, 2019 at 09:49:59AM +0100, Kevin Wolf wrote:
> Am 25.02.2019 um 17:18 hat Stefan Hajnoczi geschrieben:
> > Test 238 does not require the kvm accelerator.  tcg and qtest work too.
> > 
> > Use qtest since it's always built in while kvm and tcg are not.
> > 
> > Suggested-by: Thomas Huth <thuth@redhat.com>
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> >  tests/qemu-iotests/238 | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/qemu-iotests/238 b/tests/qemu-iotests/238
> > index f81ee1112f..c7f8d9422b 100755
> > --- a/tests/qemu-iotests/238
> > +++ b/tests/qemu-iotests/238
> > @@ -33,7 +33,7 @@ else:
> >      virtio_scsi_device = 'virtio-scsi-pci'
> >  
> >  vm = QEMUMachine(iotests.qemu_prog)
> > -vm.add_args('-machine', 'accel=kvm')
> > +vm.add_args('-machine', 'accel=qtest')
> >  vm.launch()
> 
> Why not use iotests.VM? This would be a qtest machine automatically.

Good idea, will fix in v4.

Stefan