block: fix graph modification

[Qemu-devel] [PATCH 0/3] block: fix graph modification

Vladimir Sementsov-Ogievskiy posted 3 patches 6 years, 8 months ago

Download series mbox

Test asan passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu failed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190223192041.289782-1-vsementsov@virtuozzo.com

Maintainers: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>

include/block/block_int.h   |   5 +
block.c                     |  70 +++++++++++--
tests/test-bdrv-graph-mod.c | 198 ++++++++++++++++++++++++++++++++++++
tests/Makefile.include      |   2 +
4 files changed, 268 insertions(+), 7 deletions(-)
create mode 100644 tests/test-bdrv-graph-mod.c

Expand all Fold all

[Qemu-devel] [PATCH 0/3] block: fix graph modification

Posted by Vladimir Sementsov-Ogievskiy 6 years, 8 months ago

Hi all.

I've found two problems during my developing of backup-top filter.
The first one was already discussed in context of backup-top series,
so, here is patch 01 taken from it, previously it was
03 of [PATCH v5 00/11] backup-top filter driver for backup
(https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg06218.html)
so, here it is marked v6, and it was changed a lot:
 v6: rewrite using GHashTable and GQueue for efficient BFS.

02 is a new fix of bug I've found today, and 03 is a test for both
fixed bugs.

Vladimir Sementsov-Ogievskiy (3):
  block: improve should_update_child
  block: fix bdrv_check_perm for non-tree subgraph
  tests: add test-bdrv-graph-mod

 include/block/block_int.h   |   5 +
 block.c                     |  70 +++++++++++--
 tests/test-bdrv-graph-mod.c | 198 ++++++++++++++++++++++++++++++++++++
 tests/Makefile.include      |   2 +
 4 files changed, 268 insertions(+), 7 deletions(-)
 create mode 100644 tests/test-bdrv-graph-mod.c

-- 
2.18.0

Re: [Qemu-devel] [PATCH 0/3] block: fix graph modification

Posted by Kevin Wolf 6 years, 8 months ago

Am 23.02.2019 um 20:20 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Hi all.
> 
> I've found two problems during my developing of backup-top filter.
> The first one was already discussed in context of backup-top series,
> so, here is patch 01 taken from it, previously it was
> 03 of [PATCH v5 00/11] backup-top filter driver for backup
> (https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg06218.html)
> so, here it is marked v6, and it was changed a lot:
>  v6: rewrite using GHashTable and GQueue for efficient BFS.
> 
> 02 is a new fix of bug I've found today, and 03 is a test for both
> fixed bugs.

Thanks, applied to the block branch.

Kevin