The following changes since commit 8eb29f1bf5a974dc4c11d2d1f5e7c7f7a62be116:

  Merge remote-tracking branch 'remotes/awilliam/tags/vfio-updates-20190221.0' into staging (2019-02-22 15:48:04 +0000)

are available in the Git repository at:

  https://github.com/marcel-apf/qemu tags/rdma-pull-request

for you to fetch changes up to e1038e22f7b3ade2e46cf168fa7486414c424e94:

  hw/rdma: another clang compilation fix (2019-02-23 15:28:25 +0200)

----------------------------------------------------------------
RDMA queue

 * Another Clang compilation fix
 * Various fixes for the pvrdma device

----------------------------------------------------------------
Marcel Apfelbaum (1):
      hw/rdma: another clang compilation fix

Yuval Shaia (10):
      contrib/rdmacm-mux: Fix out-of-bounds risk
      hw/rdma: Switch to generic error reporting way
      hw/rdma: Introduce protected qlist
      hw/rdma: Protect against concurrent execution of poll_cq
      {monitor, hw/pvrdma}: Expose device internals via monitor interface
      hw/rdma: Free all MAD receive buffers when device is closed
      hw/rdma: Free all receive buffers when QP is destroyed
      hw/pvrdma: Delete unneeded function argument
      hw/pvrdma: Delete pvrdma_exit function
      hw/pvrdma: Unregister from shutdown notifier when device goes down

 contrib/rdmacm-mux/main.c     |  35 ++-
 hmp-commands-info.hx          |  16 ++
 hw/rdma/rdma_backend.c        | 483 +++++++++++++++++++++---------------------
 hw/rdma/rdma_backend.h        |   3 +-
 hw/rdma/rdma_backend_defs.h   |  10 +-
 hw/rdma/rdma_rm.c             | 134 ++++++------
 hw/rdma/rdma_rm_defs.h        |  32 ++-
 hw/rdma/rdma_utils.c          |  79 ++++++-
 hw/rdma/rdma_utils.h          |  61 +++---
 hw/rdma/trace-events          |  32 ++-
 hw/rdma/vmw/pvrdma.h          |   7 +-
 hw/rdma/vmw/pvrdma_cmd.c      | 113 +++-------
 hw/rdma/vmw/pvrdma_dev_ring.c |  26 +--
 hw/rdma/vmw/pvrdma_hmp.h      |  21 ++
 hw/rdma/vmw/pvrdma_main.c     | 217 +++++++++++--------
 hw/rdma/vmw/pvrdma_qp_ops.c   |  52 ++---
 hw/rdma/vmw/trace-events      |  16 +-
 monitor.c                     |  10 +
 18 files changed, 744 insertions(+), 603 deletions(-)
 create mode 100644 hw/rdma/vmw/pvrdma_hmp.h

-- 
2.17.1

On Sat, 23 Feb 2019 at 14:16, Marcel Apfelbaum
<marcel.apfelbaum@gmail.com> wrote:
>
> The following changes since commit 8eb29f1bf5a974dc4c11d2d1f5e7c7f7a62be116:
>
>   Merge remote-tracking branch 'remotes/awilliam/tags/vfio-updates-20190221.0' into staging (2019-02-22 15:48:04 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/marcel-apf/qemu tags/rdma-pull-request
>
> for you to fetch changes up to e1038e22f7b3ade2e46cf168fa7486414c424e94:
>
>   hw/rdma: another clang compilation fix (2019-02-23 15:28:25 +0200)
>
> ----------------------------------------------------------------
> RDMA queue
>
>  * Another Clang compilation fix
>  * Various fixes for the pvrdma device
>

Format string issues for 32-bit hosts:

In file included from hw/rdma/trace.c:4:0:
hw/rdma/trace.h: In function '_nocheck__trace_rdma_mad_message':
hw/rdma/trace.h:231:18: error: format '%ld' expects argument of type
'long int', but argument 6 has type 'size_t {aka unsigned int}'
[-Werror=format=]
         qemu_log("%d@%zu.%06zu:rdma_mad_message " "mad %s (%ld): %s" "\n",
                  ^
In file included from hw/rdma/trace.c:4:0:
hw/rdma/trace.h: In function '_nocheck__trace_rdma_rm_alloc_mr':
hw/rdma/trace.h:507:18: error: format '%ld' expects argument of type
'long int', but argument 8 has type 'size_t {aka unsigned int}'
[-Werror=format=]
         qemu_log("%d@%zu.%06zu:rdma_rm_alloc_mr " "mr_handle=%d,
host_virt=%p, guest_start=0x%"PRIx64", length=%ld, access_flags=0x%x"
"\n",
                  ^

thanks
-- PMM

Hi Peter,

On 2/26/19 6:48 PM, Peter Maydell wrote:
> On Sat, 23 Feb 2019 at 14:16, Marcel Apfelbaum
> <marcel.apfelbaum@gmail.com> wrote:
>> The following changes since commit 8eb29f1bf5a974dc4c11d2d1f5e7c7f7a62be116:
>>
>>    Merge remote-tracking branch 'remotes/awilliam/tags/vfio-updates-20190221.0' into staging (2019-02-22 15:48:04 +0000)
>>
>> are available in the Git repository at:
>>
>>    https://github.com/marcel-apf/qemu tags/rdma-pull-request
>>
>> for you to fetch changes up to e1038e22f7b3ade2e46cf168fa7486414c424e94:
>>
>>    hw/rdma: another clang compilation fix (2019-02-23 15:28:25 +0200)
>>
>> ----------------------------------------------------------------
>> RDMA queue
>>
>>   * Another Clang compilation fix
>>   * Various fixes for the pvrdma device
>>
> Format string issues for 32-bit hosts:
>
> In file included from hw/rdma/trace.c:4:0:
> hw/rdma/trace.h: In function '_nocheck__trace_rdma_mad_message':
> hw/rdma/trace.h:231:18: error: format '%ld' expects argument of type
> 'long int', but argument 6 has type 'size_t {aka unsigned int}'
> [-Werror=format=]
>           qemu_log("%d@%zu.%06zu:rdma_mad_message " "mad %s (%ld): %s" "\n",
>                    ^
> In file included from hw/rdma/trace.c:4:0:
> hw/rdma/trace.h: In function '_nocheck__trace_rdma_rm_alloc_mr':
> hw/rdma/trace.h:507:18: error: format '%ld' expects argument of type
> 'long int', but argument 8 has type 'size_t {aka unsigned int}'
> [-Werror=format=]
>           qemu_log("%d@%zu.%06zu:rdma_rm_alloc_mr " "mr_handle=%d,
> host_virt=%p, guest_start=0x%"PRIx64", length=%ld, access_flags=0x%x"
> "\n",
>                    ^

Will fix and resend (and add 32-bit compilation to my set of tests).

Thanks,
Marcel

> thanks
> -- PMM

On Tue, Feb 26, 2019 at 04:48:32PM +0000, Peter Maydell wrote:
> On Sat, 23 Feb 2019 at 14:16, Marcel Apfelbaum
> <marcel.apfelbaum@gmail.com> wrote:
> >
> > The following changes since commit 8eb29f1bf5a974dc4c11d2d1f5e7c7f7a62be116:
> >
> >   Merge remote-tracking branch 'remotes/awilliam/tags/vfio-updates-20190221.0' into staging (2019-02-22 15:48:04 +0000)
> >
> > are available in the Git repository at:
> >
> >   https://github.com/marcel-apf/qemu tags/rdma-pull-request
> >
> > for you to fetch changes up to e1038e22f7b3ade2e46cf168fa7486414c424e94:
> >
> >   hw/rdma: another clang compilation fix (2019-02-23 15:28:25 +0200)
> >
> > ----------------------------------------------------------------
> > RDMA queue
> >
> >  * Another Clang compilation fix
> >  * Various fixes for the pvrdma device
> >
> 
> Format string issues for 32-bit hosts:

I wonder if it is an easy task to enhance the build robot so it will run
cross platform compilation.

> 
> In file included from hw/rdma/trace.c:4:0:
> hw/rdma/trace.h: In function '_nocheck__trace_rdma_mad_message':
> hw/rdma/trace.h:231:18: error: format '%ld' expects argument of type
> 'long int', but argument 6 has type 'size_t {aka unsigned int}'
> [-Werror=format=]
>          qemu_log("%d@%zu.%06zu:rdma_mad_message " "mad %s (%ld): %s" "\n",
>                   ^
> In file included from hw/rdma/trace.c:4:0:
> hw/rdma/trace.h: In function '_nocheck__trace_rdma_rm_alloc_mr':
> hw/rdma/trace.h:507:18: error: format '%ld' expects argument of type
> 'long int', but argument 8 has type 'size_t {aka unsigned int}'
> [-Werror=format=]
>          qemu_log("%d@%zu.%06zu:rdma_rm_alloc_mr " "mr_handle=%d,
> host_virt=%p, guest_start=0x%"PRIx64", length=%ld, access_flags=0x%x"
> "\n",
>                   ^
> 
> thanks
> -- PMM