[Qemu-devel] [PULL 00/26] pci, pc, virtio: fixes, cleanups, tests

Michael S. Tsirkin posted 26 patches 6 years, 8 months ago
Only 0 patches received!
There is a newer version of this series
configure                                          | 102 ++++++++-----
Makefile                                           |   6 +-
default-configs/virtio.mak                         |   4 +-
include/exec/poison.h                              |   1 -
include/hw/firmware/smbios.h                       |   1 +
include/hw/pci/pci_ids.h                           |   2 +
include/hw/virtio/virtio-balloon.h                 |   3 +
.../UefiTestToolsPkg/Include/Guid/BiosTablesTest.h |  67 +++++++++
hw/mem/pc-dimm.c                                   |   4 +-
hw/net/vhost_net-stub.c                            |  92 ++++++++++++
hw/net/vhost_net.c                                 |  85 +----------
hw/pci/pcie.c                                      |  13 +-
hw/smbios/smbios.c                                 |   1 +
hw/vfio/pci-quirks.c                               |   2 -
hw/virtio/vhost-backend.c                          |  12 +-
hw/virtio/vhost-user.c                             |  13 +-
hw/virtio/vhost.c                                  |   2 +-
hw/virtio/virtio-balloon.c                         | 102 ++++++++++---
net/net.c                                          |   2 +-
net/vhost-user-stub.c                              |  23 +++
net/vhost-user.c                                   |  13 ++
.../BiosTablesTest/BiosTablesTest.c                | 130 +++++++++++++++++
tests/vhost-user-test.c                            | 160 +++++++++++----------
.gitmodules                                        |   3 +
backends/Makefile.objs                             |   5 +-
hw/net/Makefile.objs                               |   4 +-
hw/virtio/Makefile.objs                            |   8 +-
net/Makefile.objs                                  |   4 +-
roms/Makefile                                      |  13 +-
roms/edk2                                          |   1 +
tests/Makefile.include                             |   5 +-
.../bios-tables-test.aarch64.iso.qcow2             | Bin 0 -> 11776 bytes
.../bios-tables-test.arm.iso.qcow2                 | Bin 0 -> 11776 bytes
.../bios-tables-test.i386.iso.qcow2                | Bin 0 -> 12800 bytes
.../bios-tables-test.x86_64.iso.qcow2              | Bin 0 -> 13312 bytes
tests/uefi-test-tools/.gitignore                   |   3 +
tests/uefi-test-tools/LICENSE                      |  25 ++++
tests/uefi-test-tools/Makefile                     | 106 ++++++++++++++
.../BiosTablesTest/BiosTablesTest.inf              |  41 ++++++
.../UefiTestToolsPkg/UefiTestToolsPkg.dec          |  27 ++++
.../UefiTestToolsPkg/UefiTestToolsPkg.dsc          |  69 +++++++++
tests/uefi-test-tools/build.sh                     | 145 +++++++++++++++++++
42 files changed, 1051 insertions(+), 248 deletions(-)
create mode 100644 tests/uefi-test-tools/UefiTestToolsPkg/Include/Guid/BiosTablesTest.h
create mode 100644 hw/net/vhost_net-stub.c
create mode 100644 net/vhost-user-stub.c
create mode 100644 tests/uefi-test-tools/UefiTestToolsPkg/BiosTablesTest/BiosTablesTest.c
create mode 160000 roms/edk2
create mode 100644 tests/data/uefi-boot-images/bios-tables-test.aarch64.iso.qcow2
create mode 100644 tests/data/uefi-boot-images/bios-tables-test.arm.iso.qcow2
create mode 100644 tests/data/uefi-boot-images/bios-tables-test.i386.iso.qcow2
create mode 100644 tests/data/uefi-boot-images/bios-tables-test.x86_64.iso.qcow2
create mode 100644 tests/uefi-test-tools/.gitignore
create mode 100644 tests/uefi-test-tools/LICENSE
create mode 100644 tests/uefi-test-tools/Makefile
create mode 100644 tests/uefi-test-tools/UefiTestToolsPkg/BiosTablesTest/BiosTablesTest.inf
create mode 100644 tests/uefi-test-tools/UefiTestToolsPkg/UefiTestToolsPkg.dec
create mode 100644 tests/uefi-test-tools/UefiTestToolsPkg/UefiTestToolsPkg.dsc
create mode 100755 tests/uefi-test-tools/build.sh
[Qemu-devel] [PULL 00/26] pci, pc, virtio: fixes, cleanups, tests
Posted by Michael S. Tsirkin 6 years, 8 months ago
The following changes since commit fc3dbb90f2eb069801bfb4cfe9cbc83cf9c5f4a9:

  Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-02-21 13:09:33 +0000)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream

for you to fetch changes up to 1f8c04f18d2ee2f6ec88217dfd547ab38d2be5c5:

  pci: Sanity test minimum downstream LNKSTA (2019-02-21 12:28:41 -0500)

----------------------------------------------------------------
pci, pc, virtio: fixes, cleanups, tests

Lots of work on tests: BiosTablesTest UEFI app,
vhost-user testing for non-Linux hosts.
Misc cleanups and fixes all over the place

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

----------------------------------------------------------------
Alex Williamson (1):
      pci: Sanity test minimum downstream LNKSTA

Alexey Kardashevskiy (1):
      pci: Move NVIDIA vendor id to the rest of ids

Changpeng Liu (1):
      contrib/vhost-user-blk: fix the compilation issue

Daniel P. Berrangé (1):
      hw/smbios: fix offset of type 3 sku field

David Gibson (5):
      virtio-balloon: Remove unnecessary MADV_WILLNEED on deflate
      virtio-balloon: Corrections to address verification
      virtio-balloon: Rework ballon_page() interface
      virtio-balloon: Use ram_block_discard_range() instead of raw madvise()
      virtio-balloon: Safely handle BALLOON_PAGE_SIZE < host page size

Laszlo Ersek (5):
      roms: add the edk2 project as a git submodule
      roms: build the EfiRom utility from the roms/edk2 submodule
      tests: introduce "uefi-test-tools" with the BiosTablesTest UEFI app
      tests/uefi-test-tools: add build scripts
      tests/data: introduce "uefi-boot-images" with the "bios-tables-test" ISOs

Paolo Bonzini (9):
      vhost-net: move stubs to a separate file
      vhost-net-user: add stubs for when no virtio-net device is present
      vhost: restrict Linux dependency to kernel vhost
      vhost-user: support cross-endian vnet headers
      vhost-net: compile it on all targets that have virtio-net.
      vhost-net: revamp configure logic
      vhost-user-test: create a main loop per TestServer
      vhost-user-test: small changes to init_hugepagefs
      vhost-user-test: create a temporary directory per TestServer

Peter Xu (1):
      i386/kvm: ignore masked irqs when update msi routes

Philippe Mathieu-Daudé (1):
      Revert "contrib/vhost-user-blk: fix the compilation issue"

Wei Yang (1):
      pc-dimm: use same mechanism for [get|set]_addr

 configure                                          | 102 ++++++++-----
 Makefile                                           |   6 +-
 default-configs/virtio.mak                         |   4 +-
 include/exec/poison.h                              |   1 -
 include/hw/firmware/smbios.h                       |   1 +
 include/hw/pci/pci_ids.h                           |   2 +
 include/hw/virtio/virtio-balloon.h                 |   3 +
 .../UefiTestToolsPkg/Include/Guid/BiosTablesTest.h |  67 +++++++++
 hw/mem/pc-dimm.c                                   |   4 +-
 hw/net/vhost_net-stub.c                            |  92 ++++++++++++
 hw/net/vhost_net.c                                 |  85 +----------
 hw/pci/pcie.c                                      |  13 +-
 hw/smbios/smbios.c                                 |   1 +
 hw/vfio/pci-quirks.c                               |   2 -
 hw/virtio/vhost-backend.c                          |  12 +-
 hw/virtio/vhost-user.c                             |  13 +-
 hw/virtio/vhost.c                                  |   2 +-
 hw/virtio/virtio-balloon.c                         | 102 ++++++++++---
 net/net.c                                          |   2 +-
 net/vhost-user-stub.c                              |  23 +++
 net/vhost-user.c                                   |  13 ++
 .../BiosTablesTest/BiosTablesTest.c                | 130 +++++++++++++++++
 tests/vhost-user-test.c                            | 160 +++++++++++----------
 .gitmodules                                        |   3 +
 backends/Makefile.objs                             |   5 +-
 hw/net/Makefile.objs                               |   4 +-
 hw/virtio/Makefile.objs                            |   8 +-
 net/Makefile.objs                                  |   4 +-
 roms/Makefile                                      |  13 +-
 roms/edk2                                          |   1 +
 tests/Makefile.include                             |   5 +-
 .../bios-tables-test.aarch64.iso.qcow2             | Bin 0 -> 11776 bytes
 .../bios-tables-test.arm.iso.qcow2                 | Bin 0 -> 11776 bytes
 .../bios-tables-test.i386.iso.qcow2                | Bin 0 -> 12800 bytes
 .../bios-tables-test.x86_64.iso.qcow2              | Bin 0 -> 13312 bytes
 tests/uefi-test-tools/.gitignore                   |   3 +
 tests/uefi-test-tools/LICENSE                      |  25 ++++
 tests/uefi-test-tools/Makefile                     | 106 ++++++++++++++
 .../BiosTablesTest/BiosTablesTest.inf              |  41 ++++++
 .../UefiTestToolsPkg/UefiTestToolsPkg.dec          |  27 ++++
 .../UefiTestToolsPkg/UefiTestToolsPkg.dsc          |  69 +++++++++
 tests/uefi-test-tools/build.sh                     | 145 +++++++++++++++++++
 42 files changed, 1051 insertions(+), 248 deletions(-)
 create mode 100644 tests/uefi-test-tools/UefiTestToolsPkg/Include/Guid/BiosTablesTest.h
 create mode 100644 hw/net/vhost_net-stub.c
 create mode 100644 net/vhost-user-stub.c
 create mode 100644 tests/uefi-test-tools/UefiTestToolsPkg/BiosTablesTest/BiosTablesTest.c
 create mode 160000 roms/edk2
 create mode 100644 tests/data/uefi-boot-images/bios-tables-test.aarch64.iso.qcow2
 create mode 100644 tests/data/uefi-boot-images/bios-tables-test.arm.iso.qcow2
 create mode 100644 tests/data/uefi-boot-images/bios-tables-test.i386.iso.qcow2
 create mode 100644 tests/data/uefi-boot-images/bios-tables-test.x86_64.iso.qcow2
 create mode 100644 tests/uefi-test-tools/.gitignore
 create mode 100644 tests/uefi-test-tools/LICENSE
 create mode 100644 tests/uefi-test-tools/Makefile
 create mode 100644 tests/uefi-test-tools/UefiTestToolsPkg/BiosTablesTest/BiosTablesTest.inf
 create mode 100644 tests/uefi-test-tools/UefiTestToolsPkg/UefiTestToolsPkg.dec
 create mode 100644 tests/uefi-test-tools/UefiTestToolsPkg/UefiTestToolsPkg.dsc
 create mode 100755 tests/uefi-test-tools/build.sh


Re: [Qemu-devel] [PULL 00/26] pci, pc, virtio: fixes, cleanups, tests
Posted by Peter Maydell 6 years, 8 months ago
On Fri, 22 Feb 2019 at 02:40, Michael S. Tsirkin <mst@redhat.com> wrote:
>
> The following changes since commit fc3dbb90f2eb069801bfb4cfe9cbc83cf9c5f4a9:
>
>   Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-02-21 13:09:33 +0000)
>
> are available in the Git repository at:
>
>   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
>
> for you to fetch changes up to 1f8c04f18d2ee2f6ec88217dfd547ab38d2be5c5:
>
>   pci: Sanity test minimum downstream LNKSTA (2019-02-21 12:28:41 -0500)
>
> ----------------------------------------------------------------
> pci, pc, virtio: fixes, cleanups, tests
>
> Lots of work on tests: BiosTablesTest UEFI app,
> vhost-user testing for non-Linux hosts.
> Misc cleanups and fixes all over the place
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> ----------------------------------------------------------------

Compile failure on clang:

/home/petmay01/linaro/qemu-for-merges/hw/virtio/virtio-balloon.c:40:3:
error: redefinition of typedef 'PartiallyBalloonedPage' is a C11
feature [-Werror,-Wtypedef-redefinition]
} PartiallyBalloonedPage;
  ^
/home/petmay01/linaro/qemu-for-merges/include/hw/virtio/virtio-balloon.h:33:39:
note: previous definition is here
typedef struct PartiallyBalloonedPage PartiallyBalloonedPage;
                                      ^
1 error generated.
/home/petmay01/linaro/qemu-for-merges/rules.mak:69: recipe for target
'hw/virtio/virtio-balloon.o' failed

thanks
-- PMM

Re: [Qemu-devel] [PULL 00/26] pci, pc, virtio: fixes, cleanups, tests
Posted by Michael S. Tsirkin 6 years, 8 months ago
On Fri, Feb 22, 2019 at 03:47:36PM +0000, Peter Maydell wrote:
> On Fri, 22 Feb 2019 at 02:40, Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > The following changes since commit fc3dbb90f2eb069801bfb4cfe9cbc83cf9c5f4a9:
> >
> >   Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-02-21 13:09:33 +0000)
> >
> > are available in the Git repository at:
> >
> >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> >
> > for you to fetch changes up to 1f8c04f18d2ee2f6ec88217dfd547ab38d2be5c5:
> >
> >   pci: Sanity test minimum downstream LNKSTA (2019-02-21 12:28:41 -0500)
> >
> > ----------------------------------------------------------------
> > pci, pc, virtio: fixes, cleanups, tests
> >
> > Lots of work on tests: BiosTablesTest UEFI app,
> > vhost-user testing for non-Linux hosts.
> > Misc cleanups and fixes all over the place
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > ----------------------------------------------------------------
> 
> Compile failure on clang:
> 
> /home/petmay01/linaro/qemu-for-merges/hw/virtio/virtio-balloon.c:40:3:
> error: redefinition of typedef 'PartiallyBalloonedPage' is a C11
> feature [-Werror,-Wtypedef-redefinition]
> } PartiallyBalloonedPage;
>   ^
> /home/petmay01/linaro/qemu-for-merges/include/hw/virtio/virtio-balloon.h:33:39:
> note: previous definition is here
> typedef struct PartiallyBalloonedPage PartiallyBalloonedPage;
>                                       ^
> 1 error generated.
> /home/petmay01/linaro/qemu-for-merges/rules.mak:69: recipe for target
> 'hw/virtio/virtio-balloon.o' failed
> 
> thanks
> -- PMM

Fixed up and re-pushed.
David, pls note above and don't add duplicate typedefs in the future.
There's always include/qemu/typedefs.h if you don't know where
to put a typedef.

-- 
MST

Re: [Qemu-devel] [PULL 00/26] pci, pc, virtio: fixes, cleanups, tests
Posted by Michael S. Tsirkin 6 years, 8 months ago
On Fri, Feb 22, 2019 at 10:53:54AM -0500, Michael S. Tsirkin wrote:
> On Fri, Feb 22, 2019 at 03:47:36PM +0000, Peter Maydell wrote:
> > On Fri, 22 Feb 2019 at 02:40, Michael S. Tsirkin <mst@redhat.com> wrote:
> > >
> > > The following changes since commit fc3dbb90f2eb069801bfb4cfe9cbc83cf9c5f4a9:
> > >
> > >   Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-02-21 13:09:33 +0000)
> > >
> > > are available in the Git repository at:
> > >
> > >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> > >
> > > for you to fetch changes up to 1f8c04f18d2ee2f6ec88217dfd547ab38d2be5c5:
> > >
> > >   pci: Sanity test minimum downstream LNKSTA (2019-02-21 12:28:41 -0500)
> > >
> > > ----------------------------------------------------------------
> > > pci, pc, virtio: fixes, cleanups, tests
> > >
> > > Lots of work on tests: BiosTablesTest UEFI app,
> > > vhost-user testing for non-Linux hosts.
> > > Misc cleanups and fixes all over the place
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > >
> > > ----------------------------------------------------------------
> > 
> > Compile failure on clang:
> > 
> > /home/petmay01/linaro/qemu-for-merges/hw/virtio/virtio-balloon.c:40:3:
> > error: redefinition of typedef 'PartiallyBalloonedPage' is a C11
> > feature [-Werror,-Wtypedef-redefinition]
> > } PartiallyBalloonedPage;
> >   ^
> > /home/petmay01/linaro/qemu-for-merges/include/hw/virtio/virtio-balloon.h:33:39:
> > note: previous definition is here
> > typedef struct PartiallyBalloonedPage PartiallyBalloonedPage;
> >                                       ^
> > 1 error generated.
> > /home/petmay01/linaro/qemu-for-merges/rules.mak:69: recipe for target
> > 'hw/virtio/virtio-balloon.o' failed
> > 
> > thanks
> > -- PMM
> 
> Fixed up and re-pushed.

Peter, can you merge for_upstream now pls? Don't want to spam
the list with a trivial change like that ...

> David, pls note above and don't add duplicate typedefs in the future.
> There's always include/qemu/typedefs.h if you don't know where
> to put a typedef.
> 
> -- 
> MST

Re: [Qemu-devel] [PULL 00/26] pci, pc, virtio: fixes, cleanups, tests
Posted by Peter Maydell 6 years, 8 months ago
On Sun, 24 Feb 2019 at 00:34, Michael S. Tsirkin <mst@redhat.com> wrote:
> Peter, can you merge for_upstream now pls? Don't want to spam
> the list with a trivial change like that ...

Yes, it's on my list, but so are seven other pullreqs;
seems like everybody likes to submit on a Friday, so
sending on a Friday guarantees maximum delay because
you'll be in a big queue with other people and I don't
generally handle pullreqs on the weekend either...

In general I prefer it if you just re-send the cover-letter
email as a v2 rather than informally asking for a retry: that
guarantees I'll see it and automatically makes it appear
in my list of things to process. You don't need to
resend all the individual patchmails if the change was
minor.

thanks
-- PMM

Re: [Qemu-devel] [PULL 00/26] pci, pc, virtio: fixes, cleanups, tests
Posted by Michael S. Tsirkin 6 years, 8 months ago
On Sun, Feb 24, 2019 at 10:21:52AM +0000, Peter Maydell wrote:
> On Sun, 24 Feb 2019 at 00:34, Michael S. Tsirkin <mst@redhat.com> wrote:
> > Peter, can you merge for_upstream now pls? Don't want to spam
> > the list with a trivial change like that ...
> 
> Yes, it's on my list, but so are seven other pullreqs;
> seems like everybody likes to submit on a Friday, so
> sending on a Friday guarantees maximum delay because
> you'll be in a big queue with other people and I don't
> generally handle pullreqs on the weekend either...

OK I'll try to switch over to middle of the week.

> In general I prefer it if you just re-send the cover-letter
> email as a v2 rather than informally asking for a retry: that
> guarantees I'll see it and automatically makes it appear
> in my list of things to process. You don't need to
> resend all the individual patchmails if the change was
> minor.
> 
> thanks
> -- PMM

Good to know.

-- 
MST

Re: [Qemu-devel] [PULL 00/26] pci, pc, virtio: fixes, cleanups, tests
Posted by Philippe Mathieu-Daudé 6 years, 8 months ago
On 2/24/19 5:41 PM, Michael S. Tsirkin wrote:
> On Sun, Feb 24, 2019 at 10:21:52AM +0000, Peter Maydell wrote:
>> In general I prefer it if you just re-send the cover-letter
>> email as a v2 rather than informally asking for a retry: that
>> guarantees I'll see it and automatically makes it appear
>> in my list of things to process. You don't need to
>> resend all the individual patchmails if the change was
>> minor.

I appreciate what some maintainers do (such Paolo/Richard):
sending the cover + the patches changed, because we can review the
updated patch on the list and tag/remove the patch from the mail queue,
rather than after it was merged via the git tree (if smth was wrong, it
is too late).

>>
>> thanks
>> -- PMM
> 
> Good to know.
> 

Re: [Qemu-devel] [PULL 00/26] pci, pc, virtio: fixes, cleanups, tests
Posted by Peter Maydell 6 years, 8 months ago
On Mon, 25 Feb 2019 at 16:23, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> On 2/24/19 5:41 PM, Michael S. Tsirkin wrote:
> > On Sun, Feb 24, 2019 at 10:21:52AM +0000, Peter Maydell wrote:
> >> In general I prefer it if you just re-send the cover-letter
> >> email as a v2 rather than informally asking for a retry: that
> >> guarantees I'll see it and automatically makes it appear
> >> in my list of things to process. You don't need to
> >> resend all the individual patchmails if the change was
> >> minor.
>
> I appreciate what some maintainers do (such Paolo/Richard):
> sending the cover + the patches changed, because we can review the
> updated patch on the list and tag/remove the patch from the mail queue,
> rather than after it was merged via the git tree (if smth was wrong, it
> is too late).

Yes, I meant more "you don't need to resend everything";
sending the 1 changed patch is usually a good idea.

thanks
-- PMM

Re: [Qemu-devel] [PULL 00/26] pci, pc, virtio: fixes, cleanups, tests
Posted by Peter Maydell 6 years, 8 months ago
On Fri, 22 Feb 2019 at 15:53, Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Fri, Feb 22, 2019 at 03:47:36PM +0000, Peter Maydell wrote:
> > Compile failure on clang:
> >
> > /home/petmay01/linaro/qemu-for-merges/hw/virtio/virtio-balloon.c:40:3:
> > error: redefinition of typedef 'PartiallyBalloonedPage' is a C11
> > feature [-Werror,-Wtypedef-redefinition]
> > } PartiallyBalloonedPage;
> >   ^
> > /home/petmay01/linaro/qemu-for-merges/include/hw/virtio/virtio-balloon.h:33:39:
> > note: previous definition is here
> > typedef struct PartiallyBalloonedPage PartiallyBalloonedPage;
> >                                       ^
> > 1 error generated.
> > /home/petmay01/linaro/qemu-for-merges/rules.mak:69: recipe for target
> > 'hw/virtio/virtio-balloon.o' failed

> Fixed up and re-pushed.
> David, pls note above and don't add duplicate typedefs in the future.
> There's always include/qemu/typedefs.h if you don't know where
> to put a typedef.

It's an easy mistake to make, and it's only clang that complains -- I
did it myself the other week :-)

thanks
-- PMM

Re: [Qemu-devel] [PULL 00/26] pci, pc, virtio: fixes, cleanups, tests
Posted by David Gibson 6 years, 8 months ago
On Fri, Feb 22, 2019 at 10:53:54AM -0500, Michael S. Tsirkin wrote:
> On Fri, Feb 22, 2019 at 03:47:36PM +0000, Peter Maydell wrote:
> > On Fri, 22 Feb 2019 at 02:40, Michael S. Tsirkin <mst@redhat.com> wrote:
> > >
> > > The following changes since commit fc3dbb90f2eb069801bfb4cfe9cbc83cf9c5f4a9:
> > >
> > >   Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-02-21 13:09:33 +0000)
> > >
> > > are available in the Git repository at:
> > >
> > >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> > >
> > > for you to fetch changes up to 1f8c04f18d2ee2f6ec88217dfd547ab38d2be5c5:
> > >
> > >   pci: Sanity test minimum downstream LNKSTA (2019-02-21 12:28:41 -0500)
> > >
> > > ----------------------------------------------------------------
> > > pci, pc, virtio: fixes, cleanups, tests
> > >
> > > Lots of work on tests: BiosTablesTest UEFI app,
> > > vhost-user testing for non-Linux hosts.
> > > Misc cleanups and fixes all over the place
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > >
> > > ----------------------------------------------------------------
> > 
> > Compile failure on clang:
> > 
> > /home/petmay01/linaro/qemu-for-merges/hw/virtio/virtio-balloon.c:40:3:
> > error: redefinition of typedef 'PartiallyBalloonedPage' is a C11
> > feature [-Werror,-Wtypedef-redefinition]
> > } PartiallyBalloonedPage;
> >   ^
> > /home/petmay01/linaro/qemu-for-merges/include/hw/virtio/virtio-balloon.h:33:39:
> > note: previous definition is here
> > typedef struct PartiallyBalloonedPage PartiallyBalloonedPage;
> >                                       ^
> > 1 error generated.
> > /home/petmay01/linaro/qemu-for-merges/rules.mak:69: recipe for target
> > 'hw/virtio/virtio-balloon.o' failed
> > 
> > thanks
> > -- PMM
> 
> Fixed up and re-pushed.
> David, pls note above and don't add duplicate typedefs in the future.
> There's always include/qemu/typedefs.h if you don't know where
> to put a typedef.

Yeah, sorry.  I noticed the failure on Travis and was going to send a
fix, not realizing you'd already picked it up.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
[Qemu-devel] [PULL v2 resend 00/26] pci, pc, virtio: fixes, cleanups, tests
Posted by Michael S. Tsirkin 6 years, 8 months ago
The following changes since commit fc3dbb90f2eb069801bfb4cfe9cbc83cf9c5f4a9:

  Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-02-21 13:09:33 +0000)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream

for you to fetch changes up to 88c869198aa630e0477d653d0abf3f42c7c44d1f

  pci: Sanity test minimum downstream LNKSTA (2019-02-21 12:28:41 -0500)

----------------------------------------------------------------

Note: this is same as a fixup I sent earlier, this is just a resend to
make sure it's not missed.  This should also help me figure out whether
this is a good format to use.

----------------------------------------------------------------
pci, pc, virtio: fixes, cleanups, tests

Lots of work on tests: BiosTablesTest UEFI app,
vhost-user testing for non-Linux hosts.
Misc cleanups and fixes all over the place

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

----------------------------------------------------------------
Alex Williamson (1):
      pci: Sanity test minimum downstream LNKSTA

Alexey Kardashevskiy (1):
      pci: Move NVIDIA vendor id to the rest of ids

Changpeng Liu (1):
      contrib/vhost-user-blk: fix the compilation issue

Daniel P. Berrangé (1):
      hw/smbios: fix offset of type 3 sku field

David Gibson (5):
      virtio-balloon: Remove unnecessary MADV_WILLNEED on deflate
      virtio-balloon: Corrections to address verification
      virtio-balloon: Rework ballon_page() interface
      virtio-balloon: Use ram_block_discard_range() instead of raw madvise()
      virtio-balloon: Safely handle BALLOON_PAGE_SIZE < host page size

Laszlo Ersek (5):
      roms: add the edk2 project as a git submodule
      roms: build the EfiRom utility from the roms/edk2 submodule
      tests: introduce "uefi-test-tools" with the BiosTablesTest UEFI app
      tests/uefi-test-tools: add build scripts
      tests/data: introduce "uefi-boot-images" with the "bios-tables-test" ISOs

Paolo Bonzini (9):
      vhost-net: move stubs to a separate file
      vhost-net-user: add stubs for when no virtio-net device is present
      vhost: restrict Linux dependency to kernel vhost
      vhost-user: support cross-endian vnet headers
      vhost-net: compile it on all targets that have virtio-net.
      vhost-net: revamp configure logic
      vhost-user-test: create a main loop per TestServer
      vhost-user-test: small changes to init_hugepagefs
      vhost-user-test: create a temporary directory per TestServer

Peter Xu (1):
      i386/kvm: ignore masked irqs when update msi routes

Philippe Mathieu-Daudé (1):
      Revert "contrib/vhost-user-blk: fix the compilation issue"

Wei Yang (1):
      pc-dimm: use same mechanism for [get|set]_addr

 configure                                          | 102 ++++++++-----
 Makefile                                           |   6 +-
 default-configs/virtio.mak                         |   4 +-
 include/exec/poison.h                              |   1 -
 include/hw/firmware/smbios.h                       |   1 +
 include/hw/pci/pci_ids.h                           |   2 +
 include/hw/virtio/virtio-balloon.h                 |   3 +
 .../UefiTestToolsPkg/Include/Guid/BiosTablesTest.h |  67 +++++++++
 hw/mem/pc-dimm.c                                   |   4 +-
 hw/net/vhost_net-stub.c                            |  92 ++++++++++++
 hw/net/vhost_net.c                                 |  85 +----------
 hw/pci/pcie.c                                      |  13 +-
 hw/smbios/smbios.c                                 |   1 +
 hw/vfio/pci-quirks.c                               |   2 -
 hw/virtio/vhost-backend.c                          |  12 +-
 hw/virtio/vhost-user.c                             |  13 +-
 hw/virtio/vhost.c                                  |   2 +-
 hw/virtio/virtio-balloon.c                         | 102 ++++++++++---
 net/net.c                                          |   2 +-
 net/vhost-user-stub.c                              |  23 +++
 net/vhost-user.c                                   |  13 ++
 .../BiosTablesTest/BiosTablesTest.c                | 130 +++++++++++++++++
 tests/vhost-user-test.c                            | 160 +++++++++++----------
 .gitmodules                                        |   3 +
 backends/Makefile.objs                             |   5 +-
 hw/net/Makefile.objs                               |   4 +-
 hw/virtio/Makefile.objs                            |   8 +-
 net/Makefile.objs                                  |   4 +-
 roms/Makefile                                      |  13 +-
 roms/edk2                                          |   1 +
 tests/Makefile.include                             |   5 +-
 .../bios-tables-test.aarch64.iso.qcow2             | Bin 0 -> 11776 bytes
 .../bios-tables-test.arm.iso.qcow2                 | Bin 0 -> 11776 bytes
 .../bios-tables-test.i386.iso.qcow2                | Bin 0 -> 12800 bytes
 .../bios-tables-test.x86_64.iso.qcow2              | Bin 0 -> 13312 bytes
 tests/uefi-test-tools/.gitignore                   |   3 +
 tests/uefi-test-tools/LICENSE                      |  25 ++++
 tests/uefi-test-tools/Makefile                     | 106 ++++++++++++++
 .../BiosTablesTest/BiosTablesTest.inf              |  41 ++++++
 .../UefiTestToolsPkg/UefiTestToolsPkg.dec          |  27 ++++
 .../UefiTestToolsPkg/UefiTestToolsPkg.dsc          |  69 +++++++++
 tests/uefi-test-tools/build.sh                     | 145 +++++++++++++++++++
 42 files changed, 1051 insertions(+), 248 deletions(-)
 create mode 100644 tests/uefi-test-tools/UefiTestToolsPkg/Include/Guid/BiosTablesTest.h
 create mode 100644 hw/net/vhost_net-stub.c
 create mode 100644 net/vhost-user-stub.c
 create mode 100644 tests/uefi-test-tools/UefiTestToolsPkg/BiosTablesTest/BiosTablesTest.c
 create mode 160000 roms/edk2
 create mode 100644 tests/data/uefi-boot-images/bios-tables-test.aarch64.iso.qcow2
 create mode 100644 tests/data/uefi-boot-images/bios-tables-test.arm.iso.qcow2
 create mode 100644 tests/data/uefi-boot-images/bios-tables-test.i386.iso.qcow2
 create mode 100644 tests/data/uefi-boot-images/bios-tables-test.x86_64.iso.qcow2
 create mode 100644 tests/uefi-test-tools/.gitignore
 create mode 100644 tests/uefi-test-tools/LICENSE
 create mode 100644 tests/uefi-test-tools/Makefile
 create mode 100644 tests/uefi-test-tools/UefiTestToolsPkg/BiosTablesTest/BiosTablesTest.inf
 create mode 100644 tests/uefi-test-tools/UefiTestToolsPkg/UefiTestToolsPkg.dec
 create mode 100644 tests/uefi-test-tools/UefiTestToolsPkg/UefiTestToolsPkg.dsc
 create mode 100755 tests/uefi-test-tools/build.sh


Re: [Qemu-devel] [PULL v2 resend 00/26] pci, pc, virtio: fixes, cleanups, tests
Posted by Paolo Bonzini 6 years, 8 months ago
On 25/02/19 16:19, Michael S. Tsirkin wrote:
> The following changes since commit fc3dbb90f2eb069801bfb4cfe9cbc83cf9c5f4a9:
> 
>   Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-02-21 13:09:33 +0000)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> 
> for you to fetch changes up to 88c869198aa630e0477d653d0abf3f42c7c44d1f
> 
>   pci: Sanity test minimum downstream LNKSTA (2019-02-21 12:28:41 -0500)
> 
> ----------------------------------------------------------------
> 
> Note: this is same as a fixup I sent earlier, this is just a resend to
> make sure it's not missed.  This should also help me figure out whether
> this is a good format to use.

You should have sent it as a new toplevel message, too, otherwise Peter
doesn't see it.

Paolo

> ----------------------------------------------------------------
> pci, pc, virtio: fixes, cleanups, tests
> 
> Lots of work on tests: BiosTablesTest UEFI app,
> vhost-user testing for non-Linux hosts.
> Misc cleanups and fixes all over the place
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> 
> ----------------------------------------------------------------
> Alex Williamson (1):
>       pci: Sanity test minimum downstream LNKSTA
> 
> Alexey Kardashevskiy (1):
>       pci: Move NVIDIA vendor id to the rest of ids
> 
> Changpeng Liu (1):
>       contrib/vhost-user-blk: fix the compilation issue
> 
> Daniel P. Berrangé (1):
>       hw/smbios: fix offset of type 3 sku field
> 
> David Gibson (5):
>       virtio-balloon: Remove unnecessary MADV_WILLNEED on deflate
>       virtio-balloon: Corrections to address verification
>       virtio-balloon: Rework ballon_page() interface
>       virtio-balloon: Use ram_block_discard_range() instead of raw madvise()
>       virtio-balloon: Safely handle BALLOON_PAGE_SIZE < host page size
> 
> Laszlo Ersek (5):
>       roms: add the edk2 project as a git submodule
>       roms: build the EfiRom utility from the roms/edk2 submodule
>       tests: introduce "uefi-test-tools" with the BiosTablesTest UEFI app
>       tests/uefi-test-tools: add build scripts
>       tests/data: introduce "uefi-boot-images" with the "bios-tables-test" ISOs
> 
> Paolo Bonzini (9):
>       vhost-net: move stubs to a separate file
>       vhost-net-user: add stubs for when no virtio-net device is present
>       vhost: restrict Linux dependency to kernel vhost
>       vhost-user: support cross-endian vnet headers
>       vhost-net: compile it on all targets that have virtio-net.
>       vhost-net: revamp configure logic
>       vhost-user-test: create a main loop per TestServer
>       vhost-user-test: small changes to init_hugepagefs
>       vhost-user-test: create a temporary directory per TestServer
> 
> Peter Xu (1):
>       i386/kvm: ignore masked irqs when update msi routes
> 
> Philippe Mathieu-Daudé (1):
>       Revert "contrib/vhost-user-blk: fix the compilation issue"
> 
> Wei Yang (1):
>       pc-dimm: use same mechanism for [get|set]_addr
> 
>  configure                                          | 102 ++++++++-----
>  Makefile                                           |   6 +-
>  default-configs/virtio.mak                         |   4 +-
>  include/exec/poison.h                              |   1 -
>  include/hw/firmware/smbios.h                       |   1 +
>  include/hw/pci/pci_ids.h                           |   2 +
>  include/hw/virtio/virtio-balloon.h                 |   3 +
>  .../UefiTestToolsPkg/Include/Guid/BiosTablesTest.h |  67 +++++++++
>  hw/mem/pc-dimm.c                                   |   4 +-
>  hw/net/vhost_net-stub.c                            |  92 ++++++++++++
>  hw/net/vhost_net.c                                 |  85 +----------
>  hw/pci/pcie.c                                      |  13 +-
>  hw/smbios/smbios.c                                 |   1 +
>  hw/vfio/pci-quirks.c                               |   2 -
>  hw/virtio/vhost-backend.c                          |  12 +-
>  hw/virtio/vhost-user.c                             |  13 +-
>  hw/virtio/vhost.c                                  |   2 +-
>  hw/virtio/virtio-balloon.c                         | 102 ++++++++++---
>  net/net.c                                          |   2 +-
>  net/vhost-user-stub.c                              |  23 +++
>  net/vhost-user.c                                   |  13 ++
>  .../BiosTablesTest/BiosTablesTest.c                | 130 +++++++++++++++++
>  tests/vhost-user-test.c                            | 160 +++++++++++----------
>  .gitmodules                                        |   3 +
>  backends/Makefile.objs                             |   5 +-
>  hw/net/Makefile.objs                               |   4 +-
>  hw/virtio/Makefile.objs                            |   8 +-
>  net/Makefile.objs                                  |   4 +-
>  roms/Makefile                                      |  13 +-
>  roms/edk2                                          |   1 +
>  tests/Makefile.include                             |   5 +-
>  .../bios-tables-test.aarch64.iso.qcow2             | Bin 0 -> 11776 bytes
>  .../bios-tables-test.arm.iso.qcow2                 | Bin 0 -> 11776 bytes
>  .../bios-tables-test.i386.iso.qcow2                | Bin 0 -> 12800 bytes
>  .../bios-tables-test.x86_64.iso.qcow2              | Bin 0 -> 13312 bytes
>  tests/uefi-test-tools/.gitignore                   |   3 +
>  tests/uefi-test-tools/LICENSE                      |  25 ++++
>  tests/uefi-test-tools/Makefile                     | 106 ++++++++++++++
>  .../BiosTablesTest/BiosTablesTest.inf              |  41 ++++++
>  .../UefiTestToolsPkg/UefiTestToolsPkg.dec          |  27 ++++
>  .../UefiTestToolsPkg/UefiTestToolsPkg.dsc          |  69 +++++++++
>  tests/uefi-test-tools/build.sh                     | 145 +++++++++++++++++++
>  42 files changed, 1051 insertions(+), 248 deletions(-)
>  create mode 100644 tests/uefi-test-tools/UefiTestToolsPkg/Include/Guid/BiosTablesTest.h
>  create mode 100644 hw/net/vhost_net-stub.c
>  create mode 100644 net/vhost-user-stub.c
>  create mode 100644 tests/uefi-test-tools/UefiTestToolsPkg/BiosTablesTest/BiosTablesTest.c
>  create mode 160000 roms/edk2
>  create mode 100644 tests/data/uefi-boot-images/bios-tables-test.aarch64.iso.qcow2
>  create mode 100644 tests/data/uefi-boot-images/bios-tables-test.arm.iso.qcow2
>  create mode 100644 tests/data/uefi-boot-images/bios-tables-test.i386.iso.qcow2
>  create mode 100644 tests/data/uefi-boot-images/bios-tables-test.x86_64.iso.qcow2
>  create mode 100644 tests/uefi-test-tools/.gitignore
>  create mode 100644 tests/uefi-test-tools/LICENSE
>  create mode 100644 tests/uefi-test-tools/Makefile
>  create mode 100644 tests/uefi-test-tools/UefiTestToolsPkg/BiosTablesTest/BiosTablesTest.inf
>  create mode 100644 tests/uefi-test-tools/UefiTestToolsPkg/UefiTestToolsPkg.dec
>  create mode 100644 tests/uefi-test-tools/UefiTestToolsPkg/UefiTestToolsPkg.dsc
>  create mode 100755 tests/uefi-test-tools/build.sh
> 
> 


Re: [Qemu-devel] [PULL v2 resend 00/26] pci, pc, virtio: fixes, cleanups, tests
Posted by Peter Maydell 6 years, 8 months ago
On Mon, 4 Mar 2019 at 10:56, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 25/02/19 16:19, Michael S. Tsirkin wrote:
> > The following changes since commit fc3dbb90f2eb069801bfb4cfe9cbc83cf9c5f4a9:
> >
> >   Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-02-21 13:09:33 +0000)
> >
> > are available in the Git repository at:
> >
> >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> >
> > for you to fetch changes up to 88c869198aa630e0477d653d0abf3f42c7c44d1f
> >
> >   pci: Sanity test minimum downstream LNKSTA (2019-02-21 12:28:41 -0500)
> >
> > ----------------------------------------------------------------
> >
> > Note: this is same as a fixup I sent earlier, this is just a resend to
> > make sure it's not missed.  This should also help me figure out whether
> > this is a good format to use.
>
> You should have sent it as a new toplevel message, too, otherwise Peter
> doesn't see it.

No, my filter doesn't care about top level messages or not (though
sending as a new top level message is a good idea). I'm not sure
why this slipped through the net.

In any case, now applied, thanks. Please update the changelog for
any user-visible changes.

-- PMM