hw/i386/amd_iommu.c | 1 - hw/i386/amd_iommu.h | 1 - 2 files changed, 2 deletions(-)
the occurrence of my name and email on the files below may have led to some confusion in the reporting of a few recent bugs. i have therefore choosen to snip it. David Kiarie (1): hw/i386: snip my name and email hw/i386/amd_iommu.c | 1 - hw/i386/amd_iommu.h | 1 - 2 files changed, 2 deletions(-) -- 2.20.1
On 2/21/19 9:53 AM, David Kiarie wrote: > the occurrence of my name and email on the files below may have led to > some confusion in the reporting of a few recent bugs. > > i have therefore choosen to snip it. Dropping an email from the copyright line makes sense; dropping the Copyright declaration altogether is a bit odd (the GPL works only in tandem with a copyright assertion) - but as you are the author of the line and copyright holder of your contributions, I am not in a position to say you are wrong in removing it, only that it looks odd. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
On 21.02.19 17:05, Eric Blake wrote: > On 2/21/19 9:53 AM, David Kiarie wrote: >> the occurrence of my name and email on the files below may have led to >> some confusion in the reporting of a few recent bugs. >> >> i have therefore choosen to snip it. > > Dropping an email from the copyright line makes sense; dropping the > Copyright declaration altogether is a bit odd (the GPL works only in > tandem with a copyright assertion) - but as you are the author of the > line and copyright holder of your contributions, I am not in a position > to say you are wrong in removing it, only that it looks odd. > Yeah, indeed. David, also note that you probably have been addressed because scripts/get_maintainer.pl will look into the git history of files that some patch addresses and pick up significant and/or recent contributors from there. There should be some opt-out statement from that, but I don't recall how. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux
On Thu, Feb 21, 2019 at 7:09 PM Jan Kiszka <jan.kiszka@siemens.com> wrote: > On 21.02.19 17:05, Eric Blake wrote: > > On 2/21/19 9:53 AM, David Kiarie wrote: > >> the occurrence of my name and email on the files below may have led to > >> some confusion in the reporting of a few recent bugs. > >> > >> i have therefore choosen to snip it. > > > > Dropping an email from the copyright line makes sense; dropping the > > Copyright declaration altogether is a bit odd (the GPL works only in > > tandem with a copyright assertion) - but as you are the author of the > > line and copyright holder of your contributions, I am not in a position > > to say you are wrong in removing it, only that it looks odd. > > > > Yeah, indeed. > > David, also note that you probably have been addressed because > scripts/get_maintainer.pl will look into the git history of files that > some > patch addresses and pick up significant and/or recent contributors from > there. > There should be some opt-out statement from that, but I don't recall how. > > Jan, Eblake, i respect your opinion but i still think my original patch would have been best fit for the simple me. > Jan > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux >
Jan Kiszka <jan.kiszka@siemens.com> writes:
> On 21.02.19 17:05, Eric Blake wrote:
>> On 2/21/19 9:53 AM, David Kiarie wrote:
>>> the occurrence of my name and email on the files below may have led to
>>> some confusion in the reporting of a few recent bugs.
>>>
>>> i have therefore choosen to snip it.
>>
>> Dropping an email from the copyright line makes sense; dropping the
>> Copyright declaration altogether is a bit odd (the GPL works only in
>> tandem with a copyright assertion) - but as you are the author of the
>> line and copyright holder of your contributions, I am not in a position
>> to say you are wrong in removing it, only that it looks odd.
>>
>
> Yeah, indeed.
>
> David, also note that you probably have been addressed because
> scripts/get_maintainer.pl will look into the git history of files that
> some patch addresses and pick up significant and/or recent
> contributors from there.
MAINTAINERS covers these files, so the most common use of
get_maintainer.pl won't list anyone not listed there:
$ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch]
Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86)
Richard Henderson <rth@twiddle.net> (maintainer:X86)
Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86)
"Michael S. Tsirkin" <mst@redhat.com> (supporter:PC)
Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC)
qemu-devel@nongnu.org (open list:All patches CC here)
David's contributions have aged out of --git:
$ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git
"Michael S. Tsirkin" <mst@redhat.com> (supporter:PC,commit_signer:12/7=100%,commit_signer:10/5=100%)
Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC)
Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86)
Richard Henderson <rth@twiddle.net> (maintainer:X86,commit_signer:1/7=14%)
Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86)
Peter Xu <peterx@redhat.com> (commit_signer:6/7=86%,commit_signer:4/5=80%)
Brijesh Singh <brijesh.singh@amd.com> (commit_signer:5/7=71%,commit_signer:4/5=80%)
"Alex Bennée" <alex.bennee@linaro.org> (commit_signer:1/7=14%)
Jan Kiszka <jan.kiszka@siemens.com> (commit_signer:1/5=20%)
qemu-devel@nongnu.org (open list:All patches CC here)
However, --git-blame still lists him:
$ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git-blame
Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86,commits:7/24=29%)
Richard Henderson <rth@twiddle.net> (maintainer:X86)
Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86,commits:7/24=29%)
"Michael S. Tsirkin" <mst@redhat.com> (supporter:PC,commits:26/24=100%,commits:14/8=100%)
Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC)
David Kiarie <davidkiarie4@gmail.com> (authored lines:1176/1645=71%,authored lines:274/373=73%)
Brijesh Singh <brijesh.singh@amd.com> (authored lines:403/1645=24%,authored lines:93/373=25%,commits:4/8=50%)
Peter Xu <peterx@redhat.com> (commits:10/24=42%,commits:4/8=50%)
David Gibson <david@gibson.dropbear.id.au> (commits:7/24=29%)
Jan Kiszka <jan.kiszka@siemens.com> (commits:1/8=12%)
Prasad J Pandit <pjp@fedoraproject.org> (commits:1/8=12%)
qemu-devel@nongnu.org (open list:All patches CC here)
--help admonishes:
Using "--git-blame" is slow and may add old committers and authors
that are no longer active maintainers to the output.
> There should be some opt-out statement from
> that, but I don't recall how.
I don't think get_maintainer.pl supports a blacklist of people who don't
want to be pestered anymore.
On 21.02.19 17:48, Markus Armbruster wrote: > Jan Kiszka <jan.kiszka@siemens.com> writes: > >> On 21.02.19 17:05, Eric Blake wrote: >>> On 2/21/19 9:53 AM, David Kiarie wrote: >>>> the occurrence of my name and email on the files below may have led to >>>> some confusion in the reporting of a few recent bugs. >>>> >>>> i have therefore choosen to snip it. >>> >>> Dropping an email from the copyright line makes sense; dropping the >>> Copyright declaration altogether is a bit odd (the GPL works only in >>> tandem with a copyright assertion) - but as you are the author of the >>> line and copyright holder of your contributions, I am not in a position >>> to say you are wrong in removing it, only that it looks odd. >>> >> >> Yeah, indeed. >> >> David, also note that you probably have been addressed because >> scripts/get_maintainer.pl will look into the git history of files that >> some patch addresses and pick up significant and/or recent >> contributors from there. > > MAINTAINERS covers these files, so the most common use of > get_maintainer.pl won't list anyone not listed there: > > $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] > Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86) > Richard Henderson <rth@twiddle.net> (maintainer:X86) > Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86) > "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC) > Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC) > qemu-devel@nongnu.org (open list:All patches CC here) > > David's contributions have aged out of --git: > > $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git > "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC,commit_signer:12/7=100%,commit_signer:10/5=100%) > Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC) > Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86) > Richard Henderson <rth@twiddle.net> (maintainer:X86,commit_signer:1/7=14%) > Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86) > Peter Xu <peterx@redhat.com> (commit_signer:6/7=86%,commit_signer:4/5=80%) > Brijesh Singh <brijesh.singh@amd.com> (commit_signer:5/7=71%,commit_signer:4/5=80%) > "Alex Bennée" <alex.bennee@linaro.org> (commit_signer:1/7=14%) > Jan Kiszka <jan.kiszka@siemens.com> (commit_signer:1/5=20%) > qemu-devel@nongnu.org (open list:All patches CC here) > > However, --git-blame still lists him: > > $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git-blame > Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86,commits:7/24=29%) > Richard Henderson <rth@twiddle.net> (maintainer:X86) > Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86,commits:7/24=29%) > "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC,commits:26/24=100%,commits:14/8=100%) > Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC) > David Kiarie <davidkiarie4@gmail.com> (authored lines:1176/1645=71%,authored lines:274/373=73%) > Brijesh Singh <brijesh.singh@amd.com> (authored lines:403/1645=24%,authored lines:93/373=25%,commits:4/8=50%) > Peter Xu <peterx@redhat.com> (commits:10/24=42%,commits:4/8=50%) > David Gibson <david@gibson.dropbear.id.au> (commits:7/24=29%) > Jan Kiszka <jan.kiszka@siemens.com> (commits:1/8=12%) > Prasad J Pandit <pjp@fedoraproject.org> (commits:1/8=12%) > qemu-devel@nongnu.org (open list:All patches CC here) > > --help admonishes: > > Using "--git-blame" is slow and may add old committers and authors > that are no longer active maintainers to the output. > >> There should be some opt-out statement from >> that, but I don't recall how. > > I don't think get_maintainer.pl supports a blacklist of people who don't > want to be pestered anymore. > # cat linux/.get_maintainer.ignore Christoph Hellwig <hch@lst.de> That's why I remembered it vaguely. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux
i will just drop the email. thanks.
Jan Kiszka <jan.kiszka@siemens.com> writes:
> On 21.02.19 17:48, Markus Armbruster wrote:
>> Jan Kiszka <jan.kiszka@siemens.com> writes:
>>
>>> On 21.02.19 17:05, Eric Blake wrote:
>>>> On 2/21/19 9:53 AM, David Kiarie wrote:
>>>>> the occurrence of my name and email on the files below may have led to
>>>>> some confusion in the reporting of a few recent bugs.
>>>>>
>>>>> i have therefore choosen to snip it.
>>>>
>>>> Dropping an email from the copyright line makes sense; dropping the
>>>> Copyright declaration altogether is a bit odd (the GPL works only in
>>>> tandem with a copyright assertion) - but as you are the author of the
>>>> line and copyright holder of your contributions, I am not in a position
>>>> to say you are wrong in removing it, only that it looks odd.
>>>>
>>>
>>> Yeah, indeed.
>>>
>>> David, also note that you probably have been addressed because
>>> scripts/get_maintainer.pl will look into the git history of files that
>>> some patch addresses and pick up significant and/or recent
>>> contributors from there.
>>
>> MAINTAINERS covers these files, so the most common use of
>> get_maintainer.pl won't list anyone not listed there:
>>
>> $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch]
>> Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86)
>> Richard Henderson <rth@twiddle.net> (maintainer:X86)
>> Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86)
>> "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC)
>> Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC)
>> qemu-devel@nongnu.org (open list:All patches CC here)
>>
>> David's contributions have aged out of --git:
>>
>> $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git
>> "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC,commit_signer:12/7=100%,commit_signer:10/5=100%)
>> Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC)
>> Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86)
>> Richard Henderson <rth@twiddle.net> (maintainer:X86,commit_signer:1/7=14%)
>> Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86)
>> Peter Xu <peterx@redhat.com> (commit_signer:6/7=86%,commit_signer:4/5=80%)
>> Brijesh Singh <brijesh.singh@amd.com> (commit_signer:5/7=71%,commit_signer:4/5=80%)
>> "Alex Bennée" <alex.bennee@linaro.org> (commit_signer:1/7=14%)
>> Jan Kiszka <jan.kiszka@siemens.com> (commit_signer:1/5=20%)
>> qemu-devel@nongnu.org (open list:All patches CC here)
>>
>> However, --git-blame still lists him:
>>
>> $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git-blame
>> Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86,commits:7/24=29%)
>> Richard Henderson <rth@twiddle.net> (maintainer:X86)
>> Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86,commits:7/24=29%)
>> "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC,commits:26/24=100%,commits:14/8=100%)
>> Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC)
>> David Kiarie <davidkiarie4@gmail.com> (authored lines:1176/1645=71%,authored lines:274/373=73%)
>> Brijesh Singh <brijesh.singh@amd.com> (authored lines:403/1645=24%,authored lines:93/373=25%,commits:4/8=50%)
>> Peter Xu <peterx@redhat.com> (commits:10/24=42%,commits:4/8=50%)
>> David Gibson <david@gibson.dropbear.id.au> (commits:7/24=29%)
>> Jan Kiszka <jan.kiszka@siemens.com> (commits:1/8=12%)
>> Prasad J Pandit <pjp@fedoraproject.org> (commits:1/8=12%)
>> qemu-devel@nongnu.org (open list:All patches CC here)
>>
>> --help admonishes:
>>
>> Using "--git-blame" is slow and may add old committers and authors
>> that are no longer active maintainers to the output.
>>
>>> There should be some opt-out statement from
>>> that, but I don't recall how.
>>
>> I don't think get_maintainer.pl supports a blacklist of people who don't
>> want to be pestered anymore.
>>
>
> # cat linux/.get_maintainer.ignore
> Christoph Hellwig <hch@lst.de>
>
> That's why I remembered it vaguely.
Ah!
commit 435de0782b658c993350049e853ea9a8795df4e2
Author: Joe Perches <joe@perches.com>
Date: Thu Jun 25 15:01:50 2015 -0700
get_maintainer.pl: add .get_maintainer.ignore file capability
Some people prefer not to be cc'd on patches. Add an ability to have a
file (.get_maintainer.ignore) with names and email addresses that are
excluded from being listed except when specifically listed as a maintainer
in a section.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Can we resync with the kernel's script to get this feature? Or should
we cherry-pick it?
On 2/21/19 6:13 PM, Markus Armbruster wrote: > Jan Kiszka <jan.kiszka@siemens.com> writes: > >> On 21.02.19 17:48, Markus Armbruster wrote: >>> Jan Kiszka <jan.kiszka@siemens.com> writes: >>> >>>> On 21.02.19 17:05, Eric Blake wrote: >>>>> On 2/21/19 9:53 AM, David Kiarie wrote: >>>>>> the occurrence of my name and email on the files below may have led to >>>>>> some confusion in the reporting of a few recent bugs. >>>>>> >>>>>> i have therefore choosen to snip it. >>>>> >>>>> Dropping an email from the copyright line makes sense; dropping the >>>>> Copyright declaration altogether is a bit odd (the GPL works only in >>>>> tandem with a copyright assertion) - but as you are the author of the >>>>> line and copyright holder of your contributions, I am not in a position >>>>> to say you are wrong in removing it, only that it looks odd. >>>>> >>>> >>>> Yeah, indeed. >>>> >>>> David, also note that you probably have been addressed because >>>> scripts/get_maintainer.pl will look into the git history of files that >>>> some patch addresses and pick up significant and/or recent >>>> contributors from there. >>> >>> MAINTAINERS covers these files, so the most common use of >>> get_maintainer.pl won't list anyone not listed there: >>> >>> $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] >>> Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86) >>> Richard Henderson <rth@twiddle.net> (maintainer:X86) >>> Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86) >>> "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC) >>> Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC) >>> qemu-devel@nongnu.org (open list:All patches CC here) >>> >>> David's contributions have aged out of --git: >>> >>> $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git >>> "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC,commit_signer:12/7=100%,commit_signer:10/5=100%) >>> Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC) >>> Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86) >>> Richard Henderson <rth@twiddle.net> (maintainer:X86,commit_signer:1/7=14%) >>> Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86) >>> Peter Xu <peterx@redhat.com> (commit_signer:6/7=86%,commit_signer:4/5=80%) >>> Brijesh Singh <brijesh.singh@amd.com> (commit_signer:5/7=71%,commit_signer:4/5=80%) >>> "Alex Bennée" <alex.bennee@linaro.org> (commit_signer:1/7=14%) >>> Jan Kiszka <jan.kiszka@siemens.com> (commit_signer:1/5=20%) >>> qemu-devel@nongnu.org (open list:All patches CC here) >>> >>> However, --git-blame still lists him: >>> >>> $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git-blame >>> Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86,commits:7/24=29%) >>> Richard Henderson <rth@twiddle.net> (maintainer:X86) >>> Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86,commits:7/24=29%) >>> "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC,commits:26/24=100%,commits:14/8=100%) >>> Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC) >>> David Kiarie <davidkiarie4@gmail.com> (authored lines:1176/1645=71%,authored lines:274/373=73%) >>> Brijesh Singh <brijesh.singh@amd.com> (authored lines:403/1645=24%,authored lines:93/373=25%,commits:4/8=50%) >>> Peter Xu <peterx@redhat.com> (commits:10/24=42%,commits:4/8=50%) >>> David Gibson <david@gibson.dropbear.id.au> (commits:7/24=29%) >>> Jan Kiszka <jan.kiszka@siemens.com> (commits:1/8=12%) >>> Prasad J Pandit <pjp@fedoraproject.org> (commits:1/8=12%) >>> qemu-devel@nongnu.org (open list:All patches CC here) >>> >>> --help admonishes: >>> >>> Using "--git-blame" is slow and may add old committers and authors >>> that are no longer active maintainers to the output. >>> >>>> There should be some opt-out statement from >>>> that, but I don't recall how. >>> >>> I don't think get_maintainer.pl supports a blacklist of people who don't >>> want to be pestered anymore. >>> >> >> # cat linux/.get_maintainer.ignore >> Christoph Hellwig <hch@lst.de> >> >> That's why I remembered it vaguely. > > Ah! > > commit 435de0782b658c993350049e853ea9a8795df4e2 > Author: Joe Perches <joe@perches.com> > Date: Thu Jun 25 15:01:50 2015 -0700 > > get_maintainer.pl: add .get_maintainer.ignore file capability > > Some people prefer not to be cc'd on patches. Add an ability to have a > file (.get_maintainer.ignore) with names and email addresses that are > excluded from being listed except when specifically listed as a maintainer > in a section. > > Signed-off-by: Joe Perches <joe@perches.com> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> > > Can we resync with the kernel's script to get this feature? Or should > we cherry-pick it? I think we are out-of-sync and only cherry-picking.
On Thu, Feb 21, 2019 at 8:35 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > On 2/21/19 6:13 PM, Markus Armbruster wrote: > > > > > Can we resync with the kernel's script to get this feature? Or should > > we cherry-pick it? > > I think we are out-of-sync and only cherry-picking. > you can do this if you so wish but i am personally okay with the follow up patch i sent.
Patchew URL: https://patchew.org/QEMU/20190221155359.8247-1-davidkiarie4@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190221155359.8247-1-davidkiarie4@gmail.com Subject: [Qemu-devel] [PATCH 0/1] snip my name and email Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 3840647010 hw/i386: snip my name and email === OUTPUT BEGIN === ERROR: Missing Signed-off-by: line(s) total: 1 errors, 0 warnings, 14 lines checked Commit 384064701074 (hw/i386: snip my name and email) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190221155359.8247-1-davidkiarie4@gmail.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
© 2016 - 2026 Red Hat, Inc.