iotests: drop unnecessary accel=kvm in 238

[Qemu-devel] [PATCH v2] iotests: drop unnecessary accel=kvm in 238

Posted by Stefan Hajnoczi 6 years, 8 months ago

Test 238 does not require the kvm accelerator.  TCG works fine.

Use the default accelerator instead of requiring kvm.

Suggested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
Vladimir, I have dropped the 235 change because I don't have time to
figure out the kvm/tcg vs qtest differences or add a skip function.
Sorry!

 tests/qemu-iotests/238 | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/qemu-iotests/238 b/tests/qemu-iotests/238
index f81ee1112f..e490bb4298 100755
--- a/tests/qemu-iotests/238
+++ b/tests/qemu-iotests/238
@@ -33,7 +33,6 @@ else:
     virtio_scsi_device = 'virtio-scsi-pci'
 
 vm = QEMUMachine(iotests.qemu_prog)
-vm.add_args('-machine', 'accel=kvm')
 vm.launch()
 
 log(vm.qmp('blockdev-add', node_name='hd0', driver='null-co'))
-- 
2.20.1

Re: [Qemu-devel] [PATCH v2] iotests: drop unnecessary accel=kvm in 238

Posted by Thomas Huth 6 years, 8 months ago

On 21/02/2019 11.11, Stefan Hajnoczi wrote:
> Test 238 does not require the kvm accelerator.  TCG works fine.
> 
> Use the default accelerator instead of requiring kvm.
> 
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> Vladimir, I have dropped the 235 change because I don't have time to
> figure out the kvm/tcg vs qtest differences or add a skip function.
> Sorry!
> 
>  tests/qemu-iotests/238 | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/238 b/tests/qemu-iotests/238
> index f81ee1112f..e490bb4298 100755
> --- a/tests/qemu-iotests/238
> +++ b/tests/qemu-iotests/238
> @@ -33,7 +33,6 @@ else:
>      virtio_scsi_device = 'virtio-scsi-pci'
>  
>  vm = QEMUMachine(iotests.qemu_prog)
> -vm.add_args('-machine', 'accel=kvm')

Would it be feasible to change it into "accel=qtest" instead? ... then
this test would also work when QEMU has been compiled with --disable-tcg
and when KVM is not available...

 Thomas

Re: [Qemu-devel] [PATCH v2] iotests: drop unnecessary accel=kvm in 238

Posted by Stefan Hajnoczi 6 years, 8 months ago

On Thu, Feb 21, 2019 at 11:24:12AM +0100, Thomas Huth wrote:
> On 21/02/2019 11.11, Stefan Hajnoczi wrote:
> > Test 238 does not require the kvm accelerator.  TCG works fine.
> > 
> > Use the default accelerator instead of requiring kvm.
> > 
> > Suggested-by: Thomas Huth <thuth@redhat.com>
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > Vladimir, I have dropped the 235 change because I don't have time to
> > figure out the kvm/tcg vs qtest differences or add a skip function.
> > Sorry!
> > 
> >  tests/qemu-iotests/238 | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/tests/qemu-iotests/238 b/tests/qemu-iotests/238
> > index f81ee1112f..e490bb4298 100755
> > --- a/tests/qemu-iotests/238
> > +++ b/tests/qemu-iotests/238
> > @@ -33,7 +33,6 @@ else:
> >      virtio_scsi_device = 'virtio-scsi-pci'
> >  
> >  vm = QEMUMachine(iotests.qemu_prog)
> > -vm.add_args('-machine', 'accel=kvm')
> 
> Would it be feasible to change it into "accel=qtest" instead? ... then
> this test would also work when QEMU has been compiled with --disable-tcg
> and when KVM is not available...

Sure.  I have tested that qtest still triggered the bug when the fix was
merged.

Will fix in v3.

Stefan