[v1] testing/next

[Qemu-devel] [PATCH v1 8/8] tests/softfloat: always do quick softfloat tests

Posted by Alex Bennée 6 years, 8 months ago

Some operations take a long time and enabling "-l 2 -r all" can take
more than a day which is stretching the definition of a "slow" test.
Lets default to the quick test and leave a note for those who wish to
run by hand.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/Makefile.include | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tests/Makefile.include b/tests/Makefile.include
index b39e989f72..3741f8f6dd 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -896,11 +896,9 @@ $(FP_TEST_BIN):
 	         "BUILD", "$(notdir $@)")
 
 # The full test suite can take a bit of time, default to a quick run
-ifeq ($(SPEED), quick)
+# "-l 2 -r all" can take more than a day for some operations and is best
+# run manually
 FP_TL=-l 1
-else
-FP_TL=-l 2 -r all
-endif
 
 # $1 = tests, $2 = description
 test-softfloat = $(call quiet-command, \
-- 
2.20.1

Re: [Qemu-devel] [PATCH v1 8/8] tests/softfloat: always do quick softfloat tests

Posted by Richard Henderson 6 years, 8 months ago

On 2/20/19 9:28 AM, Alex Bennée wrote:
> Some operations take a long time and enabling "-l 2 -r all" can take
> more than a day which is stretching the definition of a "slow" test.
> Lets default to the quick test and leave a note for those who wish to
> run by hand.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  tests/Makefile.include | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~