ppc/xive: xive does not have a POWER7 interrupt model

[Qemu-devel] [PATCH] ppc/xive: xive does not have a POWER7 interrupt model

Posted by Cédric Le Goater 5 years, 2 months ago

Patch "target/ppc: Add POWER9 external interrupt model" should have
removed the section covering PPC_FLAGS_INPUT_POWER7.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 hw/intc/xive.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/hw/intc/xive.c b/hw/intc/xive.c
index 425aa97ef9f6..daa7badc8492 100644
--- a/hw/intc/xive.c
+++ b/hw/intc/xive.c
@@ -481,9 +481,6 @@ static void xive_tctx_realize(DeviceState *dev, Error **errp)
 
     env = &cpu->env;
     switch (PPC_INPUT(env)) {
-    case PPC_FLAGS_INPUT_POWER7:
-        tctx->output = env->irq_inputs[POWER7_INPUT_INT];
-        break;
     case PPC_FLAGS_INPUT_POWER9:
         tctx->output = env->irq_inputs[POWER9_INPUT_INT];
         break;
-- 
2.20.1

Re: [Qemu-devel] [PATCH] ppc/xive: xive does not have a POWER7 interrupt model

Posted by David Gibson 5 years, 2 months ago

On Tue, Feb 19, 2019 at 03:25:30PM +0100, Cédric Le Goater wrote:
> Patch "target/ppc: Add POWER9 external interrupt model" should have
> removed the section covering PPC_FLAGS_INPUT_POWER7.
> 
> Signed-off-by: Cédric Le Goater <clg@kaod.org>

Applied to ppc-for-4.0, thanks.

> ---
>  hw/intc/xive.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/hw/intc/xive.c b/hw/intc/xive.c
> index 425aa97ef9f6..daa7badc8492 100644
> --- a/hw/intc/xive.c
> +++ b/hw/intc/xive.c
> @@ -481,9 +481,6 @@ static void xive_tctx_realize(DeviceState *dev, Error **errp)
>  
>      env = &cpu->env;
>      switch (PPC_INPUT(env)) {
> -    case PPC_FLAGS_INPUT_POWER7:
> -        tctx->output = env->irq_inputs[POWER7_INPUT_INT];
> -        break;
>      case PPC_FLAGS_INPUT_POWER9:
>          tctx->output = env->irq_inputs[POWER9_INPUT_INT];
>          break;

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson