hw/arm/collie.c | 9 +- hw/arm/digic_boards.c | 3 +- hw/arm/gumstix.c | 8 +- hw/arm/mainstone.c | 4 +- hw/arm/musicpal.c | 8 +- hw/arm/omap_sx1.c | 8 +- hw/arm/versatilepb.c | 3 +- hw/arm/vexpress.c | 30 ++---- hw/arm/virt.c | 27 ++--- hw/arm/xilinx_zynq.c | 5 +- hw/arm/z2.c | 5 +- hw/block/pflash_cfi01.c | 120 ++++++++++++----------- hw/block/pflash_cfi02.c | 69 ++++++------- hw/i386/pc_sysfw.c | 10 +- hw/lm32/lm32_boards.c | 8 +- hw/lm32/milkymist.c | 4 +- hw/microblaze/petalogix_ml605_mmu.c | 5 +- hw/microblaze/petalogix_s3adsp1800_mmu.c | 4 +- hw/mips/mips_malta.c | 15 ++- hw/mips/mips_r4k.c | 4 +- hw/ppc/ppc405_boards.c | 59 ++++------- hw/ppc/sam460ex.c | 23 ++--- hw/ppc/virtex_ml507.c | 4 +- hw/sh4/r2d.c | 11 ++- hw/xtensa/xtfpga.c | 26 +++-- include/hw/block/flash.h | 65 +++++++----- 26 files changed, 258 insertions(+), 279 deletions(-)
Alex Bennée posted this patch to address an XXX comment in
pflash_cfi01_realize() the other day:
Subject: [PATCH v2] hw/block: report when pflash backing file isn't aligned
Message-Id: <20190215122808.22301-1-alex.bennee@linaro.org>
https://lists.nongnu.org/archive/html/qemu-devel/2019-02/msg04166.html
Review led me to look into its callers. Most of them are pleasantly
boring: they create flash memory of some fixed size at some fixed
address. A few are more creative, and some of the creative ones look
quite broken to me. Fix them, and clean up some along the way.
Markus Armbruster (10):
pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02
pflash: Macro PFLASH_BUG() is used just once, expand
hw: Use CFI_PFLASH0{1,2} and TYPE_CFI_PFLASH0{1,2}
sam460ex: Don't size flash memory to match backing image
ppc405_boards: Don't size flash memory to match backing image
r2d: Flash memory creation is confused about size, mark FIXME
mips_malta: Clean up definition of flash memory size somewhat
pflash: Clean up after commit 368a354f02b part 1
pflash: Clean up after commit 368a354f02b part 2
hw/arm hw/xtensa: De-duplicate pflash creation code some
hw/arm/collie.c | 9 +-
hw/arm/digic_boards.c | 3 +-
hw/arm/gumstix.c | 8 +-
hw/arm/mainstone.c | 4 +-
hw/arm/musicpal.c | 8 +-
hw/arm/omap_sx1.c | 8 +-
hw/arm/versatilepb.c | 3 +-
hw/arm/vexpress.c | 30 ++----
hw/arm/virt.c | 27 ++---
hw/arm/xilinx_zynq.c | 5 +-
hw/arm/z2.c | 5 +-
hw/block/pflash_cfi01.c | 120 ++++++++++++-----------
hw/block/pflash_cfi02.c | 69 ++++++-------
hw/i386/pc_sysfw.c | 10 +-
hw/lm32/lm32_boards.c | 8 +-
hw/lm32/milkymist.c | 4 +-
hw/microblaze/petalogix_ml605_mmu.c | 5 +-
hw/microblaze/petalogix_s3adsp1800_mmu.c | 4 +-
hw/mips/mips_malta.c | 15 ++-
hw/mips/mips_r4k.c | 4 +-
hw/ppc/ppc405_boards.c | 59 ++++-------
hw/ppc/sam460ex.c | 23 ++---
hw/ppc/virtex_ml507.c | 4 +-
hw/sh4/r2d.c | 11 ++-
hw/xtensa/xtfpga.c | 26 +++--
include/hw/block/flash.h | 65 +++++++-----
26 files changed, 258 insertions(+), 279 deletions(-)
--
2.17.2
Patchew URL: https://patchew.org/QEMU/20190218125615.18970-1-armbru@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190218125615.18970-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
03f9a76b8c hw/arm hw/xtensa: De-duplicate pflash creation code some
4e432c01fe pflash: Clean up after commit 368a354f02b part 2
bd61cf81c3 pflash: Clean up after commit 368a354f02b part 1
31e9871f71 mips_malta: Clean up definition of flash memory size somewhat
66c8ac0932 r2d: Flash memory creation is confused about size, mark FIXME
857cd68a50 ppc405_boards: Don't size flash memory to match backing image
170a8ce912 sam460ex: Don't size flash memory to match backing image
aa2df2f4fd hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2}
588d5b718c pflash: Macro PFLASH_BUG() is used just once, expand
f4339a63b6 pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02
=== OUTPUT BEGIN ===
1/10 Checking commit f4339a63b6dd (pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02)
ERROR: space prohibited between function name and open parenthesis '('
#127: FILE: hw/block/pflash_cfi01.c:288:
+static uint32_t pflash_read (PFlashCFI01 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#339: FILE: hw/block/pflash_cfi02.c:141:
+static uint32_t pflash_read (PFlashCFI02 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#357: FILE: hw/block/pflash_cfi02.c:264:
+static void pflash_write (PFlashCFI02 *pfl, hwaddr offset,
total: 3 errors, 0 warnings, 483 lines checked
Patch 1/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/10 Checking commit 588d5b718cc4 (pflash: Macro PFLASH_BUG() is used just once, expand)
3/10 Checking commit aa2df2f4fd70 (hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2})
4/10 Checking commit 170a8ce912fd (sam460ex: Don't size flash memory to match backing image)
5/10 Checking commit 857cd68a500d (ppc405_boards: Don't size flash memory to match backing image)
6/10 Checking commit 66c8ac09327b (r2d: Flash memory creation is confused about size, mark FIXME)
7/10 Checking commit 31e9871f7159 (mips_malta: Clean up definition of flash memory size somewhat)
8/10 Checking commit bd61cf81c38f (pflash: Clean up after commit 368a354f02b part 1)
ERROR: spaces required around that '-' (ctx:VxV)
#89: FILE: hw/arm/musicpal.c:1639:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
ERROR: spaces required around that '-' (ctx:VxV)
#97: FILE: hw/arm/musicpal.c:1646:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
total: 2 errors, 0 warnings, 248 lines checked
Patch 8/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/10 Checking commit 4e432c01fea3 (pflash: Clean up after commit 368a354f02b part 2)
10/10 Checking commit 03f9a76b8cbd (hw/arm hw/xtensa: De-duplicate pflash creation code some)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190218125615.18970-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190218125615.18970-1-armbru@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190218125615.18970-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/20190218125615.18970-1-armbru@redhat.com -> patchew/20190218125615.18970-1-armbru@redhat.com
Switched to a new branch 'test'
9a994e41a5 hw/arm hw/xtensa: De-duplicate pflash creation code some
303fbacd55 pflash: Clean up after commit 368a354f02b part 2
3f16bf66bc pflash: Clean up after commit 368a354f02b part 1
3e2ae31e84 mips_malta: Clean up definition of flash memory size somewhat
d0652958b7 r2d: Flash memory creation is confused about size, mark FIXME
f26f2e4d2d ppc405_boards: Don't size flash memory to match backing image
e5dd4a33f5 sam460ex: Don't size flash memory to match backing image
2eec664e4d hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2}
83da6876dd pflash: Macro PFLASH_BUG() is used just once, expand
0b9075ea6a pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02
=== OUTPUT BEGIN ===
1/10 Checking commit 0b9075ea6a77 (pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02)
ERROR: space prohibited between function name and open parenthesis '('
#128: FILE: hw/block/pflash_cfi01.c:288:
+static uint32_t pflash_read (PFlashCFI01 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#340: FILE: hw/block/pflash_cfi02.c:141:
+static uint32_t pflash_read (PFlashCFI02 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#358: FILE: hw/block/pflash_cfi02.c:264:
+static void pflash_write (PFlashCFI02 *pfl, hwaddr offset,
total: 3 errors, 0 warnings, 483 lines checked
Patch 1/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/10 Checking commit 83da6876dd88 (pflash: Macro PFLASH_BUG() is used just once, expand)
3/10 Checking commit 2eec664e4dcd (hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2})
4/10 Checking commit e5dd4a33f5aa (sam460ex: Don't size flash memory to match backing image)
5/10 Checking commit f26f2e4d2d3f (ppc405_boards: Don't size flash memory to match backing image)
6/10 Checking commit d0652958b7c8 (r2d: Flash memory creation is confused about size, mark FIXME)
7/10 Checking commit 3e2ae31e8434 (mips_malta: Clean up definition of flash memory size somewhat)
8/10 Checking commit 3f16bf66bce3 (pflash: Clean up after commit 368a354f02b part 1)
ERROR: spaces required around that '-' (ctx:VxV)
#90: FILE: hw/arm/musicpal.c:1639:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
ERROR: spaces required around that '-' (ctx:VxV)
#98: FILE: hw/arm/musicpal.c:1646:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
total: 2 errors, 0 warnings, 248 lines checked
Patch 8/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/10 Checking commit 303fbacd5529 (pflash: Clean up after commit 368a354f02b part 2)
10/10 Checking commit 9a994e41a577 (hw/arm hw/xtensa: De-duplicate pflash creation code some)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190218125615.18970-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190218125615.18970-1-armbru@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190218125615.18970-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/20190218125615.18970-1-armbru@redhat.com -> patchew/20190218125615.18970-1-armbru@redhat.com
Switched to a new branch 'test'
8f917fc996 hw/arm hw/xtensa: De-duplicate pflash creation code some
f63eecee6c pflash: Clean up after commit 368a354f02b part 2
3b2230a827 pflash: Clean up after commit 368a354f02b part 1
f96fda82f8 mips_malta: Clean up definition of flash memory size somewhat
0d2c655ad8 r2d: Flash memory creation is confused about size, mark FIXME
72f3fec4c4 ppc405_boards: Don't size flash memory to match backing image
257f0ac71c sam460ex: Don't size flash memory to match backing image
ec2b9e19b1 hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2}
f1122cc4d9 pflash: Macro PFLASH_BUG() is used just once, expand
f1832c9809 pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02
=== OUTPUT BEGIN ===
1/10 Checking commit f1832c9809fd (pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02)
ERROR: space prohibited between function name and open parenthesis '('
#128: FILE: hw/block/pflash_cfi01.c:288:
+static uint32_t pflash_read (PFlashCFI01 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#340: FILE: hw/block/pflash_cfi02.c:141:
+static uint32_t pflash_read (PFlashCFI02 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#358: FILE: hw/block/pflash_cfi02.c:264:
+static void pflash_write (PFlashCFI02 *pfl, hwaddr offset,
total: 3 errors, 0 warnings, 483 lines checked
Patch 1/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/10 Checking commit f1122cc4d99f (pflash: Macro PFLASH_BUG() is used just once, expand)
3/10 Checking commit ec2b9e19b179 (hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2})
4/10 Checking commit 257f0ac71c81 (sam460ex: Don't size flash memory to match backing image)
5/10 Checking commit 72f3fec4c495 (ppc405_boards: Don't size flash memory to match backing image)
6/10 Checking commit 0d2c655ad826 (r2d: Flash memory creation is confused about size, mark FIXME)
7/10 Checking commit f96fda82f805 (mips_malta: Clean up definition of flash memory size somewhat)
8/10 Checking commit 3b2230a827ee (pflash: Clean up after commit 368a354f02b part 1)
ERROR: spaces required around that '-' (ctx:VxV)
#90: FILE: hw/arm/musicpal.c:1639:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
ERROR: spaces required around that '-' (ctx:VxV)
#98: FILE: hw/arm/musicpal.c:1646:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
total: 2 errors, 0 warnings, 248 lines checked
Patch 8/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/10 Checking commit f63eecee6c91 (pflash: Clean up after commit 368a354f02b part 2)
10/10 Checking commit 8f917fc9969e (hw/arm hw/xtensa: De-duplicate pflash creation code some)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190218125615.18970-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190218125615.18970-1-armbru@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190218125615.18970-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/20190218125615.18970-1-armbru@redhat.com -> patchew/20190218125615.18970-1-armbru@redhat.com
Switched to a new branch 'test'
7003d72a5f hw/arm hw/xtensa: De-duplicate pflash creation code some
0f5bb14893 pflash: Clean up after commit 368a354f02b part 2
0ddfc52fb8 pflash: Clean up after commit 368a354f02b part 1
a88cfc5bbf mips_malta: Clean up definition of flash memory size somewhat
06b58eb0a8 r2d: Flash memory creation is confused about size, mark FIXME
fd280c6abc ppc405_boards: Don't size flash memory to match backing image
85a5bb56ec sam460ex: Don't size flash memory to match backing image
4f66728f2f hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2}
368c51060a pflash: Macro PFLASH_BUG() is used just once, expand
209d90e8f1 pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02
=== OUTPUT BEGIN ===
1/10 Checking commit 209d90e8f163 (pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02)
ERROR: space prohibited between function name and open parenthesis '('
#128: FILE: hw/block/pflash_cfi01.c:288:
+static uint32_t pflash_read (PFlashCFI01 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#340: FILE: hw/block/pflash_cfi02.c:141:
+static uint32_t pflash_read (PFlashCFI02 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#358: FILE: hw/block/pflash_cfi02.c:264:
+static void pflash_write (PFlashCFI02 *pfl, hwaddr offset,
total: 3 errors, 0 warnings, 483 lines checked
Patch 1/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/10 Checking commit 368c51060aff (pflash: Macro PFLASH_BUG() is used just once, expand)
3/10 Checking commit 4f66728f2f5a (hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2})
4/10 Checking commit 85a5bb56ec18 (sam460ex: Don't size flash memory to match backing image)
5/10 Checking commit fd280c6abca7 (ppc405_boards: Don't size flash memory to match backing image)
6/10 Checking commit 06b58eb0a8e9 (r2d: Flash memory creation is confused about size, mark FIXME)
7/10 Checking commit a88cfc5bbf98 (mips_malta: Clean up definition of flash memory size somewhat)
8/10 Checking commit 0ddfc52fb852 (pflash: Clean up after commit 368a354f02b part 1)
ERROR: spaces required around that '-' (ctx:VxV)
#90: FILE: hw/arm/musicpal.c:1639:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
ERROR: spaces required around that '-' (ctx:VxV)
#98: FILE: hw/arm/musicpal.c:1646:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
total: 2 errors, 0 warnings, 248 lines checked
Patch 8/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/10 Checking commit 0f5bb148930a (pflash: Clean up after commit 368a354f02b part 2)
10/10 Checking commit 7003d72a5f0f (hw/arm hw/xtensa: De-duplicate pflash creation code some)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190218125615.18970-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190218125615.18970-1-armbru@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190218125615.18970-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20190218125615.18970-1-armbru@redhat.com -> patchew/20190218125615.18970-1-armbru@redhat.com
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'a5b428e1c1eae703bdd62a3f527223c291ee3fdc'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out '3464681b2b5983df80086a40179d324102347da3'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
7003d72 hw/arm hw/xtensa: De-duplicate pflash creation code some
0f5bb14 pflash: Clean up after commit 368a354f02b part 2
0ddfc52 pflash: Clean up after commit 368a354f02b part 1
a88cfc5 mips_malta: Clean up definition of flash memory size somewhat
06b58eb r2d: Flash memory creation is confused about size, mark FIXME
fd280c6 ppc405_boards: Don't size flash memory to match backing image
85a5bb5 sam460ex: Don't size flash memory to match backing image
4f66728 hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2}
368c510 pflash: Macro PFLASH_BUG() is used just once, expand
209d90e pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02
=== OUTPUT BEGIN ===
1/10 Checking commit 209d90e8f163 (pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02)
ERROR: space prohibited between function name and open parenthesis '('
#128: FILE: hw/block/pflash_cfi01.c:288:
+static uint32_t pflash_read (PFlashCFI01 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#340: FILE: hw/block/pflash_cfi02.c:141:
+static uint32_t pflash_read (PFlashCFI02 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#358: FILE: hw/block/pflash_cfi02.c:264:
+static void pflash_write (PFlashCFI02 *pfl, hwaddr offset,
total: 3 errors, 0 warnings, 483 lines checked
Patch 1/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/10 Checking commit 368c51060aff (pflash: Macro PFLASH_BUG() is used just once, expand)
3/10 Checking commit 4f66728f2f5a (hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2})
4/10 Checking commit 85a5bb56ec18 (sam460ex: Don't size flash memory to match backing image)
5/10 Checking commit fd280c6abca7 (ppc405_boards: Don't size flash memory to match backing image)
6/10 Checking commit 06b58eb0a8e9 (r2d: Flash memory creation is confused about size, mark FIXME)
7/10 Checking commit a88cfc5bbf98 (mips_malta: Clean up definition of flash memory size somewhat)
8/10 Checking commit 0ddfc52fb852 (pflash: Clean up after commit 368a354f02b part 1)
ERROR: spaces required around that '-' (ctx:VxV)
#90: FILE: hw/arm/musicpal.c:1639:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
ERROR: spaces required around that '-' (ctx:VxV)
#98: FILE: hw/arm/musicpal.c:1646:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
total: 2 errors, 0 warnings, 248 lines checked
Patch 8/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/10 Checking commit 0f5bb148930a (pflash: Clean up after commit 368a354f02b part 2)
10/10 Checking commit 7003d72a5f0f (hw/arm hw/xtensa: De-duplicate pflash creation code some)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190218125615.18970-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190218125615.18970-1-armbru@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190218125615.18970-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/20190218125615.18970-1-armbru@redhat.com -> patchew/20190218125615.18970-1-armbru@redhat.com
t [tag update] patchew/20190219060719.8211-1-richardw.yang@linux.intel.com -> patchew/20190219060719.8211-1-richardw.yang@linux.intel.com
* [new tag] patchew/20190219124257.3001-1-kraxel@redhat.com -> patchew/20190219124257.3001-1-kraxel@redhat.com
Switched to a new branch 'test'
eadbdde93b hw/arm hw/xtensa: De-duplicate pflash creation code some
66b962dbf3 pflash: Clean up after commit 368a354f02b part 2
5284500a74 pflash: Clean up after commit 368a354f02b part 1
09d2c4a708 mips_malta: Clean up definition of flash memory size somewhat
370f0b5929 r2d: Flash memory creation is confused about size, mark FIXME
a44365fece ppc405_boards: Don't size flash memory to match backing image
e6dcc28b89 sam460ex: Don't size flash memory to match backing image
b554480ef5 hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2}
d750905bcc pflash: Macro PFLASH_BUG() is used just once, expand
ec3e8745cd pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02
=== OUTPUT BEGIN ===
1/10 Checking commit ec3e8745cdd8 (pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02)
ERROR: space prohibited between function name and open parenthesis '('
#128: FILE: hw/block/pflash_cfi01.c:288:
+static uint32_t pflash_read (PFlashCFI01 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#340: FILE: hw/block/pflash_cfi02.c:141:
+static uint32_t pflash_read (PFlashCFI02 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#358: FILE: hw/block/pflash_cfi02.c:264:
+static void pflash_write (PFlashCFI02 *pfl, hwaddr offset,
total: 3 errors, 0 warnings, 483 lines checked
Patch 1/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/10 Checking commit d750905bcc59 (pflash: Macro PFLASH_BUG() is used just once, expand)
3/10 Checking commit b554480ef5e6 (hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2})
4/10 Checking commit e6dcc28b8994 (sam460ex: Don't size flash memory to match backing image)
5/10 Checking commit a44365fece7c (ppc405_boards: Don't size flash memory to match backing image)
6/10 Checking commit 370f0b59294b (r2d: Flash memory creation is confused about size, mark FIXME)
7/10 Checking commit 09d2c4a70817 (mips_malta: Clean up definition of flash memory size somewhat)
8/10 Checking commit 5284500a7468 (pflash: Clean up after commit 368a354f02b part 1)
ERROR: spaces required around that '-' (ctx:VxV)
#90: FILE: hw/arm/musicpal.c:1639:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
ERROR: spaces required around that '-' (ctx:VxV)
#98: FILE: hw/arm/musicpal.c:1646:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
total: 2 errors, 0 warnings, 248 lines checked
Patch 8/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/10 Checking commit 66b962dbf392 (pflash: Clean up after commit 368a354f02b part 2)
10/10 Checking commit eadbdde93b39 (hw/arm hw/xtensa: De-duplicate pflash creation code some)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190218125615.18970-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190218125615.18970-1-armbru@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190218125615.18970-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
03998181d5 hw/arm hw/xtensa: De-duplicate pflash creation code some
8900ef3eb2 pflash: Clean up after commit 368a354f02b part 2
b2a752e969 pflash: Clean up after commit 368a354f02b part 1
6161e9b2e1 mips_malta: Clean up definition of flash memory size somewhat
f63e1b95be r2d: Flash memory creation is confused about size, mark FIXME
c940613c6f ppc405_boards: Don't size flash memory to match backing image
aafbf2b0cb sam460ex: Don't size flash memory to match backing image
50c58aaaef hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2}
32f306be23 pflash: Macro PFLASH_BUG() is used just once, expand
ab1e43ce7b pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02
=== OUTPUT BEGIN ===
1/10 Checking commit ab1e43ce7b8b (pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02)
ERROR: space prohibited between function name and open parenthesis '('
#128: FILE: hw/block/pflash_cfi01.c:288:
+static uint32_t pflash_read (PFlashCFI01 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#340: FILE: hw/block/pflash_cfi02.c:141:
+static uint32_t pflash_read (PFlashCFI02 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#358: FILE: hw/block/pflash_cfi02.c:264:
+static void pflash_write (PFlashCFI02 *pfl, hwaddr offset,
total: 3 errors, 0 warnings, 483 lines checked
Patch 1/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/10 Checking commit 32f306be2381 (pflash: Macro PFLASH_BUG() is used just once, expand)
3/10 Checking commit 50c58aaaeff5 (hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2})
4/10 Checking commit aafbf2b0cbd5 (sam460ex: Don't size flash memory to match backing image)
5/10 Checking commit c940613c6fd9 (ppc405_boards: Don't size flash memory to match backing image)
6/10 Checking commit f63e1b95beaf (r2d: Flash memory creation is confused about size, mark FIXME)
7/10 Checking commit 6161e9b2e1a1 (mips_malta: Clean up definition of flash memory size somewhat)
8/10 Checking commit b2a752e969e1 (pflash: Clean up after commit 368a354f02b part 1)
ERROR: spaces required around that '-' (ctx:VxV)
#90: FILE: hw/arm/musicpal.c:1639:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
ERROR: spaces required around that '-' (ctx:VxV)
#98: FILE: hw/arm/musicpal.c:1646:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
total: 2 errors, 0 warnings, 248 lines checked
Patch 8/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/10 Checking commit 8900ef3eb27a (pflash: Clean up after commit 368a354f02b part 2)
10/10 Checking commit 03998181d548 (hw/arm hw/xtensa: De-duplicate pflash creation code some)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190218125615.18970-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190218125615.18970-1-armbru@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190218125615.18970-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20190218125615.18970-1-armbru@redhat.com -> patchew/20190218125615.18970-1-armbru@redhat.com
- [tag update] patchew/20190219114609.1582-1-berrange@redhat.com -> patchew/20190219114609.1582-1-berrange@redhat.com
- [tag update] patchew/20190219124257.3001-1-kraxel@redhat.com -> patchew/20190219124257.3001-1-kraxel@redhat.com
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'a5b428e1c1eae703bdd62a3f527223c291ee3fdc'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out '3464681b2b5983df80086a40179d324102347da3'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
0399818 hw/arm hw/xtensa: De-duplicate pflash creation code some
8900ef3 pflash: Clean up after commit 368a354f02b part 2
b2a752e pflash: Clean up after commit 368a354f02b part 1
6161e9b mips_malta: Clean up definition of flash memory size somewhat
f63e1b9 r2d: Flash memory creation is confused about size, mark FIXME
c940613 ppc405_boards: Don't size flash memory to match backing image
aafbf2b sam460ex: Don't size flash memory to match backing image
50c58aa hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2}
32f306b pflash: Macro PFLASH_BUG() is used just once, expand
ab1e43c pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02
=== OUTPUT BEGIN ===
1/10 Checking commit ab1e43ce7b8b (pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02)
ERROR: space prohibited between function name and open parenthesis '('
#128: FILE: hw/block/pflash_cfi01.c:288:
+static uint32_t pflash_read (PFlashCFI01 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#340: FILE: hw/block/pflash_cfi02.c:141:
+static uint32_t pflash_read (PFlashCFI02 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#358: FILE: hw/block/pflash_cfi02.c:264:
+static void pflash_write (PFlashCFI02 *pfl, hwaddr offset,
total: 3 errors, 0 warnings, 483 lines checked
Patch 1/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/10 Checking commit 32f306be2381 (pflash: Macro PFLASH_BUG() is used just once, expand)
3/10 Checking commit 50c58aaaeff5 (hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2})
4/10 Checking commit aafbf2b0cbd5 (sam460ex: Don't size flash memory to match backing image)
5/10 Checking commit c940613c6fd9 (ppc405_boards: Don't size flash memory to match backing image)
6/10 Checking commit f63e1b95beaf (r2d: Flash memory creation is confused about size, mark FIXME)
7/10 Checking commit 6161e9b2e1a1 (mips_malta: Clean up definition of flash memory size somewhat)
8/10 Checking commit b2a752e969e1 (pflash: Clean up after commit 368a354f02b part 1)
ERROR: spaces required around that '-' (ctx:VxV)
#90: FILE: hw/arm/musicpal.c:1639:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
ERROR: spaces required around that '-' (ctx:VxV)
#98: FILE: hw/arm/musicpal.c:1646:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
total: 2 errors, 0 warnings, 248 lines checked
Patch 8/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/10 Checking commit 8900ef3eb27a (pflash: Clean up after commit 368a354f02b part 2)
10/10 Checking commit 03998181d548 (hw/arm hw/xtensa: De-duplicate pflash creation code some)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190218125615.18970-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190218125615.18970-1-armbru@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190218125615.18970-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/20190218125615.18970-1-armbru@redhat.com -> patchew/20190218125615.18970-1-armbru@redhat.com
t [tag update] patchew/20190219114609.1582-1-berrange@redhat.com -> patchew/20190219114609.1582-1-berrange@redhat.com
Switched to a new branch 'test'
918b511857 hw/arm hw/xtensa: De-duplicate pflash creation code some
573a3cb6ee pflash: Clean up after commit 368a354f02b part 2
cd6c8874c9 pflash: Clean up after commit 368a354f02b part 1
47d6b05dbf mips_malta: Clean up definition of flash memory size somewhat
4d776997cb r2d: Flash memory creation is confused about size, mark FIXME
8ef649b622 ppc405_boards: Don't size flash memory to match backing image
05e5efce12 sam460ex: Don't size flash memory to match backing image
83454272f9 hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2}
e25489f667 pflash: Macro PFLASH_BUG() is used just once, expand
23cedcc198 pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02
=== OUTPUT BEGIN ===
1/10 Checking commit 23cedcc198b7 (pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02)
ERROR: space prohibited between function name and open parenthesis '('
#128: FILE: hw/block/pflash_cfi01.c:288:
+static uint32_t pflash_read (PFlashCFI01 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#340: FILE: hw/block/pflash_cfi02.c:141:
+static uint32_t pflash_read (PFlashCFI02 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#358: FILE: hw/block/pflash_cfi02.c:264:
+static void pflash_write (PFlashCFI02 *pfl, hwaddr offset,
total: 3 errors, 0 warnings, 483 lines checked
Patch 1/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/10 Checking commit e25489f66779 (pflash: Macro PFLASH_BUG() is used just once, expand)
3/10 Checking commit 83454272f952 (hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2})
4/10 Checking commit 05e5efce1273 (sam460ex: Don't size flash memory to match backing image)
5/10 Checking commit 8ef649b622cf (ppc405_boards: Don't size flash memory to match backing image)
6/10 Checking commit 4d776997cb7d (r2d: Flash memory creation is confused about size, mark FIXME)
7/10 Checking commit 47d6b05dbf10 (mips_malta: Clean up definition of flash memory size somewhat)
8/10 Checking commit cd6c8874c9f4 (pflash: Clean up after commit 368a354f02b part 1)
ERROR: spaces required around that '-' (ctx:VxV)
#91: FILE: hw/arm/musicpal.c:1639:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
ERROR: spaces required around that '-' (ctx:VxV)
#99: FILE: hw/arm/musicpal.c:1646:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
total: 2 errors, 0 warnings, 248 lines checked
Patch 8/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/10 Checking commit 573a3cb6eeac (pflash: Clean up after commit 368a354f02b part 2)
10/10 Checking commit 918b5118573b (hw/arm hw/xtensa: De-duplicate pflash creation code some)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190218125615.18970-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190218125615.18970-1-armbru@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190218125615.18970-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/20190218140926.333779-1-vsementsov@virtuozzo.com -> patchew/20190218140926.333779-1-vsementsov@virtuozzo.com
Switched to a new branch 'test'
ba3f93c692 hw/arm hw/xtensa: De-duplicate pflash creation code some
f99ab9fe08 pflash: Clean up after commit 368a354f02b part 2
e98231996b pflash: Clean up after commit 368a354f02b part 1
fd218de008 mips_malta: Clean up definition of flash memory size somewhat
413850d478 r2d: Flash memory creation is confused about size, mark FIXME
d23c64b271 ppc405_boards: Don't size flash memory to match backing image
db2935d503 sam460ex: Don't size flash memory to match backing image
856425f0be hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2}
09fa7495d9 pflash: Macro PFLASH_BUG() is used just once, expand
83625c2e47 pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02
=== OUTPUT BEGIN ===
1/10 Checking commit 83625c2e4780 (pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02)
ERROR: space prohibited between function name and open parenthesis '('
#128: FILE: hw/block/pflash_cfi01.c:288:
+static uint32_t pflash_read (PFlashCFI01 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#340: FILE: hw/block/pflash_cfi02.c:141:
+static uint32_t pflash_read (PFlashCFI02 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#358: FILE: hw/block/pflash_cfi02.c:264:
+static void pflash_write (PFlashCFI02 *pfl, hwaddr offset,
total: 3 errors, 0 warnings, 483 lines checked
Patch 1/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/10 Checking commit 09fa7495d9a5 (pflash: Macro PFLASH_BUG() is used just once, expand)
3/10 Checking commit 856425f0be58 (hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2})
4/10 Checking commit db2935d50313 (sam460ex: Don't size flash memory to match backing image)
5/10 Checking commit d23c64b27139 (ppc405_boards: Don't size flash memory to match backing image)
6/10 Checking commit 413850d478aa (r2d: Flash memory creation is confused about size, mark FIXME)
7/10 Checking commit fd218de008eb (mips_malta: Clean up definition of flash memory size somewhat)
8/10 Checking commit e98231996be7 (pflash: Clean up after commit 368a354f02b part 1)
ERROR: spaces required around that '-' (ctx:VxV)
#92: FILE: hw/arm/musicpal.c:1639:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
ERROR: spaces required around that '-' (ctx:VxV)
#100: FILE: hw/arm/musicpal.c:1646:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
total: 2 errors, 0 warnings, 248 lines checked
Patch 8/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/10 Checking commit f99ab9fe08d8 (pflash: Clean up after commit 368a354f02b part 2)
10/10 Checking commit ba3f93c692dd (hw/arm hw/xtensa: De-duplicate pflash creation code some)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190218125615.18970-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190218125615.18970-1-armbru@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190218125615.18970-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/20190219195928.12289-1-dgilbert@redhat.com -> patchew/20190219195928.12289-1-dgilbert@redhat.com
Switched to a new branch 'test'
97502f3196 hw/arm hw/xtensa: De-duplicate pflash creation code some
6bb2bc07ff pflash: Clean up after commit 368a354f02b part 2
9604558ee0 pflash: Clean up after commit 368a354f02b part 1
bc39e20ae1 mips_malta: Clean up definition of flash memory size somewhat
9aeddfb874 r2d: Flash memory creation is confused about size, mark FIXME
cd1fb1567e ppc405_boards: Don't size flash memory to match backing image
6a565f0a2a sam460ex: Don't size flash memory to match backing image
9cbfffefec hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2}
9f784f3f33 pflash: Macro PFLASH_BUG() is used just once, expand
1e9644bd3b pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02
=== OUTPUT BEGIN ===
1/10 Checking commit 1e9644bd3b0d (pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02)
ERROR: space prohibited between function name and open parenthesis '('
#129: FILE: hw/block/pflash_cfi01.c:288:
+static uint32_t pflash_read (PFlashCFI01 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#341: FILE: hw/block/pflash_cfi02.c:141:
+static uint32_t pflash_read (PFlashCFI02 *pfl, hwaddr offset,
ERROR: space prohibited between function name and open parenthesis '('
#359: FILE: hw/block/pflash_cfi02.c:264:
+static void pflash_write (PFlashCFI02 *pfl, hwaddr offset,
total: 3 errors, 0 warnings, 483 lines checked
Patch 1/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/10 Checking commit 9f784f3f3321 (pflash: Macro PFLASH_BUG() is used just once, expand)
3/10 Checking commit 9cbfffefec0b (hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2})
4/10 Checking commit 6a565f0a2aa8 (sam460ex: Don't size flash memory to match backing image)
5/10 Checking commit cd1fb1567ec3 (ppc405_boards: Don't size flash memory to match backing image)
6/10 Checking commit 9aeddfb8748e (r2d: Flash memory creation is confused about size, mark FIXME)
7/10 Checking commit bc39e20ae16c (mips_malta: Clean up definition of flash memory size somewhat)
8/10 Checking commit 9604558ee0b8 (pflash: Clean up after commit 368a354f02b part 1)
ERROR: spaces required around that '-' (ctx:VxV)
#92: FILE: hw/arm/musicpal.c:1639:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
ERROR: spaces required around that '-' (ctx:VxV)
#100: FILE: hw/arm/musicpal.c:1646:
+ pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
^
total: 2 errors, 0 warnings, 248 lines checked
Patch 8/10 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/10 Checking commit 6bb2bc07ffb7 (pflash: Clean up after commit 368a354f02b part 2)
10/10 Checking commit 97502f319636 (hw/arm hw/xtensa: De-duplicate pflash creation code some)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190218125615.18970-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
© 2016 - 2024 Red Hat, Inc.