This is a set of tests to test basic device unplugging functionality for
- some PCI implementations
- CCW devices on s390x
- spapr memory and cpu core devices

I plaed with ACPI CPU unplug but getting that to run with qtest is more
involved. (remove devices on reset, trick cpu-hotplug-legacy property,
somehow create cpu hotplug state objects ...). Well we no have at least
one unplug test for DIMMs and one for CPUs.

@David, I dropped you t-b and r-b due to many changes but would be happy
to readd them ;)

v1 -> v2:
- Tests for CCW, spapr memory and spapr cpu core unplug added
- Fix a deadlock when unplugging dummy CPUs
- Style fixes / simplifications (Thomas)
- Don't use the global_qtest variable (Thomas)
- Fix double-free (Greg)


David Hildenbrand (6):
  cpus: Properly release the iothread lock when killing a dummy VCPU
  spapr: support memory unplug for qtest
  tests/device-plug: Add a simple PCI unplug request test
  tests/device-plug: Add CCW unplug test for s390x
  tests/device-plug: Add CPU core unplug request test for spapr
  tests/device-plug: Add memory unplug request test for spapr

 cpus.c                   |   1 +
 hw/ppc/spapr_ovec.c      |   6 ++
 tests/Makefile.include   |   4 +
 tests/device-plug-test.c | 165 +++++++++++++++++++++++++++++++++++++++
 4 files changed, 176 insertions(+)
 create mode 100644 tests/device-plug-test.c

-- 
2.17.2

On Fri, Feb 15, 2019 at 02:29:59PM +0100, David Hildenbrand wrote:
> This is a set of tests to test basic device unplugging functionality for
> - some PCI implementations
> - CCW devices on s390x
> - spapr memory and cpu core devices
> 
> I plaed with ACPI CPU unplug but getting that to run with qtest is more
> involved. (remove devices on reset, trick cpu-hotplug-legacy property,
> somehow create cpu hotplug state objects ...). Well we no have at least
> one unplug test for DIMMs and one for CPUs.
> 
> @David, I dropped you t-b and r-b due to many changes but would be happy
> to readd them ;)


Series:
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>


I think it's mostly spapr things so feel free to merge through
that tree.

> v1 -> v2:
> - Tests for CCW, spapr memory and spapr cpu core unplug added
> - Fix a deadlock when unplugging dummy CPUs
> - Style fixes / simplifications (Thomas)
> - Don't use the global_qtest variable (Thomas)
> - Fix double-free (Greg)
> 
> 
> David Hildenbrand (6):
>   cpus: Properly release the iothread lock when killing a dummy VCPU
>   spapr: support memory unplug for qtest
>   tests/device-plug: Add a simple PCI unplug request test
>   tests/device-plug: Add CCW unplug test for s390x
>   tests/device-plug: Add CPU core unplug request test for spapr
>   tests/device-plug: Add memory unplug request test for spapr
> 
>  cpus.c                   |   1 +
>  hw/ppc/spapr_ovec.c      |   6 ++
>  tests/Makefile.include   |   4 +
>  tests/device-plug-test.c | 165 +++++++++++++++++++++++++++++++++++++++
>  4 files changed, 176 insertions(+)
>  create mode 100644 tests/device-plug-test.c
> 
> -- 
> 2.17.2

On 15.02.19 22:27, Michael S. Tsirkin wrote:
> On Fri, Feb 15, 2019 at 02:29:59PM +0100, David Hildenbrand wrote:
>> This is a set of tests to test basic device unplugging functionality for
>> - some PCI implementations
>> - CCW devices on s390x
>> - spapr memory and cpu core devices
>>
>> I plaed with ACPI CPU unplug but getting that to run with qtest is more
>> involved. (remove devices on reset, trick cpu-hotplug-legacy property,
>> somehow create cpu hotplug state objects ...). Well we no have at least
>> one unplug test for DIMMs and one for CPUs.
>>
>> @David, I dropped you t-b and r-b due to many changes but would be happy
>> to readd them ;)
> 
> 
> Series:
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> 
> 
> I think it's mostly spapr things so feel free to merge through
> that tree.

Thanks, I'll address the minor review comments next week and most
probably resend on Monday. I also agree that spapr would be a good fit.


-- 

Thanks,

David / dhildenb

On Fri, Feb 15, 2019 at 11:09:32PM +0100, David Hildenbrand wrote:
> On 15.02.19 22:27, Michael S. Tsirkin wrote:
> > On Fri, Feb 15, 2019 at 02:29:59PM +0100, David Hildenbrand wrote:
> >> This is a set of tests to test basic device unplugging functionality for
> >> - some PCI implementations
> >> - CCW devices on s390x
> >> - spapr memory and cpu core devices
> >>
> >> I plaed with ACPI CPU unplug but getting that to run with qtest is more
> >> involved. (remove devices on reset, trick cpu-hotplug-legacy property,
> >> somehow create cpu hotplug state objects ...). Well we no have at least
> >> one unplug test for DIMMs and one for CPUs.
> >>
> >> @David, I dropped you t-b and r-b due to many changes but would be happy
> >> to readd them ;)
> > 
> > 
> > Series:
> > Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> > 
> > 
> > I think it's mostly spapr things so feel free to merge through
> > that tree.
> 
> Thanks, I'll address the minor review comments next week and most
> probably resend on Monday. I also agree that spapr would be a good fit.

Ah, ok.  I can do that.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson