sdl2: drop qemu_input_event_send_key_qcode call

[Qemu-devel] [PATCH] sdl2: drop qemu_input_event_send_key_qcode call

Gerd Hoffmann posted 1 patch 5 years, 2 months ago

Download mbox

Test docker-mingw@fedora passed

Test asan passed

Test checkpatch passed

Test docker-clang@ubuntu passed

Failed in applying to current master (apply log)

ui/sdl2-input.c | 3 ---
1 file changed, 3 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] sdl2: drop qemu_input_event_send_key_qcode call

Posted by Gerd Hoffmann 5 years, 2 months ago

qkbd_state_key_event() does that for us.

Fixes: 07333e1ca3 kbd-state: use state tracker for sdl2
Reported-by: BALATON Zoltan <balaton@eik.bme.hu>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 ui/sdl2-input.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/ui/sdl2-input.c b/ui/sdl2-input.c
index 664364a5e5..fb345f45fb 100644
--- a/ui/sdl2-input.c
+++ b/ui/sdl2-input.c
@@ -54,8 +54,5 @@ void sdl2_process_key(struct sdl2_console *scon,
                 break;
             }
         }
-    } else {
-        qemu_input_event_send_key_qcode(con, qcode,
-                                        ev->type == SDL_KEYDOWN);
     }
 }
-- 
2.9.3

Re: [Qemu-devel] [PATCH] sdl2: drop qemu_input_event_send_key_qcode call

Posted by BALATON Zoltan 5 years, 2 months ago

On Fri, 8 Feb 2019, Gerd Hoffmann wrote:
> qkbd_state_key_event() does that for us.
>
> Fixes: 07333e1ca3 kbd-state: use state tracker for sdl2
> Reported-by: BALATON Zoltan <balaton@eik.bme.hu>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Fixes my problem.

Tested-by: BALATON Zoltan <balaton@eik.bme.hu>

Thank you,
BALATON Zoltan

> ---
> ui/sdl2-input.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/ui/sdl2-input.c b/ui/sdl2-input.c
> index 664364a5e5..fb345f45fb 100644
> --- a/ui/sdl2-input.c
> +++ b/ui/sdl2-input.c
> @@ -54,8 +54,5 @@ void sdl2_process_key(struct sdl2_console *scon,
>                 break;
>             }
>         }
> -    } else {
> -        qemu_input_event_send_key_qcode(con, qcode,
> -                                        ev->type == SDL_KEYDOWN);
>     }
> }
>