[Qemu-devel] [PATCH 2/4] configure: fix qemu-img name

Cleber Rosa posted 4 patches 6 years, 12 months ago
Maintainers: Cleber Rosa <crosa@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>
[Qemu-devel] [PATCH 2/4] configure: fix qemu-img name
Posted by Cleber Rosa 6 years, 12 months ago
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index ff55e2273e..c8fc1647fe 100755
--- a/configure
+++ b/configure
@@ -1768,7 +1768,7 @@ disabled with --disable-FEATURE, default is enabled if available:
   virglrenderer   virgl rendering support
   xfsctl          xfsctl support
   qom-cast-debug  cast debugging support
-  tools           build qemu-io, qemu-nbd and qemu-image tools
+  tools           build qemu-io, qemu-nbd and qemu-img tools
   vxhs            Veritas HyperScale vDisk backend support
   bochs           bochs image format support
   cloop           cloop image format support
-- 
2.20.1


Re: [Qemu-devel] [PATCH 2/4] configure: fix qemu-img name
Posted by Laurent Vivier 6 years, 12 months ago
On 07/02/2019 20:36, Cleber Rosa wrote:
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index ff55e2273e..c8fc1647fe 100755
> --- a/configure
> +++ b/configure
> @@ -1768,7 +1768,7 @@ disabled with --disable-FEATURE, default is enabled if available:
>    virglrenderer   virgl rendering support
>    xfsctl          xfsctl support
>    qom-cast-debug  cast debugging support
> -  tools           build qemu-io, qemu-nbd and qemu-image tools
> +  tools           build qemu-io, qemu-nbd and qemu-img tools
>    vxhs            Veritas HyperScale vDisk backend support
>    bochs           bochs image format support
>    cloop           cloop image format support
> 

Fixes: c12d66aac1aa ("configure: add the missing help output for
optional features")

Perhaps the list can be updated with qemu-edid, ivshmem-client and elf2dmp?

Reviewed-by: Laurent Vivier <laurent@vivier.eu>


Re: [Qemu-devel] [PATCH 2/4] configure: fix qemu-img name
Posted by Philippe Mathieu-Daudé 6 years, 12 months ago
On 2/7/19 9:11 PM, Laurent Vivier wrote:
> On 07/02/2019 20:36, Cleber Rosa wrote:
>> Signed-off-by: Cleber Rosa <crosa@redhat.com>
>> ---
>>  configure | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index ff55e2273e..c8fc1647fe 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1768,7 +1768,7 @@ disabled with --disable-FEATURE, default is enabled if available:
>>    virglrenderer   virgl rendering support
>>    xfsctl          xfsctl support
>>    qom-cast-debug  cast debugging support
>> -  tools           build qemu-io, qemu-nbd and qemu-image tools
>> +  tools           build qemu-io, qemu-nbd and qemu-img tools
>>    vxhs            Veritas HyperScale vDisk backend support
>>    bochs           bochs image format support
>>    cloop           cloop image format support
>>
> 
> Fixes: c12d66aac1aa ("configure: add the missing help output for
> optional features")
> 
> Perhaps the list can be updated with qemu-edid, ivshmem-client and elf2dmp?

Good idea! Eventually the trivial@ maintainer is willing to fulfil your
request if he takes this patch :D

> Reviewed-by: Laurent Vivier <laurent@vivier.eu>

As it or with Laurent's suggestion:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>


Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/4] configure: fix qemu-img name
Posted by Laurent Vivier 6 years, 11 months ago
On 07/02/2019 20:36, Cleber Rosa wrote:
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index ff55e2273e..c8fc1647fe 100755
> --- a/configure
> +++ b/configure
> @@ -1768,7 +1768,7 @@ disabled with --disable-FEATURE, default is enabled if available:
>    virglrenderer   virgl rendering support
>    xfsctl          xfsctl support
>    qom-cast-debug  cast debugging support
> -  tools           build qemu-io, qemu-nbd and qemu-image tools
> +  tools           build qemu-io, qemu-nbd and qemu-img tools
>    vxhs            Veritas HyperScale vDisk backend support
>    bochs           bochs image format support
>    cloop           cloop image format support
> 

Applied to my trivial-patches branch.

Thanks,
Laurent