[Qemu-devel] [PATCH v2 00/11] hw: Remove "hw/devices.h"

Philippe Mathieu-Daudé posted 11 patches 5 years, 2 months ago
Test docker-mingw@fedora passed
Test asan failed
Test checkpatch passed
Test docker-clang@ubuntu passed
Failed in applying to current master (apply log)
There is a newer version of this series
MAINTAINERS                              |  7 +++
hw/alpha/typhoon.c                       |  1 -
hw/arm/allwinner-a10.c                   |  1 -
hw/arm/aspeed.c                          | 13 +++--
hw/arm/collie.c                          |  1 -
hw/arm/cubieboard.c                      |  1 -
hw/arm/exynos4_boards.c                  |  3 +-
hw/arm/gumstix.c                         |  2 +-
hw/arm/highbank.c                        |  1 -
hw/arm/integratorcp.c                    |  2 +-
hw/arm/kzm.c                             |  2 +-
hw/arm/mainstone.c                       |  2 +-
hw/arm/mps2-tz.c                         |  4 +-
hw/arm/mps2.c                            |  2 +-
hw/arm/musicpal.c                        |  1 -
hw/arm/nrf51_soc.c                       |  1 -
hw/arm/nseries.c                         |  4 +-
hw/arm/palm.c                            |  2 +-
hw/arm/realview.c                        |  3 +-
hw/arm/spitz.c                           |  1 -
hw/arm/stellaris.c                       |  2 +-
hw/arm/tosa.c                            |  2 +-
hw/arm/versatilepb.c                     |  2 +-
hw/arm/vexpress.c                        |  2 +-
hw/arm/virt.c                            |  1 -
hw/arm/z2.c                              |  1 -
hw/display/blizzard.c                    |  2 +-
hw/display/sm501.c                       |  1 -
hw/display/tc6393xb.c                    |  2 +-
hw/hppa/dino.c                           |  1 -
hw/input/stellaris_input.c               |  2 +-
hw/input/tsc2005.c                       |  2 +-
hw/input/tsc210x.c                       |  4 +-
hw/intc/allwinner-a10-pic.c              |  1 -
hw/lm32/lm32_boards.c                    |  1 -
hw/lm32/milkymist.c                      |  1 -
hw/microblaze/petalogix_ml605_mmu.c      |  1 -
hw/microblaze/petalogix_s3adsp1800_mmu.c |  1 -
hw/misc/cbus.c                           |  2 +-
hw/net/dp8393x.c                         |  1 -
hw/net/lan9118.c                         |  3 +-
hw/net/smc91c111.c                       |  2 +-
hw/ppc/virtex_ml507.c                    |  1 -
hw/sh4/r2d.c                             |  1 -
hw/tricore/tricore_testboard.c           |  1 -
hw/usb/tusb6010.c                        |  1 -
include/hw/arm/omap.h                    |  6 +--
include/hw/devices.h                     | 63 ------------------------
include/hw/display/blizzard.h            | 22 +++++++++
include/hw/display/tc6393xb.h            | 26 ++++++++++
include/hw/input/gamepad.h               | 21 ++++++++
include/hw/input/tsc2xxx.h               | 38 ++++++++++++++
include/hw/misc/cbus.h                   | 32 ++++++++++++
include/hw/net/lan9118.h                 | 21 ++++++++
include/hw/net/ne2000-isa.h              |  6 +++
include/hw/net/smc91c111.h               | 19 +++++++
include/qemu/typedefs.h                  |  1 -
57 files changed, 230 insertions(+), 120 deletions(-)
delete mode 100644 include/hw/devices.h
create mode 100644 include/hw/display/blizzard.h
create mode 100644 include/hw/display/tc6393xb.h
create mode 100644 include/hw/input/gamepad.h
create mode 100644 include/hw/input/tsc2xxx.h
create mode 100644 include/hw/misc/cbus.h
create mode 100644 include/hw/net/lan9118.h
create mode 100644 include/hw/net/smc91c111.h
[Qemu-devel] [PATCH v2 00/11] hw: Remove "hw/devices.h"
Posted by Philippe Mathieu-Daudé 5 years, 2 months ago
Hi,

As his first comment describes itself, the "hw/devices.h" contains
declarations for "Devices that have nowhere better to go."
This series remove it, creating new headers for devices covered there.
MAINTAINERS is updated.
I also included 2 cleanups while working on this, in "qemu/typedefs.h"
and "hw/net/ne2000-isa.h" header guard.

v2:
- added R-b, T-b tags
- addressed many review comments from Thomas

v1: https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg00611.html

Phil.

Philippe Mathieu-Daudé (11):
  hw/arm/aspeed: Use TYPE_TMP105/TYPE_PCA9552 instead of hardcoded
    string
  hw: Remove unused 'hw/devices.h' include
  hw/devices: Move TC6393XB declarations into a new header
  hw/devices: Move Blizzard declarations into a new header
  hw/devices: Move CBus declarations into a new header
  hw/devices: Move Gamepad declarations into a new header
  hw/devices: Move TI touchscreen declarations into a new header
  hw/devices: Move LAN9118 declarations into a new header
  hw/net/ne2000-isa: Add guards to the header
  hw/net/lan9118: Export TYPE_LAN9118 and use it instead of hardcoded
    string
  hw/devices: Move SMSC 91C111 declaration into a new header

 MAINTAINERS                              |  7 +++
 hw/alpha/typhoon.c                       |  1 -
 hw/arm/allwinner-a10.c                   |  1 -
 hw/arm/aspeed.c                          | 13 +++--
 hw/arm/collie.c                          |  1 -
 hw/arm/cubieboard.c                      |  1 -
 hw/arm/exynos4_boards.c                  |  3 +-
 hw/arm/gumstix.c                         |  2 +-
 hw/arm/highbank.c                        |  1 -
 hw/arm/integratorcp.c                    |  2 +-
 hw/arm/kzm.c                             |  2 +-
 hw/arm/mainstone.c                       |  2 +-
 hw/arm/mps2-tz.c                         |  4 +-
 hw/arm/mps2.c                            |  2 +-
 hw/arm/musicpal.c                        |  1 -
 hw/arm/nrf51_soc.c                       |  1 -
 hw/arm/nseries.c                         |  4 +-
 hw/arm/palm.c                            |  2 +-
 hw/arm/realview.c                        |  3 +-
 hw/arm/spitz.c                           |  1 -
 hw/arm/stellaris.c                       |  2 +-
 hw/arm/tosa.c                            |  2 +-
 hw/arm/versatilepb.c                     |  2 +-
 hw/arm/vexpress.c                        |  2 +-
 hw/arm/virt.c                            |  1 -
 hw/arm/z2.c                              |  1 -
 hw/display/blizzard.c                    |  2 +-
 hw/display/sm501.c                       |  1 -
 hw/display/tc6393xb.c                    |  2 +-
 hw/hppa/dino.c                           |  1 -
 hw/input/stellaris_input.c               |  2 +-
 hw/input/tsc2005.c                       |  2 +-
 hw/input/tsc210x.c                       |  4 +-
 hw/intc/allwinner-a10-pic.c              |  1 -
 hw/lm32/lm32_boards.c                    |  1 -
 hw/lm32/milkymist.c                      |  1 -
 hw/microblaze/petalogix_ml605_mmu.c      |  1 -
 hw/microblaze/petalogix_s3adsp1800_mmu.c |  1 -
 hw/misc/cbus.c                           |  2 +-
 hw/net/dp8393x.c                         |  1 -
 hw/net/lan9118.c                         |  3 +-
 hw/net/smc91c111.c                       |  2 +-
 hw/ppc/virtex_ml507.c                    |  1 -
 hw/sh4/r2d.c                             |  1 -
 hw/tricore/tricore_testboard.c           |  1 -
 hw/usb/tusb6010.c                        |  1 -
 include/hw/arm/omap.h                    |  6 +--
 include/hw/devices.h                     | 63 ------------------------
 include/hw/display/blizzard.h            | 22 +++++++++
 include/hw/display/tc6393xb.h            | 26 ++++++++++
 include/hw/input/gamepad.h               | 21 ++++++++
 include/hw/input/tsc2xxx.h               | 38 ++++++++++++++
 include/hw/misc/cbus.h                   | 32 ++++++++++++
 include/hw/net/lan9118.h                 | 21 ++++++++
 include/hw/net/ne2000-isa.h              |  6 +++
 include/hw/net/smc91c111.h               | 19 +++++++
 include/qemu/typedefs.h                  |  1 -
 57 files changed, 230 insertions(+), 120 deletions(-)
 delete mode 100644 include/hw/devices.h
 create mode 100644 include/hw/display/blizzard.h
 create mode 100644 include/hw/display/tc6393xb.h
 create mode 100644 include/hw/input/gamepad.h
 create mode 100644 include/hw/input/tsc2xxx.h
 create mode 100644 include/hw/misc/cbus.h
 create mode 100644 include/hw/net/lan9118.h
 create mode 100644 include/hw/net/smc91c111.h

-- 
2.20.1


Re: [Qemu-devel] [PATCH v2 00/11] hw: Remove "hw/devices.h"
Posted by Philippe Mathieu-Daudé 5 years, 2 months ago
On 2/5/19 12:18 AM, Philippe Mathieu-Daudé wrote:
> Hi,
> 
> As his first comment describes itself, the "hw/devices.h" contains
> declarations for "Devices that have nowhere better to go."
> This series remove it, creating new headers for devices covered there.
> MAINTAINERS is updated.
> I also included 2 cleanups while working on this, in "qemu/typedefs.h"
> and "hw/net/ne2000-isa.h" header guard.
> 
> v2:
> - added R-b, T-b tags
> - addressed many review comments from Thomas
> 
> v1: https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg00611.html

ping?

Since it is mostly touch (old) ARM boards, Peter can you do a quick
review and give your Ack-by, so it can go via the Trivial/Misc tree?
Half of the series is already reviewed by Thomas.

Thanks,

Phil.

Re: [Qemu-devel] [PATCH v2 00/11] hw: Remove "hw/devices.h"
Posted by Markus Armbruster 5 years ago
Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> Hi,
>
> As his first comment describes itself, the "hw/devices.h" contains
> declarations for "Devices that have nowhere better to go."
> This series remove it, creating new headers for devices covered there.
> MAINTAINERS is updated.
> I also included 2 cleanups while working on this, in "qemu/typedefs.h"
> and "hw/net/ne2000-isa.h" header guard.

Needs a rebase now.  Apart from that, series
Reviewed-by: Markus Armbruster <armbru@redhat.com>