[Qemu-devel] [PATCH v11 06/25] replay: finish record/replay before closing the disks

Pavel Dovgalyuk posted 25 patches 6 years, 8 months ago
Maintainers: Thomas Huth <thuth@redhat.com>, Eric Blake <eblake@redhat.com>, Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>, Ronnie Sahlberg <ronniesahlberg@gmail.com>, Markus Armbruster <armbru@redhat.com>, Juan Quintela <quintela@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Richard Henderson <rth@twiddle.net>, Paolo Bonzini <pbonzini@redhat.com>, Max Reitz <mreitz@redhat.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, Laurent Vivier <lvivier@redhat.com>, Jeff Cody <jcody@redhat.com>, Josh Durgin <jdurgin@redhat.com>, Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Peter Lieven <pl@kamp.de>
There is a newer version of this series
[Qemu-devel] [PATCH v11 06/25] replay: finish record/replay before closing the disks
Posted by Pavel Dovgalyuk 6 years, 8 months ago
After recent updates block devices cannot be closed on qemu exit.
This happens due to the block request polling when replay is not finished.
Therefore now we stop execution recording before closing the block devices.

Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
---
 replay/replay.c |    2 ++
 vl.c            |    1 +
 2 files changed, 3 insertions(+)

diff --git a/replay/replay.c b/replay/replay.c
index 8b172b2..b75820a 100644
--- a/replay/replay.c
+++ b/replay/replay.c
@@ -385,6 +385,8 @@ void replay_finish(void)
     g_free(replay_snapshot);
     replay_snapshot = NULL;
 
+    replay_mode = REPLAY_MODE_NONE;
+
     replay_finish_events();
 }
 
diff --git a/vl.c b/vl.c
index bea05cd..5992d8e 100644
--- a/vl.c
+++ b/vl.c
@@ -4671,6 +4671,7 @@ int main(int argc, char **argv, char **envp)
 
     /* No more vcpu or device emulation activity beyond this point */
     vm_shutdown();
+    replay_finish();
 
     job_cancel_sync_all();
     bdrv_close_all();