[v3] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

[Qemu-devel] [PATCH v3 0/8] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

Posted by Tao Xu 7 years ago

This series of patches will build Heterogeneous Memory Attribute Table (HMAT)
according to the command line. The ACPI HMAT describes the memory attributes,
such as memory side cache attributes and bandwidth and latency details,
related to the System Physical Address (SPA) Memory Ranges.
The software is expected to use this information as hint for optimization.

OSPM evaluates HMAT only during system initialization. Any changes to the HMAT
state at runtime or information regarding HMAT for hot plug are communicated
using the _HMA method.

From 1 to 6 patches are the former V1 patches. From 7 to 8 patches are the
updates per Igor and Eric's comments.

The V2 patches link:
http://lists.nongnu.org/archive/html/qemu-devel/2019-01/msg02276.html
The V1 RESEND patches link:
http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg05368.html

Changelog:
v3:
  Per Eric's comments
    - rebase the fixing patch into the jingqi's patches
    - update the version tag from 3.10 to 4.0
v2:
  Per Igor and Eric's comments, fix some coding style and small issues:
    - update the version number in qapi/misc.json
    - including the expansion of the acronym HMAT in qapi/misc.json
    - correct spell mistakes in qapi/misc.json and qemu-options.hx
    - fix the comment syle in hw/i386/acpi-build.c
    and hw/acpi/hmat.h
   - remove some unnecessary head files in hw/acpi/hmat.c
   - use hardcoded numbers from spec to generate
   Memory Subsystem Address Range Structure in hw/acpi/hmat.c
   - drop the struct AcpiHmat and AcpiHmatSpaRange
    in hw/acpi/hmat.h
  Per Igor's comment, rewrite NFIT code to build _HMA method.

Liu Jingqi (6):
  hmat acpi: Build Memory Subsystem Address Range Structure(s) in ACPI
    HMAT
  hmat acpi: Build System Locality Latency and Bandwidth Information
    Structure(s) in ACPI HMAT
  hmat acpi: Build Memory Side Cache Information Structure(s) in ACPI
    HMAT
  Extend the command-line to provide memory latency and bandwidth
    information
  numa: Extend the command-line to provide memory side cache information
  hmat acpi: Implement _HMA method to update HMAT at runtime

Tao Xu (2):
  hmat acpi: move some function inside of the caller
  acpi: rewrite the _FIT method to use it in _HMA method

 default-configs/i386-softmmu.mak |   1 +
 hw/acpi/Makefile.objs            |   1 +
 hw/acpi/hmat.c                   | 424 +++++++++++++++++++++++++++++++
 hw/acpi/hmat.h                   | 245 ++++++++++++++++++
 hw/acpi/nvdimm.c                 | 389 ++++++++++++++++++----------
 hw/i386/acpi-build.c             | 125 +++++----
 hw/i386/acpi-build.h             |  10 +
 hw/i386/pc.c                     |   2 +
 hw/i386/pc_piix.c                |   3 +
 hw/i386/pc_q35.c                 |   3 +
 include/hw/i386/pc.h             |   2 +
 include/hw/mem/nvdimm.h          |  11 +
 include/sysemu/numa.h            |   2 +
 numa.c                           | 202 +++++++++++++++
 qapi/misc.json                   | 162 +++++++++++-
 qemu-options.hx                  |  28 +-
 16 files changed, 1427 insertions(+), 183 deletions(-)
 create mode 100644 hw/acpi/hmat.c
 create mode 100644 hw/acpi/hmat.h

-- 
2.17.1

Re: [Qemu-devel] [PATCH v3 0/8] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

Posted by no-reply@patchew.org 7 years ago

Patchew URL: https://patchew.org/QEMU/20190131071658.29120-1-tao3.xu@intel.com/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-mingw@fedora SHOW_ENV=1 J=14
=== TEST SCRIPT END ===

  LINK    aarch64-softmmu/qemu-system-aarch64w.exe
numa.o:numa.c:(.rdata$.refptr.hmat_cache_info[.refptr.hmat_cache_info]+0x0): undefined reference to `hmat_cache_info'
numa.o:numa.c:(.rdata$.refptr.hmat_lb_info[.refptr.hmat_lb_info]+0x0): undefined reference to `hmat_lb_info'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:199: qemu-system-aarch64w.exe] Error 1
make: *** [Makefile:429: subdir-aarch64-softmmu] Error 2
Traceback (most recent call last):


The full log is available at
http://patchew.org/logs/20190131071658.29120-1-tao3.xu@intel.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v3 0/8] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

Posted by Igor Mammedov 7 years ago

On Thu, 31 Jan 2019 15:16:50 +0800
Tao Xu <tao3.xu@intel.com> wrote:

> This series of patches will build Heterogeneous Memory Attribute Table (HMAT)
> according to the command line. The ACPI HMAT describes the memory attributes,
> such as memory side cache attributes and bandwidth and latency details,
> related to the System Physical Address (SPA) Memory Ranges.
> The software is expected to use this information as hint for optimization.
> 
> OSPM evaluates HMAT only during system initialization. Any changes to the HMAT
> state at runtime or information regarding HMAT for hot plug are communicated
> using the _HMA method.
> 
> From 1 to 6 patches are the former V1 patches. From 7 to 8 patches are the
> updates per Igor and Eric's comments.
> 
> The V2 patches link:
> http://lists.nongnu.org/archive/html/qemu-devel/2019-01/msg02276.html
> The V1 RESEND patches link:
> http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg05368.html

pls, use build_append_int_noprefix() to build parts of ACPI table in all patches

> 
> Changelog:
> v3:
>   Per Eric's comments
>     - rebase the fixing patch into the jingqi's patches
>     - update the version tag from 3.10 to 4.0
> v2:
>   Per Igor and Eric's comments, fix some coding style and small issues:
>     - update the version number in qapi/misc.json
>     - including the expansion of the acronym HMAT in qapi/misc.json
>     - correct spell mistakes in qapi/misc.json and qemu-options.hx
>     - fix the comment syle in hw/i386/acpi-build.c
>     and hw/acpi/hmat.h
>    - remove some unnecessary head files in hw/acpi/hmat.c
>    - use hardcoded numbers from spec to generate
>    Memory Subsystem Address Range Structure in hw/acpi/hmat.c
>    - drop the struct AcpiHmat and AcpiHmatSpaRange
>     in hw/acpi/hmat.h
>   Per Igor's comment, rewrite NFIT code to build _HMA method.
> 
> Liu Jingqi (6):
>   hmat acpi: Build Memory Subsystem Address Range Structure(s) in ACPI
>     HMAT
>   hmat acpi: Build System Locality Latency and Bandwidth Information
>     Structure(s) in ACPI HMAT
>   hmat acpi: Build Memory Side Cache Information Structure(s) in ACPI
>     HMAT
>   Extend the command-line to provide memory latency and bandwidth
>     information
>   numa: Extend the command-line to provide memory side cache information
>   hmat acpi: Implement _HMA method to update HMAT at runtime
> 
> Tao Xu (2):
>   hmat acpi: move some function inside of the caller
>   acpi: rewrite the _FIT method to use it in _HMA method
> 
>  default-configs/i386-softmmu.mak |   1 +
>  hw/acpi/Makefile.objs            |   1 +
>  hw/acpi/hmat.c                   | 424 +++++++++++++++++++++++++++++++
>  hw/acpi/hmat.h                   | 245 ++++++++++++++++++
>  hw/acpi/nvdimm.c                 | 389 ++++++++++++++++++----------
>  hw/i386/acpi-build.c             | 125 +++++----
>  hw/i386/acpi-build.h             |  10 +
>  hw/i386/pc.c                     |   2 +
>  hw/i386/pc_piix.c                |   3 +
>  hw/i386/pc_q35.c                 |   3 +
>  include/hw/i386/pc.h             |   2 +
>  include/hw/mem/nvdimm.h          |  11 +
>  include/sysemu/numa.h            |   2 +
>  numa.c                           | 202 +++++++++++++++
>  qapi/misc.json                   | 162 +++++++++++-
>  qemu-options.hx                  |  28 +-
>  16 files changed, 1427 insertions(+), 183 deletions(-)
>  create mode 100644 hw/acpi/hmat.c
>  create mode 100644 hw/acpi/hmat.h
>