1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH] hw/input/adb.c: set device category of adb

kumar sourav posted 1 patch 6 years, 9 months ago
Test asan passed
Test docker-clang@ubuntu passed
Test docker-mingw@fedora passed
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190127100215.12584-1-sourav.jb1988@gmail.com
Maintainers: David Gibson <david@gibson.dropbear.id.au>
hw/input/adb.c | 1 +
1 file changed, 1 insertion(+)
[Qemu-devel] [PATCH] hw/input/adb.c: set device category of adb
Posted by kumar sourav 6 years, 9 months ago 
Sets the category of adb as DEVICE_CATEGORY_INPUT
Devices should be assigned to one of DEVICE_CATEGORY_XXXX

Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
---
 hw/input/adb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/input/adb.c b/hw/input/adb.c
index bbb40aeef1..6ca7c5641c 100644
--- a/hw/input/adb.c
+++ b/hw/input/adb.c
@@ -126,6 +126,7 @@ static void adb_device_class_init(ObjectClass *oc, void *data)
     dc->realize = adb_device_realizefn;
     dc->props = adb_device_properties;
     dc->bus_type = TYPE_ADB_BUS;
+    set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
 }
 
 static const TypeInfo adb_device_type_info = {
-- 
2.17.1
Re: [Qemu-devel] [PATCH] hw/input/adb.c: set device category of adb
Posted by David Gibson 6 years, 9 months ago 
On Sun, Jan 27, 2019 at 03:32:15PM +0530, kumar sourav wrote:
> Sets the category of adb as DEVICE_CATEGORY_INPUT
> Devices should be assigned to one of DEVICE_CATEGORY_XXXX
> 
> Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>

Applied, thanks.

> ---
>  hw/input/adb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/input/adb.c b/hw/input/adb.c
> index bbb40aeef1..6ca7c5641c 100644
> --- a/hw/input/adb.c
> +++ b/hw/input/adb.c
> @@ -126,6 +126,7 @@ static void adb_device_class_init(ObjectClass *oc, void *data)
>      dc->realize = adb_device_realizefn;
>      dc->props = adb_device_properties;
>      dc->bus_type = TYPE_ADB_BUS;
> +    set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
>  }
>  
>  static const TypeInfo adb_device_type_info = {

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/input/adb.c: set device category of adb
Posted by Thomas Huth 6 years, 9 months ago 
On 2019-01-27 11:02, kumar sourav wrote:
> Sets the category of adb as DEVICE_CATEGORY_INPUT
> Devices should be assigned to one of DEVICE_CATEGORY_XXXX
> 
> Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
> ---
>  hw/input/adb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/input/adb.c b/hw/input/adb.c
> index bbb40aeef1..6ca7c5641c 100644
> --- a/hw/input/adb.c
> +++ b/hw/input/adb.c
> @@ -126,6 +126,7 @@ static void adb_device_class_init(ObjectClass *oc, void *data)
>      dc->realize = adb_device_realizefn;
>      dc->props = adb_device_properties;
>      dc->bus_type = TYPE_ADB_BUS;
> +    set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
>  }

This patch does not make too much sense in its current shape:
TYPE_ADB_DEVICE is an abstract device and does not show up in the output
of "-device help", so it is not necessary for this device itself.

Looking at the "child" devices adb-kdb and adb-mouse, they bother
already set DEVICE_CATEGORY_INPUT in their own, so they are already fine.

Thus please do one of the following:

1) Simply drop this patch.

2) Keep setting the category here in the abstract parent class, but then
also remove the DEVICE_CATEGORY_INPUT in the adb-kdb and adb-mouse child
classes.

 Thomas
Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/input/adb.c: set device category of adb
Posted by David Gibson 6 years, 9 months ago 
On Mon, Jan 28, 2019 at 10:06:03AM +0100, Thomas Huth wrote:
> On 2019-01-27 11:02, kumar sourav wrote:
> > Sets the category of adb as DEVICE_CATEGORY_INPUT
> > Devices should be assigned to one of DEVICE_CATEGORY_XXXX
> > 
> > Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
> > ---
> >  hw/input/adb.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/hw/input/adb.c b/hw/input/adb.c
> > index bbb40aeef1..6ca7c5641c 100644
> > --- a/hw/input/adb.c
> > +++ b/hw/input/adb.c
> > @@ -126,6 +126,7 @@ static void adb_device_class_init(ObjectClass *oc, void *data)
> >      dc->realize = adb_device_realizefn;
> >      dc->props = adb_device_properties;
> >      dc->bus_type = TYPE_ADB_BUS;
> > +    set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> >  }
> 
> This patch does not make too much sense in its current shape:
> TYPE_ADB_DEVICE is an abstract device and does not show up in the output
> of "-device help", so it is not necessary for this device itself.
> 
> Looking at the "child" devices adb-kdb and adb-mouse, they bother
> already set DEVICE_CATEGORY_INPUT in their own, so they are already fine.
> 
> Thus please do one of the following:
> 
> 1) Simply drop this patch.
> 
> 2) Keep setting the category here in the abstract parent class, but then
> also remove the DEVICE_CATEGORY_INPUT in the adb-kdb and adb-mouse child
> classes.

Ah, good point.  Dropped from ppc-for-4.0.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.