[Qemu-devel] [PATCH] hw/i386/pc.c: fix one typo in function name

Wei Yang posted 1 patch 7 years ago
Test asan passed
Test docker-clang@ubuntu passed
Test docker-mingw@fedora passed
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190124073626.20534-1-richardw.yang@linux.intel.com
Maintainers: Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
hw/i386/pc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[Qemu-devel] [PATCH] hw/i386/pc.c: fix one typo in function name
Posted by Wei Yang 7 years ago
Rename pc_get_hotpug_handler to pc_get_hotplug_handler.

No functional change.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
 hw/i386/pc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 115bc2825c..5317e08f60 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -2059,7 +2059,7 @@ static void pc_machine_device_unplug_cb(HotplugHandler *hotplug_dev,
     }
 }
 
-static HotplugHandler *pc_get_hotpug_handler(MachineState *machine,
+static HotplugHandler *pc_get_hotplug_handler(MachineState *machine,
                                              DeviceState *dev)
 {
     if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM) ||
@@ -2389,7 +2389,7 @@ static void pc_machine_class_init(ObjectClass *oc, void *data)
     pcmc->save_tsc_khz = true;
     pcmc->linuxboot_dma_enabled = true;
     assert(!mc->get_hotplug_handler);
-    mc->get_hotplug_handler = pc_get_hotpug_handler;
+    mc->get_hotplug_handler = pc_get_hotplug_handler;
     mc->cpu_index_to_instance_props = pc_cpu_index_to_props;
     mc->get_default_cpu_node_id = pc_get_default_cpu_node_id;
     mc->possible_cpu_arch_ids = pc_possible_cpu_arch_ids;
-- 
2.19.1


Re: [Qemu-devel] [PATCH] hw/i386/pc.c: fix one typo in function name
Posted by Stefano Garzarella 7 years ago
CCing qemu-trivial@nongnu.org

On Thu, Jan 24, 2019 at 03:36:26PM +0800, Wei Yang wrote:
> Rename pc_get_hotpug_handler to pc_get_hotplug_handler.
> 
> No functional change.
> 
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> ---
>  hw/i386/pc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

Re: [Qemu-devel] [PATCH] hw/i386/pc.c: fix one typo in function name
Posted by Laurent Vivier 7 years ago
On 24/01/2019 08:36, Wei Yang wrote:
> Rename pc_get_hotpug_handler to pc_get_hotplug_handler.
> 
> No functional change.
> 
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> ---
>  hw/i386/pc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 115bc2825c..5317e08f60 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -2059,7 +2059,7 @@ static void pc_machine_device_unplug_cb(HotplugHandler *hotplug_dev,
>      }
>  }
>  
> -static HotplugHandler *pc_get_hotpug_handler(MachineState *machine,
> +static HotplugHandler *pc_get_hotplug_handler(MachineState *machine,
>                                               DeviceState *dev)
>  {
>      if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM) ||
> @@ -2389,7 +2389,7 @@ static void pc_machine_class_init(ObjectClass *oc, void *data)
>      pcmc->save_tsc_khz = true;
>      pcmc->linuxboot_dma_enabled = true;
>      assert(!mc->get_hotplug_handler);
> -    mc->get_hotplug_handler = pc_get_hotpug_handler;
> +    mc->get_hotplug_handler = pc_get_hotplug_handler;
>      mc->cpu_index_to_instance_props = pc_cpu_index_to_props;
>      mc->get_default_cpu_node_id = pc_get_default_cpu_node_id;
>      mc->possible_cpu_arch_ids = pc_possible_cpu_arch_ids;
> 


Applied to my trivial-patches branch.

Thanks,
Laurent