[Qemu-devel] [PATCH 0/1] input-linux: customizable grab toggle keys v5

Ryan El Kochta posted 1 patch 6 years, 9 months ago
Test asan passed
Test docker-clang@ubuntu passed
Test docker-mingw@fedora passed
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190123214555.12712-1-relkochta@gmail.com
Maintainers: Gerd Hoffmann <kraxel@redhat.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>
qapi/ui.json     | 10 ++++++++
ui/input-linux.c | 66 +++++++++++++++++++++++++++++++++++++++++++++---
2 files changed, 73 insertions(+), 3 deletions(-)
[Qemu-devel] [PATCH 0/1] input-linux: customizable grab toggle keys v5
Posted by Ryan El Kochta 6 years, 9 months ago
This patch adds a new option to the input-linux object:

grab-toggle=[key-combo]

The key combination can be one of the following:

* ctrl-ctrl
* alt-alt
* meta-meta
* scrolllock
* ctrl-scrolllock

The user can pick any of these key combinations. The VM's grab
of the evdev device will be toggled when the key combination is
pressed.

Any invalid setting will result in an error. No setting will
result in the current default of ctrl-ctrl.

The right and left ctrl key both work for Ctrl-Scrolllock.

If scrolllock is selected as one of the grab-toggle keys, it
will be entirely disabled and not passed to the guest at all.
This is to prevent enabling it while attempting to leave or enter
the VM. On the host, scrolllock can be disabled using xmodmap.

First, find the modifier that Scroll_Lock is bound to:

$ xmodmap -pm

Then, remove Scroll_Lock from it, replacing modX with the modifier:

$ xmodmap -e 'remove modX = Scroll_Lock'

If Scroll_Lock is not bound to any modifier, it is already disabled.

To save the changes, add them to your xinitrc.

Ryan El Kochta (1):
  input-linux: customizable grab toggle keys v5

 qapi/ui.json     | 10 ++++++++
 ui/input-linux.c | 66 +++++++++++++++++++++++++++++++++++++++++++++---
 2 files changed, 73 insertions(+), 3 deletions(-)

-- 
2.20.1


Re: [Qemu-devel] [PATCH 0/1] input-linux: customizable grab toggle keys v5
Posted by Gerd Hoffmann 6 years, 9 months ago
On Wed, Jan 23, 2019 at 04:45:54PM -0500, Ryan El Kochta wrote:
> This patch adds a new option to the input-linux object:
> 
> grab-toggle=[key-combo]

Other way around: commit message describing the patch goes to the patch
(1/1), the series description (and changes to previous revisions if any)
go to the cover letter (0/1).

Picked up the patch, copied over the description from the cover letter.

thanks,
  Gerd