[Qemu-devel] [PATCH 2/9] iotests: Remove superfluous rm from 232

Max Reitz posted 9 patches 6 years, 9 months ago
There is a newer version of this series
[Qemu-devel] [PATCH 2/9] iotests: Remove superfluous rm from 232
Posted by Max Reitz 6 years, 9 months ago
This test creates no such file.

Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 tests/qemu-iotests/232 | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/qemu-iotests/232 b/tests/qemu-iotests/232
index 0708b8b155..93e5d641a3 100755
--- a/tests/qemu-iotests/232
+++ b/tests/qemu-iotests/232
@@ -29,7 +29,6 @@ status=1	# failure is the default!
 _cleanup()
 {
     _cleanup_test_img
-    rm -f $TEST_IMG.snap
 }
 trap "_cleanup; exit \$status" 0 1 2 3 15
 
-- 
2.20.1


Re: [Qemu-devel] [PATCH 2/9] iotests: Remove superfluous rm from 232
Posted by Eric Blake 6 years, 9 months ago
On 1/23/19 8:46 AM, Max Reitz wrote:
> This test creates no such file.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  tests/qemu-iotests/232 | 1 -
>  1 file changed, 1 deletion(-)

I'd really like it if we could revive Jeff's patches that made ./check
run all tests in their own subdirectory, and then where the framework
could either keep all temporary files or remove the directory, rather
than each test having to track which files it touches.

But that's a bigger task; in the meantime, this patch is fine.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH 2/9] iotests: Remove superfluous rm from 232
Posted by John Snow 6 years, 9 months ago

On 1/23/19 9:46 AM, Max Reitz wrote:
> This test creates no such file.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>

Reviewed-by: John Snow <jsnow@redhat.com>

(+1 to Eric's suggestion of reviving Jeff's patches. Maybe I'll take a
look once I get my downstream queue under control...)

> ---
>  tests/qemu-iotests/232 | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/232 b/tests/qemu-iotests/232
> index 0708b8b155..93e5d641a3 100755
> --- a/tests/qemu-iotests/232
> +++ b/tests/qemu-iotests/232
> @@ -29,7 +29,6 @@ status=1	# failure is the default!
>  _cleanup()
>  {
>      _cleanup_test_img
> -    rm -f $TEST_IMG.snap
>  }
>  trap "_cleanup; exit \$status" 0 1 2 3 15
>  
>