target/xtensa: add qemu_cpu_kick to xtensa_runstall

[Qemu-devel] [PATCH] target/xtensa: add qemu_cpu_kick to xtensa_runstall

Max Filippov posted 1 patch 6 years, 9 months ago

Download mbox

Test asan passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190122212504.6137-1-jcmvbkbc@gmail.com

Maintainers: Max Filippov <jcmvbkbc@gmail.com>

target/xtensa/helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] target/xtensa: add qemu_cpu_kick to xtensa_runstall

Posted by Max Filippov 6 years, 9 months ago

When xtensa_runstall is called to unstall a core it needs to kick it
after clearing runstall flag, otherwise the core doesn't start
immediately. There's also no point in clearing CPU_INTERRUPT_HALT, drop
it.

Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
 target/xtensa/helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/xtensa/helper.c b/target/xtensa/helper.c
index 323c47a7fb54..bcf2f20d4858 100644
--- a/target/xtensa/helper.c
+++ b/target/xtensa/helper.c
@@ -252,7 +252,7 @@ void xtensa_runstall(CPUXtensaState *env, bool runstall)
     if (runstall) {
         cpu_interrupt(cpu, CPU_INTERRUPT_HALT);
     } else {
-        cpu_reset_interrupt(cpu, CPU_INTERRUPT_HALT);
+        qemu_cpu_kick(cpu);
     }
 }
 #endif
-- 
2.11.0