1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH] MAINTAINERS: update microbit ARM board files

Stefan Hajnoczi posted 1 patch 6 years, 9 months ago
Test asan passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190122162924.26491-1-stefanha@redhat.com
There is a newer version of this series
MAINTAINERS | 12 ++++++++++++
1 file changed, 12 insertions(+)
[Qemu-devel] [PATCH] MAINTAINERS: update microbit ARM board files
Posted by Stefan Hajnoczi 6 years, 9 months ago 
New source files were added without corresponding ./MAINTAINERS file
entries.  Let's get things up to date.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
This also includes the I2C/TWI stub which Peter has merged into his
target-arm.next tree but isn't in qemu.git/master yet.
---
 MAINTAINERS | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index af339b86db..e3cb67e81d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -833,7 +833,19 @@ L: qemu-arm@nongnu.org
 S: Maintained
 F: hw/arm/nrf51_soc.c
 F: hw/arm/microbit.c
+F: hw/char/nrf51_uart.c
+F: hw/gpio/nrf51_gpio.c
+F: hw/i2c/microbit_i2c.c
+F: hw/misc/nrf51_rng.c
+F: hw/timer/nrf51_timer.c
 F: include/hw/arm/nrf51_soc.h
+F: include/hw/arm/nrf51.h
+F: include/hw/char/nrf51_uart.h
+F: include/hw/gpio/nrf51_gpio.h
+F: include/hw/i2c/microbit_i2c.h
+F: include/hw/misc/nrf51_rng.h
+F: include/hw/timer/nrf51_timer.h
+F: tests/microbit-test.c
 
 CRIS Machines
 -------------
-- 
2.20.1
Re: [Qemu-devel] [PATCH] MAINTAINERS: update microbit ARM board files
Posted by Thomas Huth 6 years, 9 months ago 
On 2019-01-22 17:29, Stefan Hajnoczi wrote:
> New source files were added without corresponding ./MAINTAINERS file
> entries.  Let's get things up to date.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> This also includes the I2C/TWI stub which Peter has merged into his
> target-arm.next tree but isn't in qemu.git/master yet.
> ---
>  MAINTAINERS | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index af339b86db..e3cb67e81d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -833,7 +833,19 @@ L: qemu-arm@nongnu.org
>  S: Maintained
>  F: hw/arm/nrf51_soc.c
>  F: hw/arm/microbit.c
> +F: hw/char/nrf51_uart.c
> +F: hw/gpio/nrf51_gpio.c
> +F: hw/i2c/microbit_i2c.c
> +F: hw/misc/nrf51_rng.c
> +F: hw/timer/nrf51_timer.c
>  F: include/hw/arm/nrf51_soc.h
> +F: include/hw/arm/nrf51.h
> +F: include/hw/char/nrf51_uart.h
> +F: include/hw/gpio/nrf51_gpio.h
> +F: include/hw/i2c/microbit_i2c.h
> +F: include/hw/misc/nrf51_rng.h
> +F: include/hw/timer/nrf51_timer.h
> +F: tests/microbit-test.c

Looks like using wildcards would be easier here:

F: hw/*/nrf51*.c
F: hw/*/microbit*.c
F: include/hw/*/nrf51*.h
...

?

Anyway:

Reviewed-by: Thomas Huth <thuth@redhat.com>
Re: [Qemu-devel] [PATCH] MAINTAINERS: update microbit ARM board files
Posted by Philippe Mathieu-Daudé 6 years, 9 months ago 
On 1/23/19 7:19 AM, Thomas Huth wrote:
> On 2019-01-22 17:29, Stefan Hajnoczi wrote:
>> New source files were added without corresponding ./MAINTAINERS file
>> entries.  Let's get things up to date.
>>
>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>> This also includes the I2C/TWI stub which Peter has merged into his
>> target-arm.next tree but isn't in qemu.git/master yet.
>> ---
>>  MAINTAINERS | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index af339b86db..e3cb67e81d 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -833,7 +833,19 @@ L: qemu-arm@nongnu.org
>>  S: Maintained
>>  F: hw/arm/nrf51_soc.c
>>  F: hw/arm/microbit.c
>> +F: hw/char/nrf51_uart.c
>> +F: hw/gpio/nrf51_gpio.c
>> +F: hw/i2c/microbit_i2c.c
>> +F: hw/misc/nrf51_rng.c
>> +F: hw/timer/nrf51_timer.c
>>  F: include/hw/arm/nrf51_soc.h
>> +F: include/hw/arm/nrf51.h
>> +F: include/hw/char/nrf51_uart.h
>> +F: include/hw/gpio/nrf51_gpio.h
>> +F: include/hw/i2c/microbit_i2c.h
>> +F: include/hw/misc/nrf51_rng.h
>> +F: include/hw/timer/nrf51_timer.h
>> +F: tests/microbit-test.c
> 
> Looks like using wildcards would be easier here:
> 
> F: hw/*/nrf51*.c
> F: hw/*/microbit*.c
> F: include/hw/*/nrf51*.h

Agreed :)

> ...
> 
> ?
> 
> Anyway:
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Re: [Qemu-devel] [PATCH] MAINTAINERS: update microbit ARM board files
Posted by Stefan Hajnoczi 6 years, 9 months ago 
On Wed, Jan 23, 2019 at 07:19:57AM +0100, Thomas Huth wrote:
> On 2019-01-22 17:29, Stefan Hajnoczi wrote:
> > New source files were added without corresponding ./MAINTAINERS file
> > entries.  Let's get things up to date.
> > 
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > This also includes the I2C/TWI stub which Peter has merged into his
> > target-arm.next tree but isn't in qemu.git/master yet.
> > ---
> >  MAINTAINERS | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index af339b86db..e3cb67e81d 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -833,7 +833,19 @@ L: qemu-arm@nongnu.org
> >  S: Maintained
> >  F: hw/arm/nrf51_soc.c
> >  F: hw/arm/microbit.c
> > +F: hw/char/nrf51_uart.c
> > +F: hw/gpio/nrf51_gpio.c
> > +F: hw/i2c/microbit_i2c.c
> > +F: hw/misc/nrf51_rng.c
> > +F: hw/timer/nrf51_timer.c
> >  F: include/hw/arm/nrf51_soc.h
> > +F: include/hw/arm/nrf51.h
> > +F: include/hw/char/nrf51_uart.h
> > +F: include/hw/gpio/nrf51_gpio.h
> > +F: include/hw/i2c/microbit_i2c.h
> > +F: include/hw/misc/nrf51_rng.h
> > +F: include/hw/timer/nrf51_timer.h
> > +F: tests/microbit-test.c
> 
> Looks like using wildcards would be easier here:
> 
> F: hw/*/nrf51*.c
> F: hw/*/microbit*.c
> F: include/hw/*/nrf51*.h
> ...
> 
> ?

Will send v2.

Stefan

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.