[Qemu-devel] [PULL 0/8] Bitmaps patches

John Snow posted 8 patches 6 years, 8 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
block/backup.c               |   5 +-
block/dirty-bitmap.c         |  68 ++------------
block/mirror.c               |  17 ++--
include/block/dirty-bitmap.h |   7 +-
include/qemu/hbitmap.h       |  29 ++++--
nbd/server.c                 |   2 +-
tests/test-hbitmap.c         | 177 +++++++++++++++++++++++++++++------
util/hbitmap.c               |  76 ++++++++++++---
8 files changed, 261 insertions(+), 120 deletions(-)
[Qemu-devel] [PULL 0/8] Bitmaps patches
Posted by John Snow 6 years, 8 months ago
The following changes since commit 4b9f0b0f7c84eea2dfb0d5be3e0254bc91319dbc:

  Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-01-15 17:24:00 +0000)

are available in the Git repository at:

  https://github.com/jnsnow/qemu.git tags/bitmaps-pull-request

for you to fetch changes up to 19c021e1948a81c4ba19b3ff735432b45b6aebee:

  Revert "hbitmap: Add @advance param to hbitmap_iter_next()" (2019-01-15 18:26:50 -0500)

----------------------------------------------------------------
Pull request

----------------------------------------------------------------

Vladimir Sementsov-Ogievskiy (8):
  dirty-bitmap: improve bdrv_dirty_bitmap_next_zero
  tests: add tests for hbitmap_next_zero with specified end parameter
  dirty-bitmap: add bdrv_dirty_bitmap_next_dirty_area
  tests: add tests for hbitmap_next_dirty_area
  block/mirror: fix and improve do_sync_target_write
  Revert "block/dirty-bitmap: Add bdrv_dirty_iter_next_area"
  Revert "test-hbitmap: Add non-advancing iter_next tests"
  Revert "hbitmap: Add @advance param to hbitmap_iter_next()"

 block/backup.c               |   5 +-
 block/dirty-bitmap.c         |  68 ++------------
 block/mirror.c               |  17 ++--
 include/block/dirty-bitmap.h |   7 +-
 include/qemu/hbitmap.h       |  29 ++++--
 nbd/server.c                 |   2 +-
 tests/test-hbitmap.c         | 177 +++++++++++++++++++++++++++++------
 util/hbitmap.c               |  76 ++++++++++++---
 8 files changed, 261 insertions(+), 120 deletions(-)

-- 
2.17.2


Re: [Qemu-devel] [PULL 0/8] Bitmaps patches
Posted by Peter Maydell 6 years, 8 months ago
On Wed, 16 Jan 2019 at 01:01, John Snow <jsnow@redhat.com> wrote:
>
> The following changes since commit 4b9f0b0f7c84eea2dfb0d5be3e0254bc91319dbc:
>
>   Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-01-15 17:24:00 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/jnsnow/qemu.git tags/bitmaps-pull-request
>
> for you to fetch changes up to 19c021e1948a81c4ba19b3ff735432b45b6aebee:
>
>   Revert "hbitmap: Add @advance param to hbitmap_iter_next()" (2019-01-15 18:26:50 -0500)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0
for any user-visible changes.

-- PMM

Re: [Qemu-devel] [PULL 0/8] Bitmaps patches
Posted by no-reply@patchew.org 6 years, 8 months ago
Patchew URL: https://patchew.org/QEMU/20190116010106.27626-1-jsnow@redhat.com/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-mingw@fedora SHOW_ENV=1 J=14
=== TEST SCRIPT END ===

  CC      crypto/block.o
  CC      crypto/block-qcow.o
/tmp/qemu-test/src/block/sheepdog.c: In function 'find_vdi_name':
/tmp/qemu-test/src/block/sheepdog.c:1239:5: error: 'strncpy' specified bound 256 equals destination size [-Werror=stringop-truncation]
     strncpy(buf + SD_MAX_VDI_LEN, tag, SD_MAX_VDI_TAG_LEN);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors


The full log is available at
http://patchew.org/logs/20190116010106.27626-1-jsnow@redhat.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PULL 0/8] Bitmaps patches
Posted by Philippe Mathieu-Daudé 6 years, 8 months ago
On 1/21/19 8:54 AM, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20190116010106.27626-1-jsnow@redhat.com/
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> time make docker-test-mingw@fedora SHOW_ENV=1 J=14
> === TEST SCRIPT END ===
> 
>   CC      crypto/block.o
>   CC      crypto/block-qcow.o
> /tmp/qemu-test/src/block/sheepdog.c: In function 'find_vdi_name':
> /tmp/qemu-test/src/block/sheepdog.c:1239:5: error: 'strncpy' specified bound 256 equals destination size [-Werror=stringop-truncation]
>      strncpy(buf + SD_MAX_VDI_LEN, tag, SD_MAX_VDI_TAG_LEN);
>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors

Thanks Patchew, this error is now fixed (merged in 51c1c135608).


Re: [Qemu-devel] [PULL 0/8] Bitmaps patches
Posted by Daniel P. Berrangé 6 years, 8 months ago
On Mon, Jan 21, 2019 at 01:21:34PM +0100, Philippe Mathieu-Daudé wrote:
> On 1/21/19 8:54 AM, no-reply@patchew.org wrote:
> > Patchew URL: https://patchew.org/QEMU/20190116010106.27626-1-jsnow@redhat.com/
> > 
> > === TEST SCRIPT BEGIN ===
> > #!/bin/bash
> > time make docker-test-mingw@fedora SHOW_ENV=1 J=14
> > === TEST SCRIPT END ===
> > 
> >   CC      crypto/block.o
> >   CC      crypto/block-qcow.o
> > /tmp/qemu-test/src/block/sheepdog.c: In function 'find_vdi_name':
> > /tmp/qemu-test/src/block/sheepdog.c:1239:5: error: 'strncpy' specified bound 256 equals destination size [-Werror=stringop-truncation]
> >      strncpy(buf + SD_MAX_VDI_LEN, tag, SD_MAX_VDI_TAG_LEN);
> >      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
> 
> Thanks Patchew, this error is now fixed (merged in 51c1c135608).

patchew's build test queue seems to running about 5 days slow, but its
git apply queue is timely. So it is testing this patch using git head
as of 5 days ago, despite the build only running today.

So I presume the fix in 51c1c135608 will only start to have effect for
patches that patchew imported to git after 51c1c135608 merged.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [Qemu-devel] [PULL 0/8] Bitmaps patches
Posted by John Snow 6 years, 8 months ago

On 1/21/19 2:54 AM, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20190116010106.27626-1-jsnow@redhat.com/
> 
> 
> 
> Hi,
> 
> This series failed the docker-mingw@fedora build test. Please find the testing commands and
> their output below. If you have Docker installed, you can probably reproduce it
> locally.
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> time make docker-test-mingw@fedora SHOW_ENV=1 J=14
> === TEST SCRIPT END ===
> 
>   CC      crypto/block.o
>   CC      crypto/block-qcow.o
> /tmp/qemu-test/src/block/sheepdog.c: In function 'find_vdi_name':
> /tmp/qemu-test/src/block/sheepdog.c:1239:5: error: 'strncpy' specified bound 256 equals destination size [-Werror=stringop-truncation]
>      strncpy(buf + SD_MAX_VDI_LEN, tag, SD_MAX_VDI_TAG_LEN);
>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> 
> 
> The full log is available at
> http://patchew.org/logs/20190116010106.27626-1-jsnow@redhat.com/testing.docker-mingw@fedora/?type=message.
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to patchew-devel@redhat.com
> 

Not related to this patchset.

--js