[v2] throttle-groups: fix restart coroutine iothread race

[Qemu-devel] [PATCH v2 0/2] throttle-groups: fix restart coroutine iothread race

Stefan Hajnoczi posted 2 patches 5 years, 3 months ago

Diff against v1
Download series mbox

Test asan passed

Test checkpatch passed

Test docker-clang@ubuntu passed

Test docker-mingw@fedora passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190114133257.30299-1-stefanha@redhat.com

Maintainers: Alberto Garcia <berto@igalia.com>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>

include/block/throttle-groups.h |  5 ++++
block/throttle-groups.c         |  9 +++++++
tests/qemu-iotests/238          | 47 +++++++++++++++++++++++++++++++++
tests/qemu-iotests/238.out      |  6 +++++
tests/qemu-iotests/group        |  1 +
5 files changed, 68 insertions(+)
create mode 100755 tests/qemu-iotests/238
create mode 100644 tests/qemu-iotests/238.out

Expand all Fold all

[Qemu-devel] [PATCH v2 0/2] throttle-groups: fix restart coroutine iothread race

Posted by Stefan Hajnoczi 5 years, 3 months ago

v2:
 * Added qemu-iotests test case [Kevin, Alberto]
 * Use atomic operations instead of AioContext lock [Paolo]

This patch series fixes a segfault upon device_del when virtio-scsi is used
with iothreads.

Stefan Hajnoczi (2):
  throttle-groups: fix restart coroutine iothread race
  iotests: add 238 for throttling tgm unregister iothread segfault

 include/block/throttle-groups.h |  5 ++++
 block/throttle-groups.c         |  9 +++++++
 tests/qemu-iotests/238          | 47 +++++++++++++++++++++++++++++++++
 tests/qemu-iotests/238.out      |  6 +++++
 tests/qemu-iotests/group        |  1 +
 5 files changed, 68 insertions(+)
 create mode 100755 tests/qemu-iotests/238
 create mode 100644 tests/qemu-iotests/238.out

-- 
2.20.1

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] throttle-groups: fix restart coroutine iothread race

Posted by Stefan Hajnoczi 5 years, 3 months ago

On Mon, Jan 14, 2019 at 01:32:55PM +0000, Stefan Hajnoczi wrote:
> v2:
>  * Added qemu-iotests test case [Kevin, Alberto]
>  * Use atomic operations instead of AioContext lock [Paolo]
> 
> This patch series fixes a segfault upon device_del when virtio-scsi is used
> with iothreads.
> 
> Stefan Hajnoczi (2):
>   throttle-groups: fix restart coroutine iothread race
>   iotests: add 238 for throttling tgm unregister iothread segfault
> 
>  include/block/throttle-groups.h |  5 ++++
>  block/throttle-groups.c         |  9 +++++++
>  tests/qemu-iotests/238          | 47 +++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/238.out      |  6 +++++
>  tests/qemu-iotests/group        |  1 +
>  5 files changed, 68 insertions(+)
>  create mode 100755 tests/qemu-iotests/238
>  create mode 100644 tests/qemu-iotests/238.out
> 
> -- 
> 2.20.1
> 
> 

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan