[Qemu-devel] [PATCH for-4.0 0/5] fix some segmentation faults and migration issues

Fei Li posted 5 patches 5 years, 3 months ago
Test asan passed
Test checkpatch passed
Test docker-clang@ubuntu passed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190113140849.38339-1-lifei1214@126.com
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Juan Quintela <quintela@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>
migration/channel.c      | 11 ++++++-----
migration/migration.c    | 40 +++++++++++++++++++++-------------------
migration/migration.h    |  2 +-
migration/postcopy-ram.c |  1 +
migration/ram.c          | 28 ++++++++++++++++++----------
migration/ram.h          |  4 ++--
migration/savevm.c       |  1 +
util/main-loop.c         |  8 ++++----
8 files changed, 54 insertions(+), 41 deletions(-)
[Qemu-devel] [PATCH for-4.0 0/5] fix some segmentation faults and migration issues
Posted by Fei Li 5 years, 3 months ago
All these five patches have gotten the Reviewed-by: the first patch
is to fix one segmentation fault and the other four are to fix some
migration issues.

To be more detail, they are extracted from previous
"[PATCH for-4.0 v9 16/16] qemu_thread_create: propagate errors to
callers to handle.", but actually these five patches are derivative
and not relevant to the mentioned qemu_thread_create patch series.
Thus send them separately to make them be merged earlier.

Fei Li (5):
  Fix segmentation fault when qemu_signal_init fails
  migration: fix the multifd code when receiving less channels
  migration: multifd_save_cleanup() can't fail, simplify
  migration: add more error handling for postcopy_ram_enable_notify
  migration: unify error handling for process_incoming_migration_co

 migration/channel.c      | 11 ++++++-----
 migration/migration.c    | 40 +++++++++++++++++++++-------------------
 migration/migration.h    |  2 +-
 migration/postcopy-ram.c |  1 +
 migration/ram.c          | 28 ++++++++++++++++++----------
 migration/ram.h          |  4 ++--
 migration/savevm.c       |  1 +
 util/main-loop.c         |  8 ++++----
 8 files changed, 54 insertions(+), 41 deletions(-)

-- 
2.17.2 (Apple Git-113)



Re: [Qemu-devel] [PATCH for-4.0 0/5] fix some segmentation faults and migration issues
Posted by Fei Li 5 years, 3 months ago
Hi all,

Kindly ping. :)

As my v10 of qemu_thread_create partly rely on this patch series, I'd 
like to know
when will these 5 patches be merged, or I join them with v10 of 
qemu_thread_create
and send together. Could anyone shed light on me? Thanks for the advice 
in advance.


Have a nice day
Fei
在 2019/1/13 下午10:08, Fei Li 写道:
> All these five patches have gotten the Reviewed-by: the first patch
> is to fix one segmentation fault and the other four are to fix some
> migration issues.
>
> To be more detail, they are extracted from previous
> "[PATCH for-4.0 v9 16/16] qemu_thread_create: propagate errors to
> callers to handle.", but actually these five patches are derivative
> and not relevant to the mentioned qemu_thread_create patch series.
> Thus send them separately to make them be merged earlier.
>
> Fei Li (5):
>    Fix segmentation fault when qemu_signal_init fails
>    migration: fix the multifd code when receiving less channels
>    migration: multifd_save_cleanup() can't fail, simplify
>    migration: add more error handling for postcopy_ram_enable_notify
>    migration: unify error handling for process_incoming_migration_co
>
>   migration/channel.c      | 11 ++++++-----
>   migration/migration.c    | 40 +++++++++++++++++++++-------------------
>   migration/migration.h    |  2 +-
>   migration/postcopy-ram.c |  1 +
>   migration/ram.c          | 28 ++++++++++++++++++----------
>   migration/ram.h          |  4 ++--
>   migration/savevm.c       |  1 +
>   util/main-loop.c         |  8 ++++----
>   8 files changed, 54 insertions(+), 41 deletions(-)
>

Re: [Qemu-devel] [PATCH for-4.0 0/5] fix some segmentation faults and migration issues
Posted by Philippe Mathieu-Daudé 5 years, 3 months ago
On 1/16/19 5:50 AM, Fei Li wrote:
> Hi all,
> 
> Kindly ping. :)
> 
> As my v10 of qemu_thread_create partly rely on this patch series, I'd
> like to know
> when will these 5 patches be merged, or I join them with v10 of
> qemu_thread_create
> and send together. Could anyone shed light on me? Thanks for the advice
> in advance.

This series would get merged quicker if you include the maintainers :)

$ ./scripts/get_maintainer.pl -f migration/*
Juan Quintela <quintela@redhat.com> (maintainer:Migration)
"Dr. David Alan Gilbert" <dgilbert@redhat.com> (maintainer:Migration)

Doing that for you by responding to this mail.

Regards,

Phil.

> 
> 
> Have a nice day
> Fei
> 在 2019/1/13 下午10:08, Fei Li 写道:
>> All these five patches have gotten the Reviewed-by: the first patch
>> is to fix one segmentation fault and the other four are to fix some
>> migration issues.
>>
>> To be more detail, they are extracted from previous
>> "[PATCH for-4.0 v9 16/16] qemu_thread_create: propagate errors to
>> callers to handle.", but actually these five patches are derivative
>> and not relevant to the mentioned qemu_thread_create patch series.
>> Thus send them separately to make them be merged earlier.
>>
>> Fei Li (5):
>>    Fix segmentation fault when qemu_signal_init fails
>>    migration: fix the multifd code when receiving less channels
>>    migration: multifd_save_cleanup() can't fail, simplify
>>    migration: add more error handling for postcopy_ram_enable_notify
>>    migration: unify error handling for process_incoming_migration_co
>>
>>   migration/channel.c      | 11 ++++++-----
>>   migration/migration.c    | 40 +++++++++++++++++++++-------------------
>>   migration/migration.h    |  2 +-
>>   migration/postcopy-ram.c |  1 +
>>   migration/ram.c          | 28 ++++++++++++++++++----------
>>   migration/ram.h          |  4 ++--
>>   migration/savevm.c       |  1 +
>>   util/main-loop.c         |  8 ++++----
>>   8 files changed, 54 insertions(+), 41 deletions(-)
>>
> 

Re: [Qemu-devel] [PATCH for-4.0 0/5] fix some segmentation faults and migration issues
Posted by Dr. David Alan Gilbert 5 years, 3 months ago
* Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
> On 1/16/19 5:50 AM, Fei Li wrote:
> > Hi all,
> > 
> > Kindly ping. :)
> > 
> > As my v10 of qemu_thread_create partly rely on this patch series, I'd
> > like to know
> > when will these 5 patches be merged, or I join them with v10 of
> > qemu_thread_create
> > and send together. Could anyone shed light on me? Thanks for the advice
> > in advance.
> 
> This series would get merged quicker if you include the maintainers :)
> 
> $ ./scripts/get_maintainer.pl -f migration/*
> Juan Quintela <quintela@redhat.com> (maintainer:Migration)
> "Dr. David Alan Gilbert" <dgilbert@redhat.com> (maintainer:Migration)
> 
> Doing that for you by responding to this mail.

We can do it via migration now the set is complete.

Dave

> 
> Regards,
> 
> Phil.
> 
> > 
> > 
> > Have a nice day
> > Fei
> > 在 2019/1/13 下午10:08, Fei Li 写道:
> >> All these five patches have gotten the Reviewed-by: the first patch
> >> is to fix one segmentation fault and the other four are to fix some
> >> migration issues.
> >>
> >> To be more detail, they are extracted from previous
> >> "[PATCH for-4.0 v9 16/16] qemu_thread_create: propagate errors to
> >> callers to handle.", but actually these five patches are derivative
> >> and not relevant to the mentioned qemu_thread_create patch series.
> >> Thus send them separately to make them be merged earlier.
> >>
> >> Fei Li (5):
> >>    Fix segmentation fault when qemu_signal_init fails
> >>    migration: fix the multifd code when receiving less channels
> >>    migration: multifd_save_cleanup() can't fail, simplify
> >>    migration: add more error handling for postcopy_ram_enable_notify
> >>    migration: unify error handling for process_incoming_migration_co
> >>
> >>   migration/channel.c      | 11 ++++++-----
> >>   migration/migration.c    | 40 +++++++++++++++++++++-------------------
> >>   migration/migration.h    |  2 +-
> >>   migration/postcopy-ram.c |  1 +
> >>   migration/ram.c          | 28 ++++++++++++++++++----------
> >>   migration/ram.h          |  4 ++--
> >>   migration/savevm.c       |  1 +
> >>   util/main-loop.c         |  8 ++++----
> >>   8 files changed, 54 insertions(+), 41 deletions(-)
> >>
> > 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH for-4.0 0/5] fix some segmentation faults and migration issues
Posted by fei 5 years, 3 months ago

> 在 2019年1月16日,23:00,Dr. David Alan Gilbert <dgilbert@redhat.com> 写道:
> 
> * Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
>>> On 1/16/19 5:50 AM, Fei Li wrote:
>>> Hi all,
>>> 
>>> Kindly ping. :)
>>> 
>>> As my v10 of qemu_thread_create partly rely on this patch series, I'd
>>> like to know
>>> when will these 5 patches be merged, or I join them with v10 of
>>> qemu_thread_create
>>> and send together. Could anyone shed light on me? Thanks for the advice
>>> in advance.
>> 
>> This series would get merged quicker if you include the maintainers :)
>> 
>> $ ./scripts/get_maintainer.pl -f migration/*
>> Juan Quintela <quintela@redhat.com> (maintainer:Migration)
>> "Dr. David Alan Gilbert" <dgilbert@redhat.com> (maintainer:Migration)
>> 
>> Doing that for you by responding to this mail.
> 
> We can do it via migration now the set is complete.
> 
> Dave
> 
Thanks all! :)

Have a nice day
Fei
>> 
>> Regards,
>> 
>> Phil.
>> 
>>> 
>>> 
>>> Have a nice day
>>> Fei
>>>> 在 2019/1/13 下午10:08, Fei Li 写道:
>>>> All these five patches have gotten the Reviewed-by: the first patch
>>>> is to fix one segmentation fault and the other four are to fix some
>>>> migration issues.
>>>> 
>>>> To be more detail, they are extracted from previous
>>>> "[PATCH for-4.0 v9 16/16] qemu_thread_create: propagate errors to
>>>> callers to handle.", but actually these five patches are derivative
>>>> and not relevant to the mentioned qemu_thread_create patch series.
>>>> Thus send them separately to make them be merged earlier.
>>>> 
>>>> Fei Li (5):
>>>>    Fix segmentation fault when qemu_signal_init fails
>>>>    migration: fix the multifd code when receiving less channels
>>>>    migration: multifd_save_cleanup() can't fail, simplify
>>>>    migration: add more error handling for postcopy_ram_enable_notify
>>>>    migration: unify error handling for process_incoming_migration_co
>>>> 
>>>>   migration/channel.c      | 11 ++++++-----
>>>>   migration/migration.c    | 40 +++++++++++++++++++++-------------------
>>>>   migration/migration.h    |  2 +-
>>>>   migration/postcopy-ram.c |  1 +
>>>>   migration/ram.c          | 28 ++++++++++++++++++----------
>>>>   migration/ram.h          |  4 ++--
>>>>   migration/savevm.c       |  1 +
>>>>   util/main-loop.c         |  8 ++++----
>>>>   8 files changed, 54 insertions(+), 41 deletions(-)
>>>> 
>>> 
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK


Re: [Qemu-devel] [PATCH for-4.0 0/5] fix some segmentation faults and migration issues
Posted by Dr. David Alan Gilbert 5 years, 2 months ago
* fei (lifei1214@126.com) wrote:
> 
> 
> > 在 2019年1月16日,23:00,Dr. David Alan Gilbert <dgilbert@redhat.com> 写道:
> > 
> > * Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
> >>> On 1/16/19 5:50 AM, Fei Li wrote:
> >>> Hi all,
> >>> 
> >>> Kindly ping. :)
> >>> 
> >>> As my v10 of qemu_thread_create partly rely on this patch series, I'd
> >>> like to know
> >>> when will these 5 patches be merged, or I join them with v10 of
> >>> qemu_thread_create
> >>> and send together. Could anyone shed light on me? Thanks for the advice
> >>> in advance.
> >> 
> >> This series would get merged quicker if you include the maintainers :)
> >> 
> >> $ ./scripts/get_maintainer.pl -f migration/*
> >> Juan Quintela <quintela@redhat.com> (maintainer:Migration)
> >> "Dr. David Alan Gilbert" <dgilbert@redhat.com> (maintainer:Migration)
> >> 
> >> Doing that for you by responding to this mail.
> > 
> > We can do it via migration now the set is complete.
> > 
> > Dave
> > 
> Thanks all! :)

Queued for migration.

Dave

> Have a nice day
> Fei
> >> 
> >> Regards,
> >> 
> >> Phil.
> >> 
> >>> 
> >>> 
> >>> Have a nice day
> >>> Fei
> >>>> 在 2019/1/13 下午10:08, Fei Li 写道:
> >>>> All these five patches have gotten the Reviewed-by: the first patch
> >>>> is to fix one segmentation fault and the other four are to fix some
> >>>> migration issues.
> >>>> 
> >>>> To be more detail, they are extracted from previous
> >>>> "[PATCH for-4.0 v9 16/16] qemu_thread_create: propagate errors to
> >>>> callers to handle.", but actually these five patches are derivative
> >>>> and not relevant to the mentioned qemu_thread_create patch series.
> >>>> Thus send them separately to make them be merged earlier.
> >>>> 
> >>>> Fei Li (5):
> >>>>    Fix segmentation fault when qemu_signal_init fails
> >>>>    migration: fix the multifd code when receiving less channels
> >>>>    migration: multifd_save_cleanup() can't fail, simplify
> >>>>    migration: add more error handling for postcopy_ram_enable_notify
> >>>>    migration: unify error handling for process_incoming_migration_co
> >>>> 
> >>>>   migration/channel.c      | 11 ++++++-----
> >>>>   migration/migration.c    | 40 +++++++++++++++++++++-------------------
> >>>>   migration/migration.h    |  2 +-
> >>>>   migration/postcopy-ram.c |  1 +
> >>>>   migration/ram.c          | 28 ++++++++++++++++++----------
> >>>>   migration/ram.h          |  4 ++--
> >>>>   migration/savevm.c       |  1 +
> >>>>   util/main-loop.c         |  8 ++++----
> >>>>   8 files changed, 54 insertions(+), 41 deletions(-)
> >>>> 
> >>> 
> > --
> > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK